ArticleCategoryRepository::whereStatusActive() - Code Metrics - Inspection of "V5.1.15" - webshelf/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 70e47f...dda101 )

by Mark

created 2018-03-24 15:49 UTC

ArticleCategoryRepository::whereStatusActive() A

↳ Parent: ArticleCategoryRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace App\Classes\Repositories;

use App\Model\Menu;
use Illuminate\Support\Collection;
use Illuminate\Database\Eloquent\Builder;
use App\Model\ArticleCategory;

/**
 * Class ArticleCategoryRepository
 *
 * @package App\Classes\Repositories
 */
class ArticleCategoryRepository extends BaseRepository
{
    /**
     * @var ArticleCategory|Builder|Collection
     */
    protected $model;

    /**
     * PageRepository constructor.
     *
     * @param Menu $model

     */
    public function __construct(ArticleCategory $model)
    {
        $this->model = $model;
    }

    /**
     * @return \Illuminate\Database\Eloquent\Collection|mixed|static[]
     */
    public function whereStatusActive()
    {
        return $this->model->where('status', true)->get();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}

Scrutinizer GitHub App not installed

Push — master ( 70e47f...dda101 )

ArticleCategoryRepository::whereStatusActive() A

Complexity

Size

Duplication

Importance

Available Fixes

1			<?php
2
3			namespace App\Classes\Repositories;
4
5			use App\Model\Menu;
6			use Illuminate\Support\Collection;
7			use Illuminate\Database\Eloquent\Builder;
8			use App\Model\ArticleCategory;
9
10			/**
11			* Class ArticleCategoryRepository
12			*
13			* @package App\Classes\Repositories
14			*/
15			class ArticleCategoryRepository extends BaseRepository
16			{
17			/**
18			* @var ArticleCategory\|Builder\|Collection
19			*/
20			protected $model;
21
22			/**
23			* PageRepository constructor.
24			*
25			* @param Menu $model
			0 ignored issues – show Documentation introduced 2018-03-24 15:56 UTC by Report Bug Copy Issue Report Consider making the type for parameter `$model` a bit more specific; maybe use `ArticleCategory`. Loading history...
26			*/
27			public function __construct(ArticleCategory $model)
28			{
29			$this->model = $model;
30			}
31
32			/**
33			* @return \Illuminate\Database\Eloquent\Collection\|mixed\|static[]
34			*/
35			public function whereStatusActive()
36			{
37			return $this->model->where('status', true)->get();
			0 ignored issues – show Bug introduced 2018-03-24 15:56 UTC by Report Bug Copy Issue Report The method `where` does only exist in `Illuminate\Database\Eloq...nate\Support\Collection`, but not in `App\Model\ArticleCategory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
38			}
39			}

webshelf / framework

Scrutinizer GitHub App not installed

Push — master ( 70e47f...dda101 )

ArticleCategoryRepository::whereStatusActive() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like