App\Plugins\Articles\BackendController

Complexity

Total Complexity

16

Size/Duplication

Total Lines	212
Duplicated Lines	19.81 %

Coupling/Cohesion

Components	1
Dependencies	12

Importance

Changes

0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	index()	0	4	1
A	create()	0	4	1
A	form()	0	4	1
A	store()	10	10	1
A	show()	0	4	1
A	edit()	0	4	1
A	update()	10	10	1
A	destroy()	10	10	1
A	categories()	0	4	1
A	categories_store()	12	12	1
A	categories_destroy()	0	10	1
B	save()	0	29	4

<?php
/**
 * Created by PhpStorm.
 * User: Mark
 * Date: 05/03/2016
 * Time: 20:30.
 */

namespace App\Plugins\Articles;

use Carbon\Carbon;
use App\Model\Article;
use App\Model\Activity;
use Illuminate\Http\Request;
use App\Plugins\PluginEngine;
use App\Model\ArticleCategory;
use Illuminate\Validation\Rule;
use App\Classes\Repositories\ArticleRepository;
use App\Classes\Repositories\ArticleCategoryRepository;

/**
 * Class Controller.
 */
class BackendController extends PluginEngine
{
    /**
     * @var ArticleRepository
     */
    private $articles;

    /**
     * @var ArticleCategoryRepository
     */
    private $categories;

    /**
     * BackendController constructor.
     *
     * @param ArticleRepository $repository
     */
    public function __construct(ArticleRepository $repository, ArticleCategoryRepository $categories)
    {
        $this->articles = $repository;

        $this->categories = $categories;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Contracts\View\View|\Illuminate\Http\Response
     */
    public function index()
    {
        return $this->make('index')->with('articles', $this->articles->all());
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Contracts\View\View|\Illuminate\Http\Response
     */
    public function create()
    {
        return $this->form(new Article);
    }

    /**
     * Generate a form for editing or creating a model.
     *
     * @param Article $article model to be used.
     * @return void

Should the return type not be \Illuminate\Contracts\View\View?

     */
    public function form(Article $article)
    {
        return $this->make('form')->with('categories', $this->categories->all())->with('article', $article);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param Article $article
     * @param  \Illuminate\Http\Request $request
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\RedirectResponse?

     */
    public function store(Article $article, Request $request)

This method seems to be duplicated in your project.

    {
        // use the global save function.
        $this->save($request, $article);

        account()->record(Activity::$created, $article);

The method record does only exist in App\Model\Account, but not in Illuminate\Contracts\Auth\Authenticatable.

        // redirect back to articles index.
        return redirect()->route('admin.articles.index');
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\Response|null?

     */
    public function show($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param $slug
     * @return \Illuminate\Contracts\View\View
     */
    public function edit($slug)
    {
        return $this->form($this->articles->whereSlug($slug));

The method App\Classes\Repositories\BaseRepository::whereSlug() has been deprecated with message: change to the repository class calling it.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request $request
     * @param $slug
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\RedirectResponse?

     * @internal param int $id
     */
    public function update(Request $request, $slug)

This method seems to be duplicated in your project.

    {
        $article = $this->articles->whereSlug($slug);

The method App\Classes\Repositories\BaseRepository::whereSlug() has been deprecated with message: change to the repository class calling it.

        $this->save($request, $article);

        account()->record(Activity::$updated, $article);

The method record does only exist in App\Model\Account, but not in Illuminate\Contracts\Auth\Authenticatable.

        return redirect()->route('admin.articles.index');
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id

There is no parameter named $id. Was it maybe removed?

     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\RedirectResponse?

     */
    public function destroy($slug)

This method seems to be duplicated in your project.

    {
        $article = $this->articles->whereSlug($slug);

The method App\Classes\Repositories\BaseRepository::whereSlug() has been deprecated with message: change to the repository class calling it.

        $article->delete();

        account()->record(Activity::$deleted, $article);

The method record does only exist in App\Model\Account, but not in Illuminate\Contracts\Auth\Authenticatable.

        return redirect()->route('admin.articles.index');
    }

    /**
     * Category Index.
     * @param ArticleCategoryRepository $categoryRepository
     * @return \Illuminate\Contracts\View\View
     */
    public function categories(ArticleCategoryRepository $categoryRepository)
    {
        return $this->make('categories')->with('categories', $categoryRepository->all());
    }

    /**
     * @param Request $request
     * @return \Illuminate\Http\RedirectResponse
     */
    public function categories_store(Request $request)

This method seems to be duplicated in your project.

This method is not in camel caps format.

    {
        $this->validate($request, ['unique:title']);

        $category = new ArticleCategory;
        $category->title = $request['name'];
        $category->auditSave();

        account()->record(Activity::$created, $category);

The method record does only exist in App\Model\Account, but not in Illuminate\Contracts\Auth\Authenticatable.

        return redirect()->route('admin.articles.categories.index');
    }

    /**
     * @param int $id
     * @param ArticleCategoryRepository $categoryRepository
     * @return \Illuminate\Http\RedirectResponse
     */
    public function categories_destroy(int $id, ArticleCategoryRepository $categoryRepository)

This method is not in camel caps format.

    {
        $category = $categoryRepository->whereID($id);

        account()->record(Activity::$deleted, $category);

The method record does only exist in App\Model\Account, but not in Illuminate\Contracts\Auth\Authenticatable.

        $category->delete();

        return redirect()->route('admin.articles.categories.index');
    }

    /**
     * Save the data for the menu to the database.
     *
     * @param Request $request
     * @param Article $article
     * @return bool
     * @internal param Article $menu
     */
    public function save(Request $request, Article $article)
    {
        $this->validate($request, [
            'title' => ['min:3|max:255', Rule::unique('articles')->ignore($article->id)], 'content' => ['min:3'],
            'publish_date' => 'required|date',
        ]);

        if ($request['unpublish_date']) {
            $this->validate($request, ['unpublish_date' => 'sometimes|date|after:publish_date']);
        }

        // set attribute for the model.
        $article->setAttribute('title', $request['title']);
        $article->setAttribute('content', $request['content']);
        $article->setAttribute('category_id', $request['category']);
        $article->setAttribute('status', $request['status']);
        $article->setAttribute('featured_img', $request['image']);

        // 09/05/2018 $publish_date =

40% of this comment could be valid code. Did you maybe forget this after debugging?

        $publish_date   = $request['publish_date']   ? Carbon::createFromFormat('m/d/Y', $request['publish_date']) : null;

This line exceeds maximum limit of 120 characters; contains 122 characters

        $unpublish_date = $request['unpublish_date'] ? Carbon::createFromFormat('m/d/Y', $request['unpublish_date']) : null;

This line exceeds maximum limit of 120 characters; contains 124 characters

        // Store the carbon dates to the database.
        $article->setAttribute('publish_date', $publish_date);
        $article->setAttribute('unpublish_date', $unpublish_date);

        // save the article as an audit.
        return $article->auditSave();
    }
}