MarchUpdateOne::up() - Code Metrics - Inspection of "Apply fixes from StyleCI (#168)" - webshelf/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (114f68)

by Mark

created 2018-05-14 00:45 UTC

MarchUpdateOne::up() A

↳ Parent: MarchUpdateOne

Complexity

Conditions	1
Paths	1

Size

Total Lines	51
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	38
nc	1
nop	0
dl	0
loc	51
rs	9.4109
c	1
b	0
f	0

How to fix Long Method

<?php

use App\Model\Page;
use Illuminate\Support\Facades\Schema;
use Illuminate\Database\Schema\Blueprint;
use App\Plugins\Newsletters\Model\Newsletter;
use Illuminate\Database\Migrations\Migration;

class MarchUpdateOne extends Migration
namespace YourVendor;

class YourClass { }
{
    /**
     * Run the migrations.
     *
     * @return void
     */
    public function up()
    {
        $plugin = new \App\Model\Plugin();

        $plugin->setAttribute('name', 'newsletters');
        $plugin->setAttribute('enabled', false);
        $plugin->setAttribute('is_frontend', true);
        $plugin->setAttribute('is_backend', true);
        $plugin->setAttribute('required', false);
        $plugin->save();

        Schema::create('newsletters', function (Blueprint $table) {
            $table->increments('id');
            $table->string('title');
            $table->string('content');
            $table->integer('emailCount');
            $table->boolean('deliveryStatus');
            $table->integer('editor_id');
            $table->integer('creator_id');
            $table->timestamps();
        });

        Schema::create('newsletter_users', function (Blueprint $table) {
            $table->increments('id');
            $table->string('email', 191)->unique();
            $table->timestamps();
        });

        Schema::create('newsletter_templates', function (Blueprint $table) {
            $table->increments('id');
            $table->integer('editor_id');
            $table->integer('creator_id');
            $table->softDeletes();
            $table->timestamps();
        });

        Schema::table('pages', function (Blueprint $table) {
            $table->string('identifier')->nullable()->after('id')->index();
            $table->boolean('special')->default(0)->after('editable');
        });

        /** @var Page $page */
        $page = app(Page::class);
        $page->setAttribute('identifier', Newsletter::VIEW_NEWSLETTER_SUCCESS);
        $page->setAttribute('title', 'Thank You Newsletter');
        $page->setAttribute('content', '<h1>Newsletter Signup Complete</h1> <p>Thank you for subscribing to our newsletter.</p>');
        $page->setAttribute('editable', true);
        $page->setAttribute('special', true);
        $page->setAttribute('sitemap', false);
        $page->setAttribute('enabled', true);
        $page->save();
    }

    /**
     * Reverse the migrations.
     *
     * @return void
     */
    public function down()
    {
        //
    }
}


1			<?php
2
3			use App\Model\Page;
4			use Illuminate\Support\Facades\Schema;
5			use Illuminate\Database\Schema\Blueprint;
6			use App\Plugins\Newsletters\Model\Newsletter;
7			use Illuminate\Database\Migrations\Migration;
8
9			class MarchUpdateOne extends Migration
			0 ignored issues – show Coding Style Compatibility introduced 2018-05-14 00:54 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
10			{
11			/**
12			* Run the migrations.
13			*
14			* @return void
15			*/
16			public function up()
17			{
18			$plugin = new \App\Model\Plugin();
19
20			$plugin->setAttribute('name', 'newsletters');
21			$plugin->setAttribute('enabled', false);
22			$plugin->setAttribute('is_frontend', true);
23			$plugin->setAttribute('is_backend', true);
24			$plugin->setAttribute('required', false);
25			$plugin->save();
26
27			Schema::create('newsletters', function (Blueprint $table) {
28			$table->increments('id');
29			$table->string('title');
30			$table->string('content');
31			$table->integer('emailCount');
32			$table->boolean('deliveryStatus');
33			$table->integer('editor_id');
34			$table->integer('creator_id');
35			$table->timestamps();
36			});
37
38			Schema::create('newsletter_users', function (Blueprint $table) {
39			$table->increments('id');
40			$table->string('email', 191)->unique();
41			$table->timestamps();
42			});
43
44			Schema::create('newsletter_templates', function (Blueprint $table) {
45			$table->increments('id');
46			$table->integer('editor_id');
47			$table->integer('creator_id');
48			$table->softDeletes();
49			$table->timestamps();
50			});
51
52			Schema::table('pages', function (Blueprint $table) {
53			$table->string('identifier')->nullable()->after('id')->index();
54			$table->boolean('special')->default(0)->after('editable');
55			});
56
57			/** @var Page $page */
58			$page = app(Page::class);
59			$page->setAttribute('identifier', Newsletter::VIEW_NEWSLETTER_SUCCESS);
60			$page->setAttribute('title', 'Thank You Newsletter');
61			$page->setAttribute('content', '<h1>Newsletter Signup Complete</h1> <p>Thank you for subscribing to our newsletter.</p>');
62			$page->setAttribute('editable', true);
63			$page->setAttribute('special', true);
64			$page->setAttribute('sitemap', false);
65			$page->setAttribute('enabled', true);
66			$page->save();
67			}
68
69			/**
70			* Reverse the migrations.
71			*
72			* @return void
73			*/
74			public function down()
75			{
76			//
77			}
78			}
79

webshelf / framework

Scrutinizer GitHub App not installed

Branch — master (114f68)

MarchUpdateOne::up() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like