webshelf /
framework
We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 70 |
| Code Lines | 53 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 14 | public function up() |
||
| 15 | { |
||
| 16 | \Schema::create('settings', function (Blueprint $table) { |
||
| 17 | $table->increments('id'); |
||
| 18 | $table->string('key'); |
||
| 19 | $table->string('value')->nullable(); |
||
| 20 | $table->string('default')->nullable(); |
||
| 21 | $table->timestamps(); |
||
| 22 | }); |
||
| 23 | |||
| 24 | $setting = new Setting; |
||
| 25 | $setting->setKey('website_name'); |
||
| 26 | $setting->setShadow('Business Name CMS'); |
||
| 27 | $setting->save(); |
||
| 28 | |||
| 29 | $setting = new Setting; |
||
| 30 | $setting->setKey('website_copyright'); |
||
| 31 | $setting->save(); |
||
| 32 | |||
| 33 | $setting = new Setting; |
||
| 34 | $setting->setKey('seo_indexing'); |
||
| 35 | $setting->setShadow(false); |
||
| 36 | $setting->save(); |
||
| 37 | |||
| 38 | $setting = new Setting; |
||
| 39 | $setting->setKey('seo_text'); |
||
| 40 | $setting->save(); |
||
| 41 | |||
| 42 | $setting = new Setting; |
||
| 43 | $setting->setKey('seo_position'); |
||
| 44 | $setting->setShadow('left'); |
||
| 45 | $setting->save(); |
||
| 46 | |||
| 47 | $setting = new Setting; |
||
| 48 | $setting->setKey('seo_separator'); |
||
| 49 | $setting->setShadow('|'); |
||
| 50 | $setting->save(); |
||
| 51 | |||
| 52 | $setting = new Setting; |
||
| 53 | $setting->setKey('page_keywords'); |
||
| 54 | $setting->save(); |
||
| 55 | |||
| 56 | $setting = new Setting; |
||
| 57 | $setting->setKey('page_description'); |
||
| 58 | $setting->save(); |
||
| 59 | |||
| 60 | $setting = new Setting; |
||
| 61 | $setting->setKey('maintenance_mode'); |
||
| 62 | $setting->setShadow(true); |
||
| 63 | $setting->save(); |
||
| 64 | |||
| 65 | $setting = new Setting; |
||
| 66 | $setting->setKey('address'); |
||
| 67 | $setting->save(); |
||
| 68 | |||
| 69 | $setting = new Setting; |
||
| 70 | $setting->setKey('phone_number'); |
||
| 71 | $setting->save(); |
||
| 72 | |||
| 73 | $setting = new Setting; |
||
| 74 | $setting->setKey('fax_number'); |
||
| 75 | $setting->save(); |
||
| 76 | |||
| 77 | $setting = new Setting; |
||
| 78 | $setting->setKey('email_address'); |
||
| 79 | $setting->save(); |
||
| 80 | |||
| 81 | $setting = new Setting; |
||
| 82 | $setting->setKey('facebook_id'); |
||
| 83 | $setting->save(); |
||
| 84 | } |
||
| 96 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.