App\Http\Controllers\PageController::load()

Complexity

Conditions	2
Paths	2

Size

Total Lines	22
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	PageController::trackEvents()	0	8	1

<?php
/**
 * Created by PhpStorm.
 * User: Mark
 * Date: 05/04/2016
 * Time: 14:13.
 *
 * Updated: 20/06/2016 00:56
 */

namespace App\Http\Controllers;

use App\Model\Page;
use App\Events\PageWasVisited;
use App\Events\WebsiteWasVisited;
use App\Classes\Repositories\MenuRepository;
use App\Classes\Repositories\PageRepository;
use App\Classes\Library\PageLoader\Frontpage;

/**
 * Class PageController.
 *
 * The class handles the page that will be sent back to the user.
 *
 * The FrontPageLoader class does all the work though.
 *
 * Errors are now handled in the ErrorController class.
 */
class PageController extends Controller
{
    /**
     * @var Page
     */
    private $currentPage;

    /**
     * PageController constructor.
     * @param PageRepository $pages
     */
    public function __construct(PageRepository $pages)
    {
        $this->currentPage = $pages->whereName(currentURI());

It seems like $pages->whereName(currentURI()) can also be of type array or object<stdClass>. However, the property $currentPage is declared as type object<App\Model\Page>. Maybe add an additional type check?

    }

    /**
     * Redirects must use a controller to handle the parameter, as they require a specified target.
     * @return mixed

Consider making the return type a bit more specific; maybe use \Illuminate\Http\RedirectResponse.

     */
    public function redirect()
    {
        return redirect($this->currentPage->redirect->to(), 302);
    }

    /**
     * Standard page views are once that use the URL as the designated target.
     *
     * @return mixed

Consider making the return type a bit more specific; maybe use \Illuminate\Http\Response.

     * @throws \Exception
     * @internal param FrontPageLoader $pageLoader
     */
    public function index()
    {
        return (new Frontpage($this->currentPage, $this->navigationData()))->publish();
    }

    /**
     * @return mixed
     */
    private function navigationData()
    {
        return app(MenuRepository::class)->allParentsWithChildren();
    }

    /**
     * @param Page $page
     * @return bool
     */
    private function trackEvents(Page $page)
    {
        event(new PageWasVisited($page));

        event(new WebsiteWasVisited(request()));

        return true;
    }
}