Frontpage::build() - Code Metrics - Inspection of "Merge remote-tracking branch 'Laravel/master' into..." - webshelf/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5c7169...b34131 )

by Mark

created 2018-01-05 17:22 UTC

Frontpage::build() A

↳ Parent: Frontpage

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	4
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: Marky
 * Date: 31/12/2017
 * Time: 00:12.
 */

namespace App\Classes\Library\PageLoader;

use App\Model\Page;
use App\Model\Role;
use Illuminate\Http\Response;
use Illuminate\Support\Collection;
use App\Http\Controllers\ErrorController;
use App\Classes\Repositories\MenuRepository;
use Illuminate\Contracts\Routing\ResponseFactory;

class Frontpage
{
    /**
     * @var Response
     */
    private $response;

    /**
     * @var Webpage
     */
    public $webpage;

    /**
     * @var Page
     */
    private $model;

    /**
     * Frontpage constructor.
     * @param Page $model
     * @param Collection $navigationRepository
     */
    public function __construct(Page $model, Collection $navigationRepository)
    {
        $this->response = app(ResponseFactory::class);

        $this->webpage = new Webpage($this->model = $model, $navigationRepository);
    }

    /**
     * @param string|null $template
     * @param bool $override
     * @param int $status
     * @return Response
     */
    public function publish(string $template = null, bool $override = true, int $status = 200, bool $errorResponse = false)

    {
        if (!$errorResponse)
        {
            if ($this->isMaintenanceMode()) {
                return ErrorController::maintenance();
            }

            if ($this->isDisabledPage($this->model)) {
                return ErrorController::disabled();
            }
        }

        return $this->response->view($this->makeBlade($template, $override), ['webpage' => $this->webpage], $status);
    }

    /**
     * A user can disable a webpage from being viewed.
     *
     * @param Page $page
     * @return bool
     */
    private function isDisabledPage(Page $page)
    {
        return $page->enabled == false;

    }

    /**
     * Check if the website is in maintenance mode
     * which is set by the user on the dashboard.
     *
     * @return bool
     */
    public function isMaintenanceMode()
    {
        return settings()->getValue('maintenance_mode');
    }

    /**
     * Check if the current logged in user if exists,
     * can bypass the maintenance and view it offline.
     *
     * @return bool
     */
    public function canBypassMaintenance()
    {
        return auth()->check() == true && account()->hasRole(Role::ADMINISTRATOR);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @param string|null $template
     * @param bool $override
     * @return string
     */
    private function makeBlade(string $template = null, bool $override = true)
    {
        if ($template == null) {

            return currentURI() == 'index' ? 'website::index' : 'website::page';
        }

        if ($override && view()->exists("website::plugins.{$this->model->slug}")) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            $template = "website::plugins.{$this->model->slug}";
        }

        return $template;
    }

    /**
     * @param string $title
     * @param string $description
     * @param string $template
     * @param int $response
     * @return Response
     */
    public static function build(string $title, string $description, string $template, int $response)
    {
        $page = new Page(['seo_title' => $title, 'seo_description' => $description]);

        $navigation = app(MenuRepository::class)->allParentsWithChildren();

        return (new self($page, $navigation))->publish("errors::{$template}", false, $response, true);
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: Marky
5			* Date: 31/12/2017
6			* Time: 00:12.
7			*/
8
9			namespace App\Classes\Library\PageLoader;
10
11			use App\Model\Page;
12			use App\Model\Role;
13			use Illuminate\Http\Response;
14			use Illuminate\Support\Collection;
15			use App\Http\Controllers\ErrorController;
16			use App\Classes\Repositories\MenuRepository;
17			use Illuminate\Contracts\Routing\ResponseFactory;
18
19			class Frontpage
20			{
21			/**
22			* @var Response
23			*/
24			private $response;
25
26			/**
27			* @var Webpage
28			*/
29			public $webpage;
30
31			/**
32			* @var Page
33			*/
34			private $model;
35
36			/**
37			* Frontpage constructor.
38			* @param Page $model
39			* @param Collection $navigationRepository
40			*/
41			public function __construct(Page $model, Collection $navigationRepository)
42			{
43			$this->response = app(ResponseFactory::class);
44
45			$this->webpage = new Webpage($this->model = $model, $navigationRepository);
46			}
47
48			/**
49			* @param string\|null $template
50			* @param bool $override
51			* @param int $status
52			* @return Response
53			*/
54			public function publish(string $template = null, bool $override = true, int $status = 200, bool $errorResponse = false)
			0 ignored issues – show Coding Style introduced 2018-01-05 17:28 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 123 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
55			{
56			if (!$errorResponse)
57			{
58			if ($this->isMaintenanceMode()) {
59			return ErrorController::maintenance();
60			}
61
62			if ($this->isDisabledPage($this->model)) {
63			return ErrorController::disabled();
64			}
65			}
66
67			return $this->response->view($this->makeBlade($template, $override), ['webpage' => $this->webpage], $status);
68			}
69
70			/**
71			* A user can disable a webpage from being viewed.
72			*
73			* @param Page $page
74			* @return bool
75			*/
76			private function isDisabledPage(Page $page)
77			{
78			return $page->enabled == false;
			0 ignored issues – show Coding Style Best Practice introduced 2018-01-05 17:28 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
79			}
80
81			/**
82			* Check if the website is in maintenance mode
83			* which is set by the user on the dashboard.
84			*
85			* @return bool
86			*/
87			public function isMaintenanceMode()
88			{
89			return settings()->getValue('maintenance_mode');
90			}
91
92			/**
93			* Check if the current logged in user if exists,
94			* can bypass the maintenance and view it offline.
95			*
96			* @return bool
97			*/
98			public function canBypassMaintenance()
99			{
100			return auth()->check() == true && account()->hasRole(Role::ADMINISTRATOR);
			0 ignored issues – show Bug introduced 2018-01-05 17:28 UTC by Report Bug Copy Issue Report The method `check` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... / } Loading history... Bug introduced 2018-01-05 17:28 UTC by Report Bug Copy Issue Report The method `hasRole` does only exist in `App\Model\Account`, but not in `Illuminate\Contracts\Auth\Authenticatable`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /* * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
101			}
102
103			/**
104			* @param string\|null $template
105			* @param bool $override
106			* @return string
107			*/
108			private function makeBlade(string $template = null, bool $override = true)
109			{
110			if ($template == null) {
			0 ignored issues – show Bug introduced 2018-01-05 17:28 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$template` of type `null\|string` against `null`; this is ambiguous if the string can be empty. Consider using a strict comparison `===` instead. Loading history...
111			return currentURI() == 'index' ? 'website::index' : 'website::page';
112			}
113
114			if ($override && view()->exists("website::plugins.{$this->model->slug}")) {
			0 ignored issues – show Bug introduced 2018-01-05 17:28 UTC by Report Bug Copy Issue Report The method `exists` does only exist in `Illuminate\Contracts\View\Factory`, but not in `Illuminate\View\View`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
115			$template = "website::plugins.{$this->model->slug}";
116			}
117
118			return $template;
119			}
120
121			/**
122			* @param string $title
123			* @param string $description
124			* @param string $template
125			* @param int $response
126			* @return Response
127			*/
128			public static function build(string $title, string $description, string $template, int $response)
129			{
130			$page = new Page(['seo_title' => $title, 'seo_description' => $description]);
131
132			$navigation = app(MenuRepository::class)->allParentsWithChildren();
133
134			return (new self($page, $navigation))->publish("errors::{$template}", false, $response, true);
135			}
136			}
137

webshelf / framework

Scrutinizer GitHub App not installed

Push — master ( 5c7169...b34131 )

Frontpage::build() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like