Breadcrumbs::contain() - Code Metrics - Inspection of "Merge remote-tracking branch 'Laravel/master' into..." - webshelf/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5c7169...b34131 )

by Mark

created 2018-01-05 17:22 UTC

Breadcrumbs::contain() A

↳ Parent: Breadcrumbs

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	4
nc	2
nop	2
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: Marky
 * Date: 04/01/2018
 * Time: 01:28
 */

namespace App\Classes;

use Illuminate\Http\Request;
use Illuminate\Support\Collection;

/**
 * Class Breadcrumbs
 *
 * @package App\Classes
 */
class Breadcrumbs
{

    /**
     * A collection of crumbs.
     *
     * @var Collection
     */
    protected $collection;

    /**
     * Breadcrumbs constructor.
     * @param Collection $collection
     */
    public function __construct(Collection $collection)
    {
        $this->collection = $collection;
    }

    /**
     * @param string $title
     * @param string $path
     * @return bool
     */
    public function addCrumb(string $title, string $path)
    {
        $crumb = new \stdClass();
        $crumb->title = $this->filter($title);
        $crumb->path = url($path);

        $this->collection->push($crumb);

        return true;
    }

    /**
     * @param string $title
     * @return string
     */
    public function filter(string $title)
    {
        return ucwords(str_replace(['_', '-'], [' ', ' '], $title));
    }

    /**
     * @return Collection
     */
    public function crumbs()
    {
        return $this->collection;
    }

    /**
     * @param string $name
     * @param int $position
     * @return bool
     */
    public function contain(string $name, int $position)
    {
        if ($this->collection->has($position) == false)

            return false;

        return $this->collection->get($position)->title == $this->filter($name);
    }

    /**
     * @param int $integer
     * @return bool
     */
    public function hasCount(int $integer)
    {
        return $this->collection->count() == $integer;
    }

    /**
     * @param int $count
     * @return $this
     */
    public function limit(int $count)
    {
        $collection = new Collection;

        for ($i = 0; $i < $count; $i++)
        {
            if ($this->collection->has($i)) {
                $collection->push($this->collection->get($i));
            }
        }

        $this->collection = $collection;

        return $this;
    }

    /**
     * @return Breadcrumbs
     */
    public static function fromCurrentRoute()
    {
        /** @var Breadcrumbs $instance */
        $instance = app(self::class);

        /** @var array $routes */
        $routes = explode('/', app(Request::class)->getRequestUri());

        $urlPath = url(array_pull($routes, 0));

        // Add the home array.
        $instance->addCrumb('Home', $urlPath);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        foreach ($routes as $route)
        {
            $urlPath = $urlPath . '/' . $route;

            $instance->addCrumb($route, $urlPath);
        }

        return $instance;
    }

}

1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: Marky
5			* Date: 04/01/2018
6			* Time: 01:28
7			*/
8
9			namespace App\Classes;
10
11			use Illuminate\Http\Request;
12			use Illuminate\Support\Collection;
13
14			/**
15			* Class Breadcrumbs
16			*
17			* @package App\Classes
18			*/
19			class Breadcrumbs
20			{
21
22			/**
23			* A collection of crumbs.
24			*
25			* @var Collection
26			*/
27			protected $collection;
28
29			/**
30			* Breadcrumbs constructor.
31			* @param Collection $collection
32			*/
33			public function __construct(Collection $collection)
34			{
35			$this->collection = $collection;
36			}
37
38			/**
39			* @param string $title
40			* @param string $path
41			* @return bool
42			*/
43			public function addCrumb(string $title, string $path)
44			{
45			$crumb = new \stdClass();
46			$crumb->title = $this->filter($title);
47			$crumb->path = url($path);
48
49			$this->collection->push($crumb);
50
51			return true;
52			}
53
54			/**
55			* @param string $title
56			* @return string
57			*/
58			public function filter(string $title)
59			{
60			return ucwords(str_replace(['_', '-'], [' ', ' '], $title));
61			}
62
63			/**
64			* @return Collection
65			*/
66			public function crumbs()
67			{
68			return $this->collection;
69			}
70
71			/**
72			* @param string $name
73			* @param int $position
74			* @return bool
75			*/
76			public function contain(string $name, int $position)
77			{
78			if ($this->collection->has($position) == false)
			0 ignored issues – show Coding Style Best Practice introduced 2018-01-05 17:28 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
79			return false;
80
81			return $this->collection->get($position)->title == $this->filter($name);
82			}
83
84			/**
85			* @param int $integer
86			* @return bool
87			*/
88			public function hasCount(int $integer)
89			{
90			return $this->collection->count() == $integer;
91			}
92
93			/**
94			* @param int $count
95			* @return $this
96			*/
97			public function limit(int $count)
98			{
99			$collection = new Collection;
100
101			for ($i = 0; $i < $count; $i++)
102			{
103			if ($this->collection->has($i)) {
104			$collection->push($this->collection->get($i));
105			}
106			}
107
108			$this->collection = $collection;
109
110			return $this;
111			}
112
113			/**
114			* @return Breadcrumbs
115			*/
116			public static function fromCurrentRoute()
117			{
118			/** @var Breadcrumbs $instance */
119			$instance = app(self::class);
120
121			/** @var array $routes */
122			$routes = explode('/', app(Request::class)->getRequestUri());
123
124			$urlPath = url(array_pull($routes, 0));
125
126			// Add the home array.
127			$instance->addCrumb('Home', $urlPath);
			0 ignored issues – show Bug introduced 2018-01-05 17:28 UTC by Report Bug Copy Issue Report It seems like `$urlPath` defined by `url(array_pull($routes, 0))` on line `124` can also be of type `object<Illuminate\Contracts\Routing\UrlGenerator>`; however, `App\Classes\Breadcrumbs::addCrumb()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
128
129			foreach ($routes as $route)
130			{
131			$urlPath = $urlPath . '/' . $route;
132
133			$instance->addCrumb($route, $urlPath);
134			}
135
136			return $instance;
137			}
138
139			}

webshelf / framework

Scrutinizer GitHub App not installed

Push — master ( 5c7169...b34131 )

Breadcrumbs::contain() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like