App\Plugins\Pages\BackendController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	132
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	4	1
A	create()	0	4	1
A	store()	0	8	1
A	show()	0	4	1
A	edit()	0	4	1
A	update()	0	10	1
A	destroy()	0	10	2
A	save()	0	17	3

<?php
/**
 * Created by PhpStorm.
 * User: Mark
 * Date: 05/03/2016
 * Time: 20:30.
 */

namespace App\Plugins\Pages;

use App\Model\Menu;
use App\Model\Page;
use Illuminate\Http\Request;
use App\Plugins\PluginEngine;
use Illuminate\Support\Facades\DB;
use App\Classes\Repositories\PageRepository;

/**
 * Class Controller.
 */
class BackendController extends PluginEngine
{
    /**
     * @var PageRepository
     */
    private $repository;

    /**
     * AdminController constructor.
     * @param PageRepository $repository
     */
    public function __construct(PageRepository $repository)
    {
        $this->repository = $repository;
    }

    /**
     * Display a listing of the resource.
     */
    public function index()
    {
        return $this->make('index')->with('pages', $this->repository->all());
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Contracts\View\View|\Illuminate\Http\Response
     */
    public function create()
    {
        return $this->make('create');
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request $request
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\RedirectResponse?

     */
    public function store(Request $request)
    {
        $this->validate($request, ['title' => 'required|unique:pages,seo_title,NULL,id,deleted_at,NULL|min:3|max:255']);

        $this->save($request, new Page);

        return redirect()->route('admin.pages.index');
    }

    /**
     * Display the specified resource.
     *
     * @param string $name
     * @return bool
     */
    public function show(string $name)

The parameter $name is not used and could be removed.

    {
        return false;
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param string $name
     * @return \Illuminate\Contracts\View\View|\Illuminate\Http\Response
     */
    public function edit(string $name)
    {
        return $this->make('edit')->with('page', $this->repository->whereName($name));
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request $request
     * @param string $name
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\RedirectResponse?

     */
    public function update(Request $request, string $name)
    {
        $page = $this->repository->whereName($name);

        $this->validate($request, ['title'=>'required|min:3|max:255|unique:pages,seo_title,'.$page->id.',id,deleted_at,NULL']);

This line exceeds maximum limit of 120 characters; contains 127 characters

        $this->save($request, $page);

It seems like $page defined by $this->repository->whereName($name) on line 101 can also be of type array or object<stdClass>; however, App\Plugins\Pages\BackendController::save() does only seem to accept object<App\Model\Page>, maybe add an additional type check?

        return redirect()->route('admin.pages.index');
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param $slug
     * @param PageRepository $repository
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\RedirectResponse?

     * @throws \Exception
     */
    public function destroy($slug, PageRepository $repository)
    {
        $page = $repository->whereName($slug);

        if ($page->editable) {
            $repository->whereName($slug)->delete();

The method delete does only exist in App\Model\Page, but not in stdClass.

        }

        return redirect()->route('admin.pages.index');
    }

    /**
     * Resource data for saving.
     *
     * @param Request $request
     * @param Page $page
     */
    private function save(Request $request, Page $page)
    {
        $page->seo_title = $request['title'];
        $page->creator_id = $request['creator'] ?: account()->id;
        $page->seo_keywords = $request['keywords'];
        $page->seo_description = $request['description'];
        $page->content = $request['content'];
        $page->sitemap = true; //$request['sitemap'] ? true : false;

70% of this comment could be valid code. Did you maybe forget this after debugging?

        $page->enabled = true; //$request['enabled'] ? true : false;

70% of this comment could be valid code. Did you maybe forget this after debugging?

        // we should not allow important slugs to be changed.
        if ($page->editable == true) {
            $page->slug = str_slug($page->seo_title);
        }

        $page->save();
    }
}