ArticleRepository::publicArticles() - Code Metrics - Inspection of "Cleaned up max 140 chars per line." - webshelf/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4f93b1...14a25e )

by Mark

created 2018-05-13 23:34 UTC

ArticleRepository::publicArticles() A

↳ Parent: ArticleRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	9
nc	1
nop	0
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: Marky
 * Date: 16/02/2018
 * Time: 16:00.
 */

namespace App\Classes\Repositories;

use App\Model\Menu;
use App\Model\Article;
use Illuminate\Support\Collection;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Support\Facades\DB;

/**
 * Class ArticleRepository.
 */
class ArticleRepository extends BaseRepository
{
    /**
     * @var Article|Builder|Collection
     */
    protected $model;

    /**
     * PageRepository constructor.
     *
     * @param Article|Menu $model

     */
    public function __construct(Article $model)
    {
        $this->model = $model;
    }

    /**
     * Load all the articles that will be displayed dont he front page based on the criteria of being an public post.
     *
     * @ver 5.2.0
     * @date 14/05/2018
     * @return Builder|Collection
     */
    private function publicArticles()
    {
        return $this->model->where([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ['status', Article::STATUS_PUBLIC],
            ['publish_date', '<=', DB::raw('NOW()')],
            ['unpublish_date', '>=', DB::raw('NOW()')]
        ])->orWhere([
            ['status', Article::STATUS_PUBLIC],
            ['publish_date', '<=', DB::raw('NOW()')],
            ['unpublish_date', '=', null]]
        );
    }

    public function whereSitemappable()

    {
        return $this->model->where(['sitemap' => true, 'status' => true])->get();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @ver 5.0.2
     * @date 08/03/2018
     * @param int $count
     * @return \Illuminate\Database\Eloquent\Collection|Collection|static[]
     */
    public function latest($count = 7)
    {
        return $this->publicArticles()->take($count)->orderBy('created_at', 'desc')->get();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @ver 5.0.2
     * @date 08/03/2018
     * @param int $count
     * @return \Illuminate\Database\Eloquent\Collection|Collection|static[]
     */
    public function mostViewed($count = 7)
    {
        return $this->publicArticles()->orderBy('views', 'desc')->take($count)->get();
    }

    /**
     * @ver 5.1.13
     * @date 19/03/2018
     * @return mixed
     */
    public function uniqueCreators()
    {
        return $this->model->all()->unique('creator_id');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @ver 5.1.14
     * @date 19/03/2018
     * @return mixed
     */
    public function viewable()
    {
        return $this->model->where('status', Article::STATUS_PUBLIC)->get();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @param int $count
     * @return \Illuminate\Contracts\Pagination\Paginator
     */
    public function paginateLatest(int $count)
    {
        return $this->publicArticles()->orderBy('created_at', 'desc')->simplePaginate($count);
    }

    /**
     * @ver 5.1.13
     * @date 19/03/2018
     * @return mixed
     */
    public function activeCategories()
    {
        return app(ArticleCategoryRepository::class)->whereStatusActive();
    }

    /**
     * @ver 5.1.15
     * @date 19/03/2018
     * @param int $creator_id
     * @return int
     */
    public function publishedArticlesCount(int $creator_id)

    {
        return $this->publicArticles()->where('creator_id', $creator_id)->count();
    }

    /**
     * @return \Illuminate\Database\Eloquent\Collection|mixed|static[]
     */
    public function whereStatusActive()
    {
        return $this->model->where('status', true)->get();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function collectArticle(string $slug)

    {
        return $this->publicArticles()->where('slug', $slug)->orderBy('created_at', 'desc')->first();
    }

    /**
     * @param string $text
     * @param int $paginate
     * @return \Illuminate\Contracts\Pagination\LengthAwarePaginator
     */
    public function searchThenPaginate(string $text, int $paginate = 7)
    {
        return $this->publicArticles()->search($text)->orderBy('created_at', 'desc')->paginate($paginate);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function whereCreatorId(int $creator_id, int $paginate = 5)

    {
        return $this->publicArticles()
            ->orderBy('created_at', 'desc')
            ->where('creator_id', $creator_id)
            ->simplePaginate($paginate);
    }

    public function whereCategoryId(int $id, int $paginate = 5)

    {
        return $this->publicArticles()
            ->where('category_id', $id)
            ->orderBy('created_at', 'desc')
            ->simplePaginate($paginate);
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: Marky
5			* Date: 16/02/2018
6			* Time: 16:00.
7			*/
8
9			namespace App\Classes\Repositories;
10
11			use App\Model\Menu;
12			use App\Model\Article;
13			use Illuminate\Support\Collection;
14			use Illuminate\Database\Eloquent\Builder;
15			use Illuminate\Support\Facades\DB;
16
17			/**
18			* Class ArticleRepository.
19			*/
20			class ArticleRepository extends BaseRepository
21			{
22			/**
23			* @var Article\|Builder\|Collection
24			*/
25			protected $model;
26
27			/**
28			* PageRepository constructor.
29			*
30			* @param Article\|Menu $model
			0 ignored issues – show Documentation introduced 2018-03-24 15:56 UTC by Report Bug Copy Issue Report Consider making the type for parameter `$model` a bit more specific; maybe use `Article`. Loading history...
31			*/
32			public function __construct(Article $model)
33			{
34			$this->model = $model;
35			}
36
37			/**
38			* Load all the articles that will be displayed dont he front page based on the criteria of being an public post.
39			*
40			* @ver 5.2.0
41			* @date 14/05/2018
42			* @return Builder\|Collection
43			*/
44			private function publicArticles()
45			{
46			return $this->model->where([
			0 ignored issues – show Bug introduced 2018-05-13 23:37 UTC by Report Bug Copy Issue Report The method `where` does only exist in `Illuminate\Database\Eloq...nate\Support\Collection`, but not in `App\Model\Article`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
47			['status', Article::STATUS_PUBLIC],
48			['publish_date', '<=', DB::raw('NOW()')],
49			['unpublish_date', '>=', DB::raw('NOW()')]
50			])->orWhere([
51			['status', Article::STATUS_PUBLIC],
52			['publish_date', '<=', DB::raw('NOW()')],
53			['unpublish_date', '=', null]]
54			);
55			}
56
57			public function whereSitemappable()
			0 ignored issues – show Documentation introduced 2018-03-24 15:56 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
58			{
59			return $this->model->where(['sitemap' => true, 'status' => true])->get();
			0 ignored issues – show Bug introduced 2018-03-24 15:56 UTC by Report Bug Copy Issue Report The method `where` does only exist in `Illuminate\Database\Eloq...nate\Support\Collection`, but not in `App\Model\Article`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
60			}
61
62			/**
63			* @ver 5.0.2
64			* @date 08/03/2018
65			* @param int $count
66			* @return \Illuminate\Database\Eloquent\Collection\|Collection\|static[]
67			*/
68			public function latest($count = 7)
69			{
70			return $this->publicArticles()->take($count)->orderBy('created_at', 'desc')->get();
			0 ignored issues – show Bug introduced 2018-05-13 23:37 UTC by Report Bug Copy Issue Report The method `take` does only exist in `Illuminate\Support\Collection`, but not in `Illuminate\Database\Eloquent\Builder`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
71			}
72
73			/**
74			* @ver 5.0.2
75			* @date 08/03/2018
76			* @param int $count
77			* @return \Illuminate\Database\Eloquent\Collection\|Collection\|static[]
78			*/
79			public function mostViewed($count = 7)
80			{
81			return $this->publicArticles()->orderBy('views', 'desc')->take($count)->get();
82			}
83
84			/**
85			* @ver 5.1.13
86			* @date 19/03/2018
87			* @return mixed
88			*/
89			public function uniqueCreators()
90			{
91			return $this->model->all()->unique('creator_id');
			0 ignored issues – show Bug introduced 2018-03-24 15:56 UTC by Report Bug Copy Issue Report The method `all` does only exist in `App\Model\Article and Il...nate\Support\Collection`, but not in `Illuminate\Database\Eloquent\Builder`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
92			}
93
94			/**
95			* @ver 5.1.14
96			* @date 19/03/2018
97			* @return mixed
98			*/
99			public function viewable()
100			{
101			return $this->model->where('status', Article::STATUS_PUBLIC)->get();
			0 ignored issues – show Bug introduced 2018-03-24 15:56 UTC by Report Bug Copy Issue Report The method `where` does only exist in `Illuminate\Database\Eloq...nate\Support\Collection`, but not in `App\Model\Article`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
102			}
103
104			/**
105			* @param int $count
106			* @return \Illuminate\Contracts\Pagination\Paginator
107			*/
108			public function paginateLatest(int $count)
109			{
110			return $this->publicArticles()->orderBy('created_at', 'desc')->simplePaginate($count);
111			}
112
113			/**
114			* @ver 5.1.13
115			* @date 19/03/2018
116			* @return mixed
117			*/
118			public function activeCategories()
119			{
120			return app(ArticleCategoryRepository::class)->whereStatusActive();
121			}
122
123			/**
124			* @ver 5.1.15
125			* @date 19/03/2018
126			* @param int $creator_id
127			* @return int
128			*/
129			public function publishedArticlesCount(int $creator_id)
			0 ignored issues – show Coding Style Naming introduced 2018-03-24 15:56 UTC by Report Bug Copy Issue Report The parameter $creator_id is not named in camelCase. This check marks parameter names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
130			{
131			return $this->publicArticles()->where('creator_id', $creator_id)->count();
132			}
133
134			/**
135			* @return \Illuminate\Database\Eloquent\Collection\|mixed\|static[]
136			*/
137			public function whereStatusActive()
138			{
139			return $this->model->where('status', true)->get();
			0 ignored issues – show Bug introduced 2018-03-24 15:56 UTC by Report Bug Copy Issue Report The method `where` does only exist in `Illuminate\Database\Eloq...nate\Support\Collection`, but not in `App\Model\Article`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
140			}
141
142			public function collectArticle(string $slug)
			0 ignored issues – show Documentation introduced 2018-03-24 15:56 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
143			{
144			return $this->publicArticles()->where('slug', $slug)->orderBy('created_at', 'desc')->first();
145			}
146
147			/**
148			* @param string $text
149			* @param int $paginate
150			* @return \Illuminate\Contracts\Pagination\LengthAwarePaginator
151			*/
152			public function searchThenPaginate(string $text, int $paginate = 7)
153			{
154			return $this->publicArticles()->search($text)->orderBy('created_at', 'desc')->paginate($paginate);
			0 ignored issues – show Bug introduced 2018-05-13 23:37 UTC by Report Bug Copy Issue Report The method `search` does only exist in `Illuminate\Support\Collection`, but not in `Illuminate\Database\Eloquent\Builder`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
155			}
156
157			public function whereCreatorId(int $creator_id, int $paginate = 5)
			0 ignored issues – show Documentation introduced 2018-03-24 15:56 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history... Coding Style Naming introduced 2018-03-24 15:56 UTC by Report Bug Copy Issue Report The parameter $creator_id is not named in camelCase. This check marks parameter names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
158			{
159			return $this->publicArticles()
160			->orderBy('created_at', 'desc')
161			->where('creator_id', $creator_id)
162			->simplePaginate($paginate);
163			}
164
165			public function whereCategoryId(int $id, int $paginate = 5)
			0 ignored issues – show Documentation introduced 2018-03-24 15:56 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
166			{
167			return $this->publicArticles()
168			->where('category_id', $id)
169			->orderBy('created_at', 'desc')
170			->simplePaginate($paginate);
171			}
172			}
173

webshelf / framework

Scrutinizer GitHub App not installed

Push — master ( 4f93b1...14a25e )

ArticleRepository::publicArticles() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like