WebsiteWasVisited::__construct() - Code Metrics - Inspection of "Store and log users who access website, added char..." - webshelf/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 878613...5184b8 )

by Mark

created 2017-09-06 13:19 UTC

WebsiteWasVisited::__construct() A

↳ Parent: WebsiteWasVisited

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace App\Events;

use Illuminate\Broadcasting\Channel;
use Illuminate\Http\Request;
use Illuminate\Queue\SerializesModels;
use Illuminate\Broadcasting\PrivateChannel;
use Illuminate\Broadcasting\PresenceChannel;
use Illuminate\Foundation\Events\Dispatchable;
use Illuminate\Broadcasting\InteractsWithSockets;
use Illuminate\Contracts\Broadcasting\ShouldBroadcast;

class WebsiteWasVisited
{
    use Dispatchable, InteractsWithSockets, SerializesModels;

    /**
     * @var Request
     */
    public $request;

    /**
     * Create a new event instance.
     *
     * @param Request $request
     */
    public function __construct(Request $request)

    {
        $this->request = $request;
    }

    /**
     * Get the channels the event should broadcast on.
     *
     * @return \Illuminate\Broadcasting\Channel|array
     */
    public function broadcastOn()
    {
        return new PrivateChannel('channel-name');
    }
}


1			<?php
2
3			namespace App\Events;
4
5			use Illuminate\Broadcasting\Channel;
6			use Illuminate\Http\Request;
7			use Illuminate\Queue\SerializesModels;
8			use Illuminate\Broadcasting\PrivateChannel;
9			use Illuminate\Broadcasting\PresenceChannel;
10			use Illuminate\Foundation\Events\Dispatchable;
11			use Illuminate\Broadcasting\InteractsWithSockets;
12			use Illuminate\Contracts\Broadcasting\ShouldBroadcast;
13
14			class WebsiteWasVisited
15			{
16			use Dispatchable, InteractsWithSockets, SerializesModels;
17
18			/**
19			* @var Request
20			*/
21			public $request;
22
23			/**
24			* Create a new event instance.
25			*
26			* @param Request $request
27			*/
28			public function __construct(Request $request)
			0 ignored issues – show Bug introduced 2017-09-06 13:22 UTC by Report Bug Copy Issue Report You have injected the Request via parameter `$request`. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via `getCurrentRequest()`. Loading history...
29			{
30			$this->request = $request;
31			}
32
33			/**
34			* Get the channels the event should broadcast on.
35			*
36			* @return \Illuminate\Broadcasting\Channel\|array
37			*/
38			public function broadcastOn()
39			{
40			return new PrivateChannel('channel-name');
41			}
42			}
43

webshelf / framework

Scrutinizer GitHub App not installed

Push — master ( 878613...5184b8 )

WebsiteWasVisited::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like