App\Plugins\Menus\BackendController

Complexity

Total Complexity

15

Size/Duplication

Total Lines	205
Duplicated Lines	0 %

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	edit()	0	3	1
A	store()	0	9	1
A	reorder()	0	11	2
B	save()	0	37	3
A	show()	0	2	1
A	destroy()	0	17	3
A	update()	0	11	1
A	index()	0	3	1
A	create()	0	3	1

<?php
/**
 * Created by PhpStorm.
 * User: Mark
 * Date: 13/03/2016
 * Time: 14:55.
 */

namespace App\Plugins\Menus;

use App\Model\Link;
use App\Model\Menu;
use App\Model\Activity;
use Illuminate\Http\Request;
use App\Plugins\PluginEngine;
use Illuminate\Validation\Rule;
use Illuminate\Support\Facades\DB;
use App\Classes\Repositories\LinkRepository;
use App\Classes\Repositories\MenuRepository;
use App\Classes\Repositories\PageRepository;

/**
 * Class Controller.
 */
class BackendController extends PluginEngine
{
    /**
     * @var MenuRepository
     */
    private $menus;

    /**
     * @var PageRepository
     */
    private $pages;

    /**
     * @var LinkRepository
     */
    private $links;

    /**
     * BackendController constructor.
     *
     * @param MenuRepository $menus
     * @param PageRepository $pages
     */
    public function __construct(MenuRepository $menus, PageRepository $pages, LinkRepository $links)
    {
        $this->menus = $menus;

        $this->pages = $pages;

        $this->links = $links;
    }

    /**
     * Display a listing of the resource.
     *
     * @param int $group_id
     * @return \Illuminate\Http\Response
     */
    public function index($group_id = 1)
    {
        return $this->make('index')->with('menus', $this->menus->whereTopLevel())->with('list', $this->menus->whereParent($group_id));

The expression return $this->make('index')->with('menus', $this->menus->whereTopLevel())->with('list', $this->menus->whereParent($group_id)) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return $this->make('create')->with('parents', $this->menus->whereTopLevelEditable())->with('linkableObjects', $this->links->allLinkableObjects());

The expression return $this->make('create')->with('parents', $this->menus->whereTopLevelEditable())->with('linkableObjects', $this->links->allLinkableObjects()) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Store a newly created resource in storage.
     *
     * External or Internal Hyperlinks and connections.
     *
     * @param Menu $menu
     * @param  \Illuminate\Http\Request $request
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(Request $request, Menu $menu)
    {
        $request->validate(['title' => 'min:3|max:255|unique:menus,title,NULL,id,deleted_at,NULL|required']);

        $this->save($request, $menu);

        account()->record(Activity::$created, $menu);

The method record() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

        return redirect()->route('admin.menus.index');
    }

    /**
     * Display the specified resource.
     *
     * @param  int $id
     * @return void
     */
    public function show($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param MenuRepository $repository
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        return $this->make('edit')->with('menu', $this->menus->whereID($id))->with('parents', $this->menus->whereTopLevelEditable())->with('linkableObjects', $this->links->allLinkableObjects());

The expression return $this->make('edit')->with('menu', $this->menus->whereID($id))->with('parents', $this->menus->whereTopLevelEditable())->with('linkableObjects', $this->links->allLinkableObjects()) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param Request $request
     * @param MenuRepository $repository
     * @param int $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $request->validate(['title' => ['min:3|max:255|required', Rule::unique('menus')->ignore($id)]]);

        $menu = $this->menus->whereID($id);

        $this->save($request, $menu);

        account()->record(Activity::$updated, $menu);

        return redirect(route('admin.menus.index'));

The expression return redirect(route('admin.menus.index')) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int $id
     * @param MenuRepository $repository
     * @return bool|null
     * @throws \Exception
     */
    public function destroy($id)
    {
        $menu = $this->menus->whereID($id);

        if ($menu->children) {
            foreach ($menu->children as $submenu) {
                $submenu->link->delete();
            }
        }

        $menu->link->delete();

        account()->record(Activity::$deleted, $menu);

        $menu->delete();

        return redirect(route('admin.menus.index'));

The expression return redirect(route('admin.menus.index')) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type null|boolean.

    }

    /**
     * Change the order the menu list.
     */
    public function reorder(Request $request)
    {
        // store the order increment id.
        $increment = 1;

        for ($i = 0; $i < count($request['data']); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $menu = $this->menus->whereID($request['data'][$i]);

            $menu->order = $increment++;

            $menu->save();
        }
    }

    /**
     * Save the data for the menu to the database.
     *
     * @param Request $request
     * @param Menu $menu
     * @return bool
     */
    private function save(Request $request, Menu $menu)
    {
        if (! $request['hyperlinkUrl']) {
            $model = json_decode($request['linkable_object']);

            $menu->hyperlink = null;
            $menu->title = $request['title'];
            $menu->page_id = $request['page_id'];
            $menu->parent_id = $request['menu_id'];
            $menu->target = $request['target'];
            $menu->status = true;
            $menu->creator_id = account()->id;

            DB::transaction(function () use ($menu, $model) {
                $menu->save();

                if ($menu->link) {
                    $menu->link->connect($menu, getMorphedModel($model->class, $model->key))->save();
                } else {
                    (new Link)->connect($menu, getMorphedModel($model->class, $model->key))->save();
                }
            }, 5);

            return true;
        } else {
            // we expect this to be a hyperlink.
            $request->validate(['hyperlinkUrl' => 'required|max:255|active_url']);

            $menu->page_id = null;
            $menu->title = $request['title'];
            $menu->parent_id = $request['menu_id'];
            $menu->hyperlink = $request['hyperlinkUrl'];
            $menu->target = $request['target'];
            $menu->status = true;
            $menu->creator_id = account()->id;

            $menu->save();
        }
    }
}