WebServCo\Framework\Libraries\Config::append()

Complexity

Conditions	7
Paths	2

Size

Total Lines	16
Code Lines	10

Duplication

Lines	16
Ratio	100 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	Config::add()	0	8	1

<?php
namespace WebServCo\Framework\Libraries;

final class Config extends \WebServCo\Framework\AbstractLibrary
{
    /**
     * Stores configuration data.
     */
    private $config = [];
    
    /**
     * Application environment.
     */
    private $env;
    
    /**
     * Add base setting data.
     *
     * Keys will be preserved.
     * Existing values will be overwritten.
     *
     * @param string $setting Name of setting to load.
     * @param mixed $data Data to add.
     */
    final public function add($setting, $data)

Unnecessary FINAL modifier in FINAL class

    {
        $this->config = \WebServCo\Framework\ArrayStorage::append(
            $this->config,
            [$setting => $data]
        );
        return true;
    }
    
    /**
     * Load configuration data from a file.
     *
     * Data is appended to any existing data.
     * @param string $setting Name of setting to load.
     * @param string $path Directory where the file is located.

There is no parameter named $path. Was it maybe removed?

     *                      File name must be <$setting>.php
     * @return mixed
     */
    final public function load($setting, $pathProject)

Unnecessary FINAL modifier in FINAL class

    {
        $pathFull = "{$pathProject}config/".$this->getEnv()."/{$setting}.php";
        if (!is_readable($pathFull)) {
            return false;
        }
        $data = (include $pathFull);
        return is_array($data) ? $data : false;
    }
    
    /**
     * Sets a configuration value.
     *
     * @param mixed $setting Can be an array, a string,
     *                          or a special formatted string
     *                          (eg 'app|path|project').
     * @param mixed $value The value to be stored.
     *
     * @return bool True on success and false on failure.
     */
    final public function set($setting, $value)

Unnecessary FINAL modifier in FINAL class

    {
        if (empty($setting)) {
            return false;
        }
        $this->config = \WebServCo\Framework\ArrayStorage::set($this->config, $setting, $value);

It seems like \WebServCo\Framework\ArrayStorage::set($this->config, $setting, $value) can also be of type false. However, the property $config is declared as type array. Maybe add an additional type check?

        return true;
    }
    
    final public function get($setting, $defaultValue = false)

Unnecessary FINAL modifier in FINAL class

    {
        return \WebServCo\Framework\ArrayStorage::get($this->config, $setting, $defaultValue);
    }
    
    /**
     * Set application environment value.
     *
     * @param string $env
     *
     * @return bool
     */
    final public function setEnv($env = null)

Unnecessary FINAL modifier in FINAL class

    {
        if (in_array($env, \WebServCo\Framework\Environment::getOptions())) {
            $this->env = $env;
        } else {
            $this->env = \WebServCo\Framework\Environment::ENV_DEV;
        }
        
        return true;
    }
    
    /**
     * Get application environment value.
     *
     * @return string
     */
    final public function getEnv()

Unnecessary FINAL modifier in FINAL class

    {
        return $this->env ?: \WebServCo\Framework\Environment::ENV_DEV;
    }
}