WebServCo\Framework\Environment\Settings::load()

Complexity

Conditions	4
Paths	4

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function load(string $projectPath): bool
    {
        $filePath = \sprintf('%sconfig/%s', $projectPath, self::FILENAME);
        if (!\is_readable($filePath)) {
            throw new ConfigurationException('Environment configuration file is not readable.');
        }
        $data = \parse_ini_file(
            $filePath, // filename
            // true => "multidimensional array, with the section names and settings included"
            false, // process_sections
            // \INI_SCANNER_TYPED - tries to convert booleans and numeric types
            // INI_SCANNER_NORMAL - everything is a string
            \INI_SCANNER_TYPED, // scanner_mode
        );
        if (!$data) {

The expression $data of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            throw new ConfigurationException('Error loading environment configuration file');
        }
        foreach ($data as $key => $value) {
            Setting::set($key, $value);
        }
        return true;
    }