Structure::toArray() - Code Metrics - Inspection of "AbstractClientRequest" - webservco/api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 55ced3...b98498 )

by Radu

created 2018-10-30 17:00 UTC

Structure::toArray() A

↳ Parent: Structure

Complexity

Conditions	6
Paths	8

Size

Total Lines	23
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
eloc	15
nc	8
nop	0
dl	0
loc	23
rs	9.2222
c	0
b	0
f	0

<?php
namespace WebServCo\Api\JsonApi;

class Structure
{
    protected $meta;
    protected $jsonapi;
    protected $data;
    protected $errors;

    const CONTENT_TYPE = 'application/vnd.api+json';
    const VERSION = '1.0';

    public function __construct()
    {
        $this->meta = [];
        $this->jsonapi = ['version' => self::VERSION];
        $this->data = [];
        $this->errors = [];
    }

    public function setData(\WebServCo\Api\JsonApi\Interfaces\ResourceObjectInterface $resourceObject)
    {
        $this->data[] = $resourceObject;
    }

    public function setError(\WebServCo\Api\JsonApi\Error $error)
    {
        $this->errors[] = $error;
    }

    public function toArray()
    {
        $array = [
            'jsonapi' => $this->jsonapi,
        ];
        if ($this->meta) {

            $array['meta'] = $this->meta;
        }
        if (!empty($this->errors)) {
            foreach ($this->errors as $error) {
                $array['errors'][] = $error->toArray();
            }
        } else {
            $dataItems = count($this->data);
            if (1 < $dataItems) {
                foreach ($this->data as $item) {
                    $array['data'][] = $item->toArray();
                }
            } else {
                $array['data'] = $this->data[0]->toArray();
            }
        }
        return $array;
    }

    public function toJson()
    {
        $array = $this->toArray();
        return json_encode($array);
    }
}


1			<?php
2			namespace WebServCo\Api\JsonApi;
3
4			class Structure
5			{
6			protected $meta;
7			protected $jsonapi;
8			protected $data;
9			protected $errors;
10
11			const CONTENT_TYPE = 'application/vnd.api+json';
12			const VERSION = '1.0';
13
14			public function __construct()
15			{
16			$this->meta = [];
17			$this->jsonapi = ['version' => self::VERSION];
18			$this->data = [];
19			$this->errors = [];
20			}
21
22			public function setData(\WebServCo\Api\JsonApi\Interfaces\ResourceObjectInterface $resourceObject)
23			{
24			$this->data[] = $resourceObject;
25			}
26
27			public function setError(\WebServCo\Api\JsonApi\Error $error)
28			{
29			$this->errors[] = $error;
30			}
31
32			public function toArray()
33			{
34			$array = [
35			'jsonapi' => $this->jsonapi,
36			];
37			if ($this->meta) {
			0 ignored issues – show Bug Best Practice introduced 2018-10-19 18:21 UTC by Report Bug Copy Issue Report The expression `$this->meta` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
38			$array['meta'] = $this->meta;
39			}
40			if (!empty($this->errors)) {
41			foreach ($this->errors as $error) {
42			$array['errors'][] = $error->toArray();
43			}
44			} else {
45			$dataItems = count($this->data);
46			if (1 < $dataItems) {
47			foreach ($this->data as $item) {
48			$array['data'][] = $item->toArray();
49			}
50			} else {
51			$array['data'] = $this->data[0]->toArray();
52			}
53			}
54			return $array;
55			}
56
57			public function toJson()
58			{
59			$array = $this->toArray();
60			return json_encode($array);
61			}
62			}
63

webservco / api

Push — master ( 55ced3...b98498 )

Structure::toArray() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like