Revision::__construct() - Code Metrics - Inspection of "Code refactoring, PHP 7.1, absolute paths, ...." - webrouse/n-asset-macro - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#5)

by Michal

created 2018-12-05 07:03 UTC

Revision::__construct() A

↳ Parent: Revision

Complexity

Conditions	5
Paths	16

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	5

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	9
cts	9
cp	1
rs	9.5222
c	0
b	0
f	0
cc	5
nc	16
nop	3
crap	5

<?php
declare(strict_types=1);

namespace Webrouse\AssetMacro;


use Nette\Utils\Strings;

class Revision
{
	/** @var Config */
	private $config;

	/** @var string */
	private $assetPath;

	/** @var string */
	private $rawValue;

	/** @var bool */
	private $isVersion;

	/** @var string */
	private $relativePath;

	/** @var string */
	private $absolutePath;

	/** @var string */
	private $relativeUrl;


	public function __construct(Config $config, string $assetPath, ?string $revision)
	{
		$this->config = $config;
		$this->assetPath = $assetPath;
		$this->rawValue = $revision ?: 'unknown';

		// Is revision only version (query parameter) or full path to asset?
		$this->isVersion = $revision === null || !Strings::match((string) $revision, '/[.\/]/');

		$this->relativePath = ($this->isVersion ? $this->assetPath : Utils::normalizePath($revision));
		$this->absolutePath = $this->config->getAssetsPath() . DIRECTORY_SEPARATOR . $this->relativePath;
		$this->relativeUrl = $this->isVersion ? ($this->assetPath . '?v=' . $this->rawValue) : $revision;
	}


	public function getRawValue(): string
	{
		return $this->rawValue;
	}


	public function isVersionHash(): bool
	{
		return $this->isVersion;
	}


	public function getAssetPath(): string
	{
		return $this->assetPath;
	}


	public function getRelativePath(): string
	{
		return $this->relativePath;
	}


	public function getAbsolutePath(): string
	{
		return $this->absolutePath;
	}


	public function getRelativeUrl(): string
	{
		return $this->relativeUrl;
	}
}


1		<?php
2		declare(strict_types=1);
3
4		namespace Webrouse\AssetMacro;
5
6
7		use Nette\Utils\Strings;
8
9		class Revision
10		{
11		/** @var Config */
12		private $config;
13
14		/** @var string */
15		private $assetPath;
16
17		/** @var string */
18		private $rawValue;
19
20		/** @var bool */
21		private $isVersion;
22
23		/** @var string */
24		private $relativePath;
25
26		/** @var string */
27		private $absolutePath;
28
29		/** @var string */
30		private $relativeUrl;
31
32
33	1	public function __construct(Config $config, string $assetPath, ?string $revision)
34		{
35	1	$this->config = $config;
36	1	$this->assetPath = $assetPath;
37	1	$this->rawValue = $revision ?: 'unknown';
38
39		// Is revision only version (query parameter) or full path to asset?
40	1	$this->isVersion = $revision === null \|\| !Strings::match((string) $revision, '/[.\/]/');
41
42	1	$this->relativePath = ($this->isVersion ? $this->assetPath : Utils::normalizePath($revision));
43	1	$this->absolutePath = $this->config->getAssetsPath() . DIRECTORY_SEPARATOR . $this->relativePath;
44	1	$this->relativeUrl = $this->isVersion ? ($this->assetPath . '?v=' . $this->rawValue) : $revision;
45	1	}
46
47
48		public function getRawValue(): string
49		{
50	1	return $this->rawValue;
51		}
52
53
54		public function isVersionHash(): bool
55		{
56		return $this->isVersion;
57		}
58
59
60		public function getAssetPath(): string
61		{
62		return $this->assetPath;
63		}
64
65
66		public function getRelativePath(): string
67		{
68	1	return $this->relativePath;
69		}
70
71
72		public function getAbsolutePath(): string
73		{
74	1	return $this->absolutePath;
75		}
76
77
78		public function getRelativeUrl(): string
79		{
80	1	return $this->relativeUrl;
81		}
82		}
83

webrouse / n-asset-macro

Pull Request — master (#5)

Revision::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like