Passed
Pull Request — master (#557)
by Max
03:00
created
src/Language/Parser.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
         $this->expect($openKind);
370 370
 
371 371
         $nodes = [];
372
-        while (! $this->skip($closeKind)) {
372
+        while (!$this->skip($closeKind)) {
373 373
             $nodes[] = $parseFn($this);
374 374
         }
375 375
 
@@ -389,7 +389,7 @@  discard block
 block discarded – undo
389 389
         $this->expect($openKind);
390 390
 
391 391
         $nodes = [$parseFn($this)];
392
-        while (! $this->skip($closeKind)) {
392
+        while (!$this->skip($closeKind)) {
393 393
             $nodes[] = $parseFn($this);
394 394
         }
395 395
 
@@ -423,7 +423,7 @@  discard block
 block discarded – undo
423 423
         return new DocumentNode([
424 424
             'definitions' => $this->many(
425 425
                 Token::SOF,
426
-                function () {
426
+                function() {
427 427
                     return $this->parseDefinition();
428 428
                 },
429 429
                 Token::EOF
@@ -550,7 +550,7 @@  discard block
 block discarded – undo
550 550
         return $this->peek(Token::PAREN_L)
551 551
             ? $this->many(
552 552
                 Token::PAREN_L,
553
-                function () {
553
+                function() {
554 554
                     return $this->parseVariableDefinition();
555 555
                 },
556 556
                 Token::PAREN_R
@@ -601,7 +601,7 @@  discard block
 block discarded – undo
601 601
             [
602 602
                 'selections' => $this->many(
603 603
                     Token::BRACE_L,
604
-                    function () {
604
+                    function() {
605 605
                         return $this->parseSelection();
606 606
                     },
607 607
                     Token::BRACE_R
@@ -656,10 +656,10 @@  discard block
 block discarded – undo
656 656
     private function parseArguments(bool $isConst) : NodeList
657 657
     {
658 658
         $parseFn = $isConst
659
-            ? function () {
659
+            ? function() {
660 660
                 return $this->parseConstArgument();
661 661
             }
662
-            : function () {
662
+            : function() {
663 663
                 return $this->parseArgument();
664 664
             };
665 665
 
@@ -856,7 +856,7 @@  discard block
 block discarded – undo
856 856
                 break;
857 857
 
858 858
             case Token::DOLLAR:
859
-                if (! $isConst) {
859
+                if (!$isConst) {
860 860
                     return $this->parseVariable();
861 861
                 }
862 862
                 break;
@@ -897,9 +897,9 @@  discard block
 block discarded – undo
897 897
     private function parseArray(bool $isConst) : ListValueNode
898 898
     {
899 899
         $start   = $this->lexer->token;
900
-        $parseFn = $isConst ? function () {
900
+        $parseFn = $isConst ? function() {
901 901
             return $this->parseConstValue();
902
-        } : function () {
902
+        } : function() {
903 903
             return $this->parseVariableValue();
904 904
         };
905 905
 
@@ -916,7 +916,7 @@  discard block
 block discarded – undo
916 916
         $start = $this->lexer->token;
917 917
         $this->expect(Token::BRACE_L);
918 918
         $fields = [];
919
-        while (! $this->skip(Token::BRACE_R)) {
919
+        while (!$this->skip(Token::BRACE_R)) {
920 920
             $fields[] = $this->parseObjectField($isConst);
921 921
         }
922 922
 
@@ -1090,7 +1090,7 @@  discard block
 block discarded – undo
1090 1090
 
1091 1091
         $operationTypes = $this->many(
1092 1092
             Token::BRACE_L,
1093
-            function () {
1093
+            function() {
1094 1094
                 return $this->parseOperationTypeDefinition();
1095 1095
             },
1096 1096
             Token::BRACE_R
@@ -1180,7 +1180,7 @@  discard block
 block discarded – undo
1180 1180
                 $types[] = $this->parseNamedType();
1181 1181
             } while ($this->skip(Token::AMP) ||
1182 1182
                 // Legacy support for the SDL?
1183
-                (! empty($this->lexer->options['allowLegacySDLImplementsInterfaces']) && $this->peek(Token::NAME))
1183
+                (!empty($this->lexer->options['allowLegacySDLImplementsInterfaces']) && $this->peek(Token::NAME))
1184 1184
             );
1185 1185
         }
1186 1186
 
@@ -1193,7 +1193,7 @@  discard block
 block discarded – undo
1193 1193
     private function parseFieldsDefinition() : NodeList
1194 1194
     {
1195 1195
         // Legacy support for the SDL?
1196
-        if (! empty($this->lexer->options['allowLegacySDLEmptyFields'])
1196
+        if (!empty($this->lexer->options['allowLegacySDLEmptyFields'])
1197 1197
             && $this->peek(Token::BRACE_L)
1198 1198
             && $this->lexer->lookahead()->kind === Token::BRACE_R
1199 1199
         ) {
@@ -1207,7 +1207,7 @@  discard block
 block discarded – undo
1207 1207
             $nodeList = $this->peek(Token::BRACE_L)
1208 1208
                 ? $this->many(
1209 1209
                     Token::BRACE_L,
1210
-                    function () {
1210
+                    function() {
1211 1211
                         return $this->parseFieldDefinition();
1212 1212
                     },
1213 1213
                     Token::BRACE_R
@@ -1250,7 +1250,7 @@  discard block
 block discarded – undo
1250 1250
         $nodeList = $this->peek(Token::PAREN_L)
1251 1251
             ? $this->many(
1252 1252
                 Token::PAREN_L,
1253
-                function () {
1253
+                function() {
1254 1254
                     return $this->parseInputValueDefinition();
1255 1255
                 },
1256 1256
                 Token::PAREN_R
@@ -1382,7 +1382,7 @@  discard block
 block discarded – undo
1382 1382
         $nodeList = $this->peek(Token::BRACE_L)
1383 1383
             ? $this->many(
1384 1384
                 Token::BRACE_L,
1385
-                function () {
1385
+                function() {
1386 1386
                     return $this->parseEnumValueDefinition();
1387 1387
                 },
1388 1388
                 Token::BRACE_R
@@ -1440,7 +1440,7 @@  discard block
 block discarded – undo
1440 1440
         $nodeList = $this->peek(Token::BRACE_L)
1441 1441
             ? $this->many(
1442 1442
                 Token::BRACE_L,
1443
-                function () {
1443
+                function() {
1444 1444
                     return $this->parseInputValueDefinition();
1445 1445
                 },
1446 1446
                 Token::BRACE_R
Please login to merge, or discard this patch.
src/Executor/Promise/Adapter/ReactPromiseAdapter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,12 +80,12 @@
 block discarded – undo
80 80
         // TODO: rework with generators when PHP minimum required version is changed to 5.5+
81 81
         $promisesOrValues = Utils::map(
82 82
             $promisesOrValues,
83
-            static function ($item) {
83
+            static function($item) {
84 84
                 return $item instanceof Promise ? $item->adoptedPromise : $item;
85 85
             }
86 86
         );
87 87
 
88
-        $promise = all($promisesOrValues)->then(static function ($values) use ($promisesOrValues) {
88
+        $promise = all($promisesOrValues)->then(static function($values) use ($promisesOrValues) {
89 89
             $orderedResults = [];
90 90
 
91 91
             foreach ($promisesOrValues as $key => $value) {
Please login to merge, or discard this patch.
src/Executor/Promise/Adapter/SyncPromise.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     public static function runQueue() : void
42 42
     {
43 43
         $q = self::$queue;
44
-        while ($q !== null && ! $q->isEmpty()) {
44
+        while ($q !== null && !$q->isEmpty()) {
45 45
             $task = $q->dequeue();
46 46
             $task();
47 47
         }
@@ -56,10 +56,10 @@  discard block
 block discarded – undo
56 56
                 }
57 57
                 if (is_object($value) && method_exists($value, 'then')) {
58 58
                     $value->then(
59
-                        function ($resolvedValue) {
59
+                        function($resolvedValue) {
60 60
                             $this->resolve($resolvedValue);
61 61
                         },
62
-                        function ($reason) {
62
+                        function($reason) {
63 63
                             $this->reject($reason);
64 64
                         }
65 65
                     );
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 
86 86
     public function reject($reason) : self
87 87
     {
88
-        if (! $reason instanceof Throwable) {
88
+        if (!$reason instanceof Throwable) {
89 89
             throw new Exception('SyncPromise::reject() has to be called with an instance of \Throwable');
90 90
         }
91 91
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
         );
116 116
 
117 117
         foreach ($this->waiting as $descriptor) {
118
-            self::getQueue()->enqueue(function () use ($descriptor) {
118
+            self::getQueue()->enqueue(function() use ($descriptor) {
119 119
                 /** @var self $promise */
120 120
                 [$promise, $onFulfilled, $onRejected] = $descriptor;
121 121
 
Please login to merge, or discard this patch.
src/Executor/Promise/Adapter/SyncPromiseAdapter.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
      */
33 33
     public function convertThenable($thenable)
34 34
     {
35
-        if (! $thenable instanceof Deferred) {
35
+        if (!$thenable instanceof Deferred) {
36 36
             throw new InvariantViolation('Expected instance of GraphQL\Deferred, got ' . Utils::printSafe($thenable));
37 37
         }
38 38
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
             if ($promiseOrValue instanceof Promise) {
111 111
                 $result[$index] = null;
112 112
                 $promiseOrValue->then(
113
-                    static function ($value) use ($index, &$count, $total, &$result, $all) {
113
+                    static function($value) use ($index, &$count, $total, &$result, $all) {
114 114
                         $result[$index] = $value;
115 115
                         $count++;
116 116
                         if ($count < $total) {
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
         $promiseQueue = SyncPromise::getQueue();
146 146
 
147 147
         while ($promise->adoptedPromise->state === SyncPromise::PENDING &&
148
-            ! ($dfdQueue->isEmpty() && $promiseQueue->isEmpty())
148
+            !($dfdQueue->isEmpty() && $promiseQueue->isEmpty())
149 149
         ) {
150 150
             Deferred::runQueue();
151 151
             SyncPromise::runQueue();
Please login to merge, or discard this patch.
src/Executor/Promise/Promise.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
      */
25 25
     public function __construct($adoptedPromise, PromiseAdapter $adapter)
26 26
     {
27
-        Utils::invariant(! $adoptedPromise instanceof self, 'Expecting promise from adapted system, got ' . self::class);
27
+        Utils::invariant(!$adoptedPromise instanceof self, 'Expecting promise from adapted system, got ' . self::class);
28 28
 
29 29
         $this->adapter        = $adapter;
30 30
         $this->adoptedPromise = $adoptedPromise;
Please login to merge, or discard this patch.
src/Executor/ExecutionResult.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -138,8 +138,8 @@  discard block
 block discarded – undo
138 138
     {
139 139
         $result = [];
140 140
 
141
-        if (! empty($this->errors)) {
142
-            $errorsHandler = $this->errorsHandler ?: static function (array $errors, callable $formatter) {
141
+        if (!empty($this->errors)) {
142
+            $errorsHandler = $this->errorsHandler ?: static function(array $errors, callable $formatter) {
143 143
                 return array_map($formatter, $errors);
144 144
             };
145 145
 
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
             $result['data'] = $this->data;
154 154
         }
155 155
 
156
-        if (! empty($this->extensions)) {
156
+        if (!empty($this->extensions)) {
157 157
             $result['extensions'] = $this->extensions;
158 158
         }
159 159
 
Please login to merge, or discard this patch.
src/Executor/Values.php 2 patches
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -265,23 +265,23 @@
 block discarded – undo
265 265
                 );
266 266
             } elseif ($hasValue) {
267 267
                 if ($argumentValueNode instanceof NullValueNode) {
268
-                  // If the explicit value `null` was provided, an entry in the coerced
269
-                  // values must exist as the value `null`.
268
+                    // If the explicit value `null` was provided, an entry in the coerced
269
+                    // values must exist as the value `null`.
270 270
                     $coercedValues[$name] = null;
271 271
                 } elseif ($argumentValueNode instanceof VariableNode) {
272 272
                     $variableName = $argumentValueNode->name->value;
273 273
                     Utils::invariant($variableValues !== null, 'Must exist for hasValue to be true.');
274
-                  // Note: This does no further checking that this variable is correct.
275
-                  // This assumes that this query has been validated and the variable
276
-                  // usage here is of the correct type.
274
+                    // Note: This does no further checking that this variable is correct.
275
+                    // This assumes that this query has been validated and the variable
276
+                    // usage here is of the correct type.
277 277
                     $coercedValues[$name] = $variableValues[$variableName] ?? null;
278 278
                 } else {
279 279
                     $valueNode    = $argumentValueNode;
280 280
                     $coercedValue = AST::valueFromAST($valueNode, $argType, $variableValues);
281 281
                     if (Utils::isInvalid($coercedValue)) {
282
-                      // Note: ValuesOfCorrectType validation should catch this before
283
-                      // execution. This is a runtime check to ensure execution does not
284
-                      // continue with an invalid argument value.
282
+                        // Note: ValuesOfCorrectType validation should catch this before
283
+                        // execution. This is a runtime check to ensure execution does not
284
+                        // continue with an invalid argument value.
285 285
                         throw new Error(
286 286
                             'Argument "' . $name . '" has invalid value ' . Printer::doPrint($valueNode) . '.',
287 287
                             [$argumentValueNode]
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
             /** @var InputType|Type $varType */
68 68
             $varType = TypeInfo::typeFromAST($schema, $varDefNode->type);
69 69
 
70
-            if (! Type::isInputType($varType)) {
70
+            if (!Type::isInputType($varType)) {
71 71
                 // Must use input types for variables. This should be caught during
72 72
                 // validation, however is checked again here for safety.
73 73
                 $errors[] = new Error(
@@ -82,11 +82,11 @@  discard block
 block discarded – undo
82 82
                 $hasValue = array_key_exists($varName, $inputs);
83 83
                 $value    = $hasValue ? $inputs[$varName] : Utils::undefined();
84 84
 
85
-                if (! $hasValue && $varDefNode->defaultValue) {
85
+                if (!$hasValue && $varDefNode->defaultValue) {
86 86
                     // If no value was provided to a variable with a default value,
87 87
                     // use the default value.
88 88
                     $coercedValues[$varName] = AST::valueFromAST($varDefNode->defaultValue, $varType);
89
-                } elseif ((! $hasValue || $value === null) && ($varType instanceof NonNull)) {
89
+                } elseif ((!$hasValue || $value === null) && ($varType instanceof NonNull)) {
90 90
                     // If no value or a nullish value was provided to a variable with a
91 91
                     // non-null type (required), produce an error.
92 92
                     $errors[] = new Error(
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
             }
137 137
         }
138 138
 
139
-        if (! empty($errors)) {
139
+        if (!empty($errors)) {
140 140
             return [$errors, null];
141 141
         }
142 142
 
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
         if (isset($node->directives) && $node->directives instanceof NodeList) {
161 161
             $directiveNode = Utils::find(
162 162
                 $node->directives,
163
-                static function (DirectiveNode $directive) use ($directiveDef) {
163
+                static function(DirectiveNode $directive) use ($directiveDef) {
164 164
                     return $directive->name->value === $directiveDef->name;
165 165
                 }
166 166
             );
@@ -233,11 +233,11 @@  discard block
 block discarded – undo
233 233
                 $isNull   = $argumentValueNode instanceof NullValueNode;
234 234
             }
235 235
 
236
-            if (! $hasValue && $argumentDefinition->defaultValueExists()) {
236
+            if (!$hasValue && $argumentDefinition->defaultValueExists()) {
237 237
                 // If no argument was provided where the definition has a default value,
238 238
                 // use the default value.
239 239
                 $coercedValues[$name] = $argumentDefinition->defaultValue;
240
-            } elseif ((! $hasValue || $isNull) && ($argType instanceof NonNull)) {
240
+            } elseif ((!$hasValue || $isNull) && ($argType instanceof NonNull)) {
241 241
                 // If no argument or a null value was provided to an argument with a
242 242
                 // non-null type (required), produce a field error.
243 243
                 if ($isNull) {
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
327 327
 
328 328
         return $errors
329 329
             ? array_map(
330
-                static function (Throwable $error) {
330
+                static function(Throwable $error) {
331 331
                     return $error->getMessage();
332 332
                 },
333 333
                 $errors
Please login to merge, or discard this patch.
src/GraphQL.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
                 $queryComplexity->setRawVariableValues($variableValues);
142 142
             } else {
143 143
                 foreach ($validationRules as $rule) {
144
-                    if (! ($rule instanceof QueryComplexity)) {
144
+                    if (!($rule instanceof QueryComplexity)) {
145 145
                         continue;
146 146
                     }
147 147
 
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
 
152 152
             $validationErrors = DocumentValidator::validate($schema, $documentNode, $validationRules);
153 153
 
154
-            if (! empty($validationErrors)) {
154
+            if (!empty($validationErrors)) {
155 155
                 return $promiseAdapter->createFulfilled(
156 156
                     new ExecutionResult(null, $validationErrors)
157 157
                 );
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
         if ($promiseAdapter instanceof SyncPromiseAdapter) {
214 214
             $result = $promiseAdapter->wait($result)->toArray();
215 215
         } else {
216
-            $result = $result->then(static function (ExecutionResult $r) {
216
+            $result = $result->then(static function(ExecutionResult $r) {
217 217
                 return $r->toArray();
218 218
             });
219 219
         }
Please login to merge, or discard this patch.
src/Experimental/Executor/Collector.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
             $fieldName = $fieldNode->name->value;
128 128
 
129 129
             $argumentValueMap = null;
130
-            if (! empty($fieldNode->arguments)) {
130
+            if (!empty($fieldNode->arguments)) {
131 131
                 foreach ($fieldNode->arguments as $argumentNode) {
132 132
                     $argumentValueMap                             = $argumentValueMap ?? [];
133 133
                     $argumentValueMap[$argumentNode->name->value] = $argumentNode->value;
@@ -135,8 +135,8 @@  discard block
 block discarded – undo
135 135
             }
136 136
 
137 137
             if ($fieldName !== Introspection::TYPE_NAME_FIELD_NAME &&
138
-                ! ($runtimeType === $this->schema->getQueryType() && ($fieldName === Introspection::SCHEMA_FIELD_NAME || $fieldName === Introspection::TYPE_FIELD_NAME)) &&
139
-                ! $runtimeType->hasField($fieldName)
138
+                !($runtimeType === $this->schema->getQueryType() && ($fieldName === Introspection::SCHEMA_FIELD_NAME || $fieldName === Introspection::TYPE_FIELD_NAME)) &&
139
+                !$runtimeType->hasField($fieldName)
140 140
             ) {
141 141
                 // do not emit error
142 142
                 continue;
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
 
155 155
         foreach ($selectionSet->selections as $selection) {
156 156
             /** @var FieldNode|FragmentSpreadNode|InlineFragmentNode $selection */
157
-            if (! empty($selection->directives)) {
157
+            if (!empty($selection->directives)) {
158 158
                 foreach ($selection->directives as $directiveNode) {
159 159
                     if ($directiveNode->name->value === Directive::SKIP_NAME) {
160 160
                         /** @var VariableNode|NullValueNode|IntValueNode|FloatValueNode|StringValueNode|BooleanValueNode|EnumValueNode|ListValueNode|ObjectValueNode|null $condition */
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
             if ($selection instanceof FieldNode) {
204 204
                 $resultName = $selection->alias === null ? $selection->name->value : $selection->alias->value;
205 205
 
206
-                if (! isset($this->fields[$resultName])) {
206
+                if (!isset($this->fields[$resultName])) {
207 207
                     $this->fields[$resultName] = [];
208 208
                 }
209 209
 
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
                     continue;
216 216
                 }
217 217
 
218
-                if (! isset($this->fragments[$fragmentName])) {
218
+                if (!isset($this->fragments[$fragmentName])) {
219 219
                     $this->runtime->addError(new Error(
220 220
                         sprintf('Fragment "%s" does not exist.', $fragmentName),
221 221
                         $selection
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
                 $fragmentDefinition = $this->fragments[$fragmentName];
229 229
                 $conditionTypeName  = $fragmentDefinition->typeCondition->name->value;
230 230
 
231
-                if (! $this->schema->hasType($conditionTypeName)) {
231
+                if (!$this->schema->hasType($conditionTypeName)) {
232 232
                     $this->runtime->addError(new Error(
233 233
                         sprintf('Cannot spread fragment "%s", type "%s" does not exist.', $fragmentName, $conditionTypeName),
234 234
                         $selection
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
243 243
                         continue;
244 244
                     }
245 245
                 } elseif ($conditionType instanceof AbstractType) {
246
-                    if (! $this->schema->isPossibleType($conditionType, $runtimeType)) {
246
+                    if (!$this->schema->isPossibleType($conditionType, $runtimeType)) {
247 247
                         continue;
248 248
                     }
249 249
                 }
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
                 if ($selection->typeCondition !== null) {
254 254
                     $conditionTypeName = $selection->typeCondition->name->value;
255 255
 
256
-                    if (! $this->schema->hasType($conditionTypeName)) {
256
+                    if (!$this->schema->hasType($conditionTypeName)) {
257 257
                         $this->runtime->addError(new Error(
258 258
                             sprintf('Cannot spread inline fragment, type "%s" does not exist.', $conditionTypeName),
259 259
                             $selection
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
                             continue;
269 269
                         }
270 270
                     } elseif ($conditionType instanceof AbstractType) {
271
-                        if (! $this->schema->isPossibleType($conditionType, $runtimeType)) {
271
+                        if (!$this->schema->isPossibleType($conditionType, $runtimeType)) {
272 272
                             continue;
273 273
                         }
274 274
                     }
Please login to merge, or discard this patch.