PrintErrorTest::testPrintsAnErrorWithNodesFromDifferentSources() - Code Metrics - Inspection of "Fixed tests for PHPUnit 7+" - webonyx/graphql-php - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 392b56...c3d69c )

by Vladimir

created 2018-08-07 17:00 UTC

testPrintsAnErrorWithNodesFromDifferentSources() A

↳ Parent: PrintErrorTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	43
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	26
dl	0
loc	43
c	0
b	0
f	0
rs	9.504
cc	1
nc	1
nop	0

<?php
namespace GraphQL\Tests\Error;

use GraphQL\Error\Error;
use GraphQL\Error\FormattedError;
use GraphQL\Language\Parser;
use GraphQL\Language\Source;
use GraphQL\Language\SourceLocation;
use PHPUnit\Framework\TestCase;

class PrintErrorTest extends TestCase
{
    // Describe printError

    /**
     * @it prints an line numbers with correct padding
     */
    public function testPrintsAnLineNumbersWithCorrectPadding()
    {
        $singleDigit = new Error(
            'Single digit line number with no padding',
            null,
            new Source('*', 'Test', new SourceLocation(9, 1)),
            [0]
        );

        $actual = FormattedError::printError($singleDigit);
        $expected = 'Single digit line number with no padding

Test (9:1)
 9: *
    ^
';
        $this->assertEquals($expected, $actual);

        $doubleDigit = new Error(
            'Left padded first line number',
            null,
            new Source("*\n", 'Test', new SourceLocation(9, 1)),
            [0]
        );
        $actual = FormattedError::printError($doubleDigit);
        $expected = 'Left padded first line number

Test (9:1)
 9: *
    ^
10: 
';
        $this->assertEquals($expected, $actual);
    }

    /**
     * @it prints an error with nodes from different sources
     */
    public function testPrintsAnErrorWithNodesFromDifferentSources()
    {
        $sourceA = Parser::parse(new Source('type Foo {
  field: String
}',
        'SourceA'
        ));

        $fieldTypeA = $sourceA->definitions[0]->fields[0]->type;


        $sourceB = Parser::parse(new Source('type Foo {
  field: Int
}',
            'SourceB'
        ));

        $fieldTypeB = $sourceB->definitions[0]->fields[0]->type;


        $error = new Error(
            'Example error with two nodes',
            [
                $fieldTypeA,
                $fieldTypeB,
            ]
        );

        $this->assertEquals(
            'Example error with two nodes

SourceA (2:10)
1: type Foo {
2:   field: String
            ^
3: }

SourceB (2:10)
1: type Foo {
2:   field: Int
            ^
3: }
',
            FormattedError::printError($error)
        );
    }
}


1			<?php
2			namespace GraphQL\Tests\Error;
3
4			use GraphQL\Error\Error;
5			use GraphQL\Error\FormattedError;
6			use GraphQL\Language\Parser;
7			use GraphQL\Language\Source;
8			use GraphQL\Language\SourceLocation;
9			use PHPUnit\Framework\TestCase;
10
11			class PrintErrorTest extends TestCase
12			{
13			// Describe printError
14
15			/**
16			* @it prints an line numbers with correct padding
17			*/
18			public function testPrintsAnLineNumbersWithCorrectPadding()
19			{
20			$singleDigit = new Error(
21			'Single digit line number with no padding',
22			null,
23			new Source('*', 'Test', new SourceLocation(9, 1)),
24			[0]
25			);
26
27			$actual = FormattedError::printError($singleDigit);
28			$expected = 'Single digit line number with no padding
29
30			Test (9:1)
31			9: *
32			^
33			';
34			$this->assertEquals($expected, $actual);
35
36			$doubleDigit = new Error(
37			'Left padded first line number',
38			null,
39			new Source("*\n", 'Test', new SourceLocation(9, 1)),
40			[0]
41			);
42			$actual = FormattedError::printError($doubleDigit);
43			$expected = 'Left padded first line number
44
45			Test (9:1)
46			9: *
47			^
48			10:
49			';
50			$this->assertEquals($expected, $actual);
51			}
52
53			/**
54			* @it prints an error with nodes from different sources
55			*/
56			public function testPrintsAnErrorWithNodesFromDifferentSources()
57			{
58			$sourceA = Parser::parse(new Source('type Foo {
59			field: String
60			}',
61			'SourceA'
62			));
63
64			$fieldTypeA = $sourceA->definitions[0]->fields[0]->type;
			0 ignored issues – show Bug introduced 2018-06-19 12:00 UTC by Report Bug Copy Issue Report Accessing `fields` on the interface `GraphQL\Language\AST\DefinitionNode` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
65
66			$sourceB = Parser::parse(new Source('type Foo {
67			field: Int
68			}',
69			'SourceB'
70			));
71
72			$fieldTypeB = $sourceB->definitions[0]->fields[0]->type;
73
74
75			$error = new Error(
76			'Example error with two nodes',
77			[
78			$fieldTypeA,
79			$fieldTypeB,
80			]
81			);
82
83			$this->assertEquals(
84			'Example error with two nodes
85
86			SourceA (2:10)
87			1: type Foo {
88			2: field: String
89			^
90			3: }
91
92			SourceB (2:10)
93			1: type Foo {
94			2: field: Int
95			^
96			3: }
97			',
98			FormattedError::printError($error)
99			);
100			}
101			}
102

webonyx / graphql-php

Push — master ( 392b56...c3d69c )

testPrintsAnErrorWithNodesFromDifferentSources() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like