KnownArgumentNames::getVisitor() - Code Metrics - Inspection of "Merge pull request #518 from simPod/fix-internal-d..." - webonyx/graphql-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a01b08...b72ba3 )

by Vladimir

created 2019-07-13 14:12 UTC

KnownArgumentNames::getVisitor() B

↳ Parent: KnownArgumentNames

Complexity

Conditions	7
Paths	1

Size

Total Lines	51
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	35
CRAP Score	7

Importance

Changes

Metric	Value
eloc	36
dl	0
loc	51
ccs	35
cts	35
cp	1
rs	8.4106
c	0
b	0
f	0
cc	7
nc	1
nop	1
crap	7

How to fix Long Method

<?php

declare(strict_types=1);

namespace GraphQL\Validator\Rules;

use GraphQL\Error\Error;
use GraphQL\Language\AST\ArgumentNode;
use GraphQL\Language\AST\DirectiveNode;
use GraphQL\Language\AST\FieldNode;
use GraphQL\Language\AST\Node;
use GraphQL\Language\AST\NodeKind;
use GraphQL\Language\AST\NodeList;
use GraphQL\Utils\Utils;
use GraphQL\Validator\ValidationContext;
use function array_map;
use function count;
use function sprintf;

/**
 * Known argument names
 *
 * A GraphQL field is only valid if all supplied arguments are defined by
 * that field.
 */
class KnownArgumentNames extends ValidationRule
{
    public function getVisitor(ValidationContext $context)
    {
        return [
            NodeKind::ARGUMENT => static function (ArgumentNode $node, $key, $parent, $path, $ancestors) use ($context) {
                /** @var NodeList|Node[] $ancestors */
                $argDef = $context->getArgument();
                if ($argDef !== null) {
                    return;
                }

                $argumentOf = $ancestors[count($ancestors) - 1];
                if ($argumentOf instanceof FieldNode) {
                    $fieldDef   = $context->getFieldDef();
                    $parentType = $context->getParentType();
                    if ($fieldDef && $parentType) {

                        $context->reportError(new Error(
                            self::unknownArgMessage(
                                $node->name->value,
                                $fieldDef->name,
                                $parentType->name,
                                Utils::suggestionList(
                                    $node->name->value,
                                    array_map(
                                        static function ($arg) {
                                            return $arg->name;
                                        },
                                        $fieldDef->args
                                    )
                                )
                            ),
                            [$node]
                        ));
                    }
                } elseif ($argumentOf instanceof DirectiveNode) {
                    $directive = $context->getDirective();
                    if ($directive) {

                        $context->reportError(new Error(
                            self::unknownDirectiveArgMessage(
                                $node->name->value,
                                $directive->name,
                                Utils::suggestionList(
                                    $node->name->value,
                                    array_map(
                                        static function ($arg) {
                                            return $arg->name;
                                        },
                                        $directive->args
                                    )
                                )
                            ),
                            [$node]
                        ));
                    }
                }
            },
        ];
    }

    /**
     * @param string[] $suggestedArgs
     */
    public static function unknownArgMessage($argName, $fieldName, $typeName, array $suggestedArgs)
    {
        $message = sprintf('Unknown argument "%s" on field "%s" of type "%s".', $argName, $fieldName, $typeName);
        if (! empty($suggestedArgs)) {
            $message .= sprintf(' Did you mean %s?', Utils::quotedOrList($suggestedArgs));
        }

        return $message;
    }

    /**
     * @param string[] $suggestedArgs
     */
    public static function unknownDirectiveArgMessage($argName, $directiveName, array $suggestedArgs)
    {
        $message = sprintf('Unknown argument "%s" on directive "@%s".', $argName, $directiveName);
        if (! empty($suggestedArgs)) {
            $message .= sprintf(' Did you mean %s?', Utils::quotedOrList($suggestedArgs));
        }

        return $message;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace GraphQL\Validator\Rules;
6
7		use GraphQL\Error\Error;
8		use GraphQL\Language\AST\ArgumentNode;
9		use GraphQL\Language\AST\DirectiveNode;
10		use GraphQL\Language\AST\FieldNode;
11		use GraphQL\Language\AST\Node;
12		use GraphQL\Language\AST\NodeKind;
13		use GraphQL\Language\AST\NodeList;
14		use GraphQL\Utils\Utils;
15		use GraphQL\Validator\ValidationContext;
16		use function array_map;
17		use function count;
18		use function sprintf;
19
20		/**
21		* Known argument names
22		*
23		* A GraphQL field is only valid if all supplied arguments are defined by
24		* that field.
25		*/
26		class KnownArgumentNames extends ValidationRule
27		{
28	127	public function getVisitor(ValidationContext $context)
29		{
30		return [
31		NodeKind::ARGUMENT => static function (ArgumentNode $node, $key, $parent, $path, $ancestors) use ($context) {
32		/** @var NodeList\|Node[] $ancestors */
33	66	$argDef = $context->getArgument();
34	66	if ($argDef !== null) {
35	60	return;
36		}
37
38	7	$argumentOf = $ancestors[count($ancestors) - 1];
39	7	if ($argumentOf instanceof FieldNode) {
40	5	$fieldDef = $context->getFieldDef();
41	5	$parentType = $context->getParentType();
42	5	if ($fieldDef && $parentType) {
		0 ignored issues – show introduced 2018-10-22 19:29 UTC by Report Bug Copy Issue Report `$parentType` is of type `GraphQL\Type\Definition\Type`, thus it always evaluated to `true`. Loading history...
43	4	$context->reportError(new Error(
44	4	self::unknownArgMessage(
45	4	$node->name->value,
46	4	$fieldDef->name,
47	4	$parentType->name,
48	4	Utils::suggestionList(
49	4	$node->name->value,
50	4	array_map(
51		static function ($arg) {
52	4	return $arg->name;
53	4	},
54	4	$fieldDef->args
55		)
56		)
57		),
58	5	[$node]
59		));
60		}
61	2	} elseif ($argumentOf instanceof DirectiveNode) {
62	2	$directive = $context->getDirective();
63	2	if ($directive) {
		0 ignored issues – show introduced 2018-10-22 19:29 UTC by Report Bug Copy Issue Report `$directive` is of type `GraphQL\Type\Definition\Directive`, thus it always evaluated to `true`. Loading history...
64	2	$context->reportError(new Error(
65	2	self::unknownDirectiveArgMessage(
66	2	$node->name->value,
67	2	$directive->name,
68	2	Utils::suggestionList(
69	2	$node->name->value,
70	2	array_map(
71		static function ($arg) {
72	2	return $arg->name;
73	2	},
74	2	$directive->args
75		)
76		)
77		),
78	2	[$node]
79		));
80		}
81		}
82	127	},
83		];
84		}
85
86		/**
87		* @param string[] $suggestedArgs
88		*/
89	4	public static function unknownArgMessage($argName, $fieldName, $typeName, array $suggestedArgs)
90		{
91	4	$message = sprintf('Unknown argument "%s" on field "%s" of type "%s".', $argName, $fieldName, $typeName);
92	4	if (! empty($suggestedArgs)) {
93	1	$message .= sprintf(' Did you mean %s?', Utils::quotedOrList($suggestedArgs));
94		}
95
96	4	return $message;
97		}
98
99		/**
100		* @param string[] $suggestedArgs
101		*/
102	2	public static function unknownDirectiveArgMessage($argName, $directiveName, array $suggestedArgs)
103		{
104	2	$message = sprintf('Unknown argument "%s" on directive "@%s".', $argName, $directiveName);
105	2	if (! empty($suggestedArgs)) {
106	1	$message .= sprintf(' Did you mean %s?', Utils::quotedOrList($suggestedArgs));
107		}
108
109	2	return $message;
110		}
111		}
112

webonyx / graphql-php

Push — master ( a01b08...b72ba3 )

KnownArgumentNames::getVisitor() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like