webonyx /
graphql-php
| Conditions | 15 |
| Paths | 1 |
| Total Lines | 54 |
| Code Lines | 36 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 33 |
| CRAP Score | 15 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 18 | 133 | public function getVisitor(ValidationContext $context) |
|
| 19 | { |
||
| 20 | return [ |
||
| 21 | NodeKind::FIELD => [ |
||
| 22 | 'leave' => static function (FieldNode $fieldNode) use ($context) { |
||
| 23 | 133 | $fieldDef = $context->getFieldDef(); |
|
| 24 | |||
| 25 | 133 | if (! $fieldDef) { |
|
|
introduced
by
|
|||
| 26 | 9 | return Visitor::skipNode(); |
|
| 27 | } |
||
| 28 | 128 | $argNodes = $fieldNode->arguments ?: []; |
|
| 29 | |||
| 30 | 128 | $argNodeMap = []; |
|
| 31 | 128 | foreach ($argNodes as $argNode) { |
|
| 32 | 65 | $argNodeMap[$argNode->name->value] = $argNode; |
|
| 33 | } |
||
| 34 | 128 | foreach ($fieldDef->args as $argDef) { |
|
| 35 | 88 | $argNode = $argNodeMap[$argDef->name] ?? null; |
|
| 36 | 88 | if ($argNode || (! ($argDef->getType() instanceof NonNull)) || $argDef->defaultValueExists()) { |
|
| 37 | 86 | continue; |
|
| 38 | } |
||
| 39 | |||
| 40 | 4 | $context->reportError(new Error( |
|
| 41 | 4 | self::missingFieldArgMessage($fieldNode->name->value, $argDef->name, $argDef->getType()), |
|
| 42 | 4 | [$fieldNode] |
|
| 43 | )); |
||
| 44 | } |
||
| 45 | 133 | }, |
|
| 46 | ], |
||
| 47 | NodeKind::DIRECTIVE => [ |
||
| 48 | 'leave' => static function (DirectiveNode $directiveNode) use ($context) { |
||
| 49 | 3 | $directiveDef = $context->getDirective(); |
|
| 50 | 3 | if (! $directiveDef) { |
|
| 51 | 1 | return Visitor::skipNode(); |
|
| 52 | } |
||
| 53 | 2 | $argNodes = $directiveNode->arguments ?: []; |
|
| 54 | 2 | $argNodeMap = []; |
|
| 55 | 2 | foreach ($argNodes as $argNode) { |
|
| 56 | 1 | $argNodeMap[$argNode->name->value] = $argNodes; |
|
| 57 | } |
||
| 58 | |||
| 59 | 2 | foreach ($directiveDef->args as $argDef) { |
|
| 60 | 2 | $argNode = $argNodeMap[$argDef->name] ?? null; |
|
| 61 | 2 | if ($argNode || (! ($argDef->getType() instanceof NonNull)) || $argDef->defaultValueExists()) { |
|
| 62 | 1 | continue; |
|
| 63 | } |
||
| 64 | |||
| 65 | 1 | $context->reportError(new Error( |
|
| 66 | 1 | self::missingDirectiveArgMessage( |
|
| 67 | 1 | $directiveNode->name->value, |
|
| 68 | 1 | $argDef->name, |
|
| 69 | 1 | $argDef->getType() |
|
| 70 | ), |
||
| 71 | 1 | [$directiveNode] |
|
| 72 | )); |
||
| 99 |
Loading history...