GraphQL\Tests\Regression\Issue396Test

Complexity

Total Complexity

8

Size/Duplication

Total Lines	135
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testUnionResolveType()	0	67	4
A	testInterfaceResolveType()	0	64	4

<?php

declare(strict_types=1);

namespace GraphQL\Tests\Regression;

use GraphQL\GraphQL;
use GraphQL\Type\Definition\InterfaceType;
use GraphQL\Type\Definition\ObjectType;
use GraphQL\Type\Definition\ResolveInfo;
use GraphQL\Type\Definition\Type;
use GraphQL\Type\Definition\UnionType;
use GraphQL\Type\Schema;
use PHPUnit\Framework\TestCase;
use function stristr;

/**
 * @see https://github.com/webonyx/graphql-php/issues/396
 */
class Issue396Test extends TestCase
{
    public function testUnionResolveType()
    {
        $a = new ObjectType(['name' => 'A', 'fields' => ['name' => Type::string()]]);
        $b = new ObjectType(['name' => 'B', 'fields' => ['name' => Type::string()]]);
        $c = new ObjectType(['name' => 'C', 'fields' => ['name' => Type::string()]]);

        $log = [];

        $unionResult = new UnionType([
            'name' => 'UnionResult',
            'types' => [$a, $b, $c],
            'resolveType' => static function ($result, $root, ResolveInfo $info) use ($a, $b, $c, &$log) : Type {
                $log[] = [$result, $info->path];
                if (stristr($result['name'], 'A')) {
                    return $a;
                }
                if (stristr($result['name'], 'B')) {
                    return $b;
                }
                if (stristr($result['name'], 'C')) {
                    return $c;
                }

The function implicitly returns null when the if condition on line 41 is false. This is incompatible with the type-hinted return GraphQL\Type\Definition\Type. Consider adding a return statement or allowing null as return value.

            },
        ]);

        $exampleType = new ObjectType([
            'name' => 'Example',
            'fields' => [
                'field' => [
                    'type' => Type::nonNull(Type::listOf(Type::nonNull($unionResult))),
                    'resolve' => static function () : array {
                        return [
                            ['name' => 'A 1'],
                            ['name' => 'B 2'],
                            ['name' => 'C 3'],
                        ];
                    },
                ],
            ],
        ]);

        $schema = new Schema(['query' => $exampleType]);

        $query = '
            query {
                field {
                    ... on A {
                        name
                    }
                    ... on B {
                        name
                    }
                    ... on C {
                        name
                    }
                }
            }
        ';

        GraphQL::executeQuery($schema, $query);

        $expected = [
            [['name' => 'A 1'], ['field', 0]],
            [['name' => 'B 2'], ['field', 1]],
            [['name' => 'C 3'], ['field', 2]],
        ];
        self::assertEquals($expected, $log);
    }

    public function testInterfaceResolveType()
    {
        $log = [];

        $interfaceResult = new InterfaceType([
            'name' => 'InterfaceResult',
            'fields' => [
                'name' => Type::string(),
            ],
            'resolveType' => static function ($result, $root, ResolveInfo $info) use (&$a, &$b, &$c, &$log) : Type {
                $log[] = [$result, $info->path];
                if (stristr($result['name'], 'A')) {
                    return $a;
                }
                if (stristr($result['name'], 'B')) {
                    return $b;
                }
                if (stristr($result['name'], 'C')) {
                    return $c;
                }

The function implicitly returns null when the if condition on line 108 is false. This is incompatible with the type-hinted return GraphQL\Type\Definition\Type. Consider adding a return statement or allowing null as return value.

            },
        ]);

        $a = new ObjectType(['name' => 'A', 'fields' => ['name' => Type::string()], 'interfaces' => [$interfaceResult]]);
        $b = new ObjectType(['name' => 'B', 'fields' => ['name' => Type::string()], 'interfaces' => [$interfaceResult]]);
        $c = new ObjectType(['name' => 'C', 'fields' => ['name' => Type::string()], 'interfaces' => [$interfaceResult]]);

        $exampleType = new ObjectType([
            'name' => 'Example',
            'fields' => [
                'field' => [
                    'type' => Type::nonNull(Type::listOf(Type::nonNull($interfaceResult))),
                    'resolve' => static function () : array {
                        return [
                            ['name' => 'A 1'],
                            ['name' => 'B 2'],
                            ['name' => 'C 3'],
                        ];
                    },
                ],
            ],
        ]);

        $schema = new Schema([
            'query' => $exampleType,
            'types' => [$a, $b, $c],
        ]);

        $query = '
            query {
                field {
                    name
                }
            }
        ';

        GraphQL::executeQuery($schema, $query);

        $expected = [
            [['name' => 'A 1'], ['field', 0]],
            [['name' => 'B 2'], ['field', 1]],
            [['name' => 'C 3'], ['field', 2]],
        ];
        self::assertEquals($expected, $log);
    }
}