DateTime - Code Metrics - Inspection of "extend tests, correct bugs, comments, pgsql test" - webnet-fr/database-anonymizer - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 0e2cc1...e210b9 )

by Webnet

created 2019-02-22 14:00 UTC

DateTime A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Importance

Changes

Metric	Value
eloc	14
dl	0
loc	59
rs	10
c	0
b	0
f	0
wmc	3

2 Methods

Rating	Name	Duplication	Size	Complexity
A	generate()	0	3	1
A	__construct()	0	12	2

<?php

namespace WebnetFr\DatabaseAnonymizer\Generator;

use Faker\Provider\DateTime as FakerProviderDateTime;

/**
 * Random datetime.
 *
 * @author Vlad Riabchenko <[email protected]>
 */
class DateTime implements GeneratorInterface
{
    /**
     * @var FakerProviderDateTime
     */
    private $provider;

    /**
     * Generated datetime format acceptable by @see date().
     *
     * @var string
     */
    private $format;

    /**
     * In seconds relative to the beginning of unix epoch.
     * Defaults to -30 years.
     *
     * @var int
     */
    private $start;

    /**
     * In seconds relative to the beginning of unix epoch.
     * Defaults to current time.
     *
     * @var int
     */
    private $end;

    /**
     * @var string
     */
    private $timezone = null;

    /**
     * @param FakerProviderDateTime $provider
     * @param array $config
     */
    public function __construct(FakerProviderDateTime $provider, array $config)
    {
        $this->provider = $provider;

        $this->format = $config['format'] ?? false;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        if (!$this->format) {
            throw new \InvalidArgumentException("You must define 'format' for date generator.");
        }

        $this->start = $config['start'] ?? '-30 years';
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->end = $config['end'] ?? 'now';
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->timezone = $config['timezone'] ?? null;
    }

    /**
     * @inheritdoc
     */
    public function generate()
    {
        return $this->provider->dateTimeBetween($this->start, $this->end, $this->timezone)->format($this->format);
    }
}


1			<?php
2
3			namespace WebnetFr\DatabaseAnonymizer\Generator;
4
5			use Faker\Provider\DateTime as FakerProviderDateTime;
6
7			/**
8			* Random datetime.
9			*
10			* @author Vlad Riabchenko <[email protected]>
11			*/
12			class DateTime implements GeneratorInterface
13			{
14			/**
15			* @var FakerProviderDateTime
16			*/
17			private $provider;
18
19			/**
20			* Generated datetime format acceptable by @see date().
21			*
22			* @var string
23			*/
24			private $format;
25
26			/**
27			* In seconds relative to the beginning of unix epoch.
28			* Defaults to -30 years.
29			*
30			* @var int
31			*/
32			private $start;
33
34			/**
35			* In seconds relative to the beginning of unix epoch.
36			* Defaults to current time.
37			*
38			* @var int
39			*/
40			private $end;
41
42			/**
43			* @var string
44			*/
45			private $timezone = null;
46
47			/**
48			* @param FakerProviderDateTime $provider
49			* @param array $config
50			*/
51			public function __construct(FakerProviderDateTime $provider, array $config)
52			{
53			$this->provider = $provider;
54
55			$this->format = $config['format'] ?? false;
			0 ignored issues – show Documentation Bug introduced 2019-02-22 14:03 UTC by Report Bug Copy Issue Report It seems like `$config['format'] ?? false` can also be of type `false`. However, the property `$format` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
56			if (!$this->format) {
57			throw new \InvalidArgumentException("You must define 'format' for date generator.");
58			}
59
60			$this->start = $config['start'] ?? '-30 years';
			0 ignored issues – show Documentation Bug introduced 2019-02-22 14:03 UTC by Report Bug Copy Issue Report It seems like `$config['start'] ?? '-30 years'` can also be of type `string`. However, the property `$start` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
61			$this->end = $config['end'] ?? 'now';
			0 ignored issues – show Documentation Bug introduced 2019-02-22 14:03 UTC by Report Bug Copy Issue Report It seems like `$config['end'] ?? 'now'` can also be of type `string`. However, the property `$end` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
62			$this->timezone = $config['timezone'] ?? null;
63			}
64
65			/**
66			* @inheritdoc
67			*/
68			public function generate()
69			{
70			return $this->provider->dateTimeBetween($this->start, $this->end, $this->timezone)->format($this->format);
71			}
72			}
73

webnet-fr / database-anonymizer

Push — master ( 0e2cc1...e210b9 )

DateTime A

Complexity

Size/Duplication

Importance

2 Methods

Duplication Side-by-Side

Filter issues like