Webmozart\Json\JsonValidator

Complexity

Total Complexity

24

Size/Duplication

Total Lines	158
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

95%

Importance

Changes	9
Bugs	2	Features	3

4 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	10	5
D	validate()	0	42	10
A	assertSchemaValid()	0	21	4
B	loadSchema()	0	37	5

<?php

/*
 * This file is part of the Webmozart JSON package.
 *
 * (c) Bernhard Schussek <bschussek@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Webmozart\Json;

use JsonSchema\Exception\InvalidArgumentException;
use JsonSchema\Exception\ResourceNotFoundException;
use JsonSchema\RefResolver;
use JsonSchema\Uri\UriResolver;
use JsonSchema\Uri\UriRetriever;
use JsonSchema\Validator;
use Webmozart\PathUtil\Path;

/**
 * Validates decoded JSON values against a JSON schema.
 *
 * This class is a wrapper for {@link Validator} that adds exceptions and
 * validation of schema files. A few edge cases that are not handled by
 * {@link Validator} are handled by this class.
 *
 * @since  1.0
 *
 * @author Bernhard Schussek <bschussek@gmail.com>
 */
class JsonValidator
{
    /**
     * The schema used for validating schemas.
     *
     * @var object|null
     */
    private $metaSchema;

    /**
     * Validator instance used for validation.
     *
     * @var Validator
     */
    private $validator;

    /**
     * For fetching and resolving JSON schemas.
     *
     * @var RefResolver
     */
    private $refResolver;

    /**
     * JsonValidator constructor.
     *
     * @param Validator|null $validator JsonSchema\Validator instance to use.
     */
    public function __construct(Validator $validator = null, UriRetriever $uriRetriever = null, UriResolver $uriResolver = null)
    {
        $this->validator = $validator ?: new Validator();
        if(!interface_exists('JsonSchema\UriRetrieverInterface')) {
            // Remove when justinrainbow/json-schema dependency is ^2.0
            $this->refResolver = new RefResolver($uriRetriever);

The call to RefResolver::__construct() misses a required argument $uriResolver.

It seems like $uriRetriever defined by parameter $uriRetriever on line 61 can be null; however, JsonSchema\RefResolver::__construct() does not accept null, maybe add an additional type check?

        } else {
            $this->refResolver = new RefResolver($uriRetriever ?: new UriRetriever(), $uriResolver ?: new UriResolver());
        }
    }

    /**
     * Validates JSON data against a schema.
     *
     * The schema may be passed as file path or as object returned from
     * `json_decode($schemaFile)`.
     *
     * @param mixed              $data   The decoded JSON data.
     * @param string|object|null $schema The schema file or object. If `null`,
     *                                   the validator will look for a `$schema`
     *                                   property.
     *
     * @return string[] The errors found during validation. Returns an empty
     *                  array if no errors were found.
     *
     * @throws InvalidSchemaException If the schema is invalid.
     */
    public function validate($data, $schema = null)
    {
        if (null === $schema && isset($data->{'$schema'})) {
            $schema = $data->{'$schema'};
        }

        if (is_string($schema)) {
            $schema = $this->loadSchema($schema);
        } elseif (is_object($schema)) {
            $this->assertSchemaValid($schema);
        } else {
            throw new InvalidSchemaException(sprintf(
                'The schema must be given as string, object or in the "$schema" '.
                'property of the JSON data. Got: %s',
                is_object($schema) ? get_class($schema) : gettype($schema)
            ));
        }

        $this->validator->reset();

        try {
            $this->validator->check($data, $schema);
        } catch (InvalidArgumentException $e) {
            throw new InvalidSchemaException(sprintf(
                'The schema is invalid: %s',
                $e->getMessage()
            ), 0, $e);
        }

        $errors = array();

        if (!$this->validator->isValid()) {
            $errors = (array) $this->validator->getErrors();

            foreach ($errors as $key => $error) {
                $prefix = $error['property'] ? $error['property'].': ' : '';
                $errors[$key] = $prefix.$error['message'];
            }
        }

        return $errors;
    }

    private function assertSchemaValid($schema)
    {
        if (null === $this->metaSchema) {
            // The meta schema is obviously not validated. If we
            // validate it against itself, we have an endless recursion
            $this->metaSchema = json_decode(file_get_contents(__DIR__.'/../res/meta-schema.json'));
        }

        if ($schema === $this->metaSchema) {
            return;
        }

        $errors = $this->validate($schema, $this->metaSchema);

        if (count($errors) > 0) {
            throw new InvalidSchemaException(sprintf(
                "The schema is invalid:\n%s",
                implode("\n", $errors)
            ));
        }
    }

    private function loadSchema($file)

The return type could not be reliably inferred; please add a @return annotation.

    {
        // Retrieve schema and cache in UriRetriever
        $file = Path::canonicalize($file);

        // Add file:// scheme if necessary
        if (false === strpos($file, '://')) {
            $file = 'file://'.$file;
        }

        try {
            if(!interface_exists('JsonSchema\UriRetrieverInterface')) {
                // Remove when justinrainbow/json-schema dependency is ^2.0
                $schema = $this->refResolver->getUriRetriever()->retrieve($file);

The method getUriRetriever() does not seem to exist on object<JsonSchema\RefResolver>.

                $this->refResolver->resolve($schema, $file);

The call to RefResolver::resolve() has too many arguments starting with $file.

            } else {
                $schema = $this->refResolver->resolve($file);
            }
        } catch (ResourceNotFoundException $e) {
            throw new InvalidSchemaException(sprintf(
                'The schema %s does not exist.',
                $file
            ), 0, $e);
        }

        try {
            $this->assertSchemaValid($schema);
        } catch (InvalidSchemaException $e) {
            throw new InvalidSchemaException(sprintf(
                'An error occurred while loading the schema %s: %s',
                $file,
                $e->getMessage()
            ), 0, $e);
        }

        return $schema;
    }
}