Webmozart\Console\IO\InputStream\StreamInputStream

Complexity

Total Complexity

17

Size/Duplication

Total Lines	89
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

84.38%

Importance

Changes	2
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
B	read()	0	18	6
A	isClosed()	0	4	1
C	readLine()	0	22	7
A	close()	0	7	2

<?php

/*
 * This file is part of the webmozart/console package.
 *
 * (c) Bernhard Schussek <bschussek@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Webmozart\Console\IO\InputStream;

use Webmozart\Assert\Assert;
use Webmozart\Console\Api\IO\InputStream;
use Webmozart\Console\Api\IO\IOException;

/**
 * An input stream that reads from a PHP stream.
 *
 * @since  1.0
 *
 * @author Bernhard Schussek <bschussek@gmail.com>
 */
class StreamInputStream implements InputStream
{
    /**
     * @var resource
     */
    private $stream;

    /**
     * Creates the input.
     *
     * @param resource $stream A stream resource.
     */
    public function __construct($stream)
    {
        Assert::resource($stream, 'stream');

        $this->stream = $stream;

        // Not all streams are seekable
        @rewind($this->stream);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

    }

    /**
     * {@inheritdoc}
     */
    public function read($length)
    {
        if (null === $this->stream) {
            throw new IOException('Cannot read from a closed input.');
        }

        if (feof($this->stream)) {
            return null;
        }

        $data = fread($this->stream, $length);

        if (false === $data && !feof($this->stream)) {
            throw new IOException('Could not read stream.');
        }

        return $data ?: null;
    }

    /**
     * {@inheritdoc}
     */
    public function readLine($length = null)
    {
        if (null === $this->stream) {
            throw new IOException('Cannot read from a closed input.');
        }

        if (feof($this->stream)) {
            return null;
        }

        if (null !== $length) {
            $data = fgets($this->stream, $length);
        } else {
            $data = fgets($this->stream);
        }

        if (false === $data && !feof($this->stream)) {
            throw new IOException('Could not read stream.');
        }

        return $data ?: null;
    }

    /**
     * {@inheritdoc}
     */
    public function close()
    {
        if ($this->stream) {
            @fclose($this->stream);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            $this->stream = null;
        }
    }

    /**
     * {@inheritdoc}
     */
    public function isClosed()
    {
        return null === $this->stream;
    }
}