Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
30 | class HelpHandler extends DelegatingHandler |
||
31 | { |
||
32 | /** |
||
33 | * @var ExecutableFinder |
||
34 | */ |
||
35 | private $executableFinder; |
||
36 | |||
37 | /** |
||
38 | * @var ProcessLauncher |
||
39 | */ |
||
40 | private $processLauncher; |
||
41 | |||
42 | /** |
||
43 | * @var string |
||
44 | */ |
||
45 | private $manBinary; |
||
46 | |||
47 | /** |
||
48 | * @var string |
||
49 | */ |
||
50 | private $manDir; |
||
51 | |||
52 | /** |
||
53 | * @var string |
||
54 | */ |
||
55 | private $lessBinary; |
||
56 | |||
57 | /** |
||
58 | * @var string |
||
59 | */ |
||
60 | private $asciiDocDir; |
||
61 | |||
62 | /** |
||
63 | * @var string |
||
64 | */ |
||
65 | private $applicationPage; |
||
66 | |||
67 | /** |
||
68 | * @var string |
||
69 | */ |
||
70 | private $commandPagePrefix; |
||
71 | |||
72 | /** |
||
73 | * Creates the handler. |
||
74 | * |
||
75 | * @param ExecutableFinder $executableFinder The finder used to find the |
||
|
|||
76 | * "less"/"man" binaries. |
||
77 | * @param ProcessLauncher $processLauncher The launcher for executing the |
||
78 | * "less"/"man" binaries. |
||
79 | */ |
||
80 | 52 | public function __construct(ExecutableFinder $executableFinder = null, ProcessLauncher $processLauncher = null) |
|
94 | |||
95 | /** |
||
96 | * Callback for creating the "--ascii-doc" handler. |
||
97 | * |
||
98 | * @param Args $args The console arguments. |
||
99 | * @param IO $io The I/O. |
||
100 | * @param Command $command The handled command. |
||
101 | * |
||
102 | * @return HelpAsciiDocHandler The created handler. |
||
103 | */ |
||
104 | 11 | View Code Duplication | public function createAsciiDocHandler(Args $args, IO $io, Command $command) |
113 | |||
114 | /** |
||
115 | * Callback for creating the "--json" handler. |
||
116 | * |
||
117 | * @return HelpJsonHandler The created handler. |
||
118 | */ |
||
119 | 4 | public function createJsonHandler() |
|
123 | |||
124 | /** |
||
125 | * Callback for creating the "--man" handler. |
||
126 | * |
||
127 | * @param Args $args The console arguments. |
||
128 | * @param IO $io The I/O. |
||
129 | * @param Command $command The handled command. |
||
130 | * |
||
131 | * @return HelpManHandler The created handler. |
||
132 | */ |
||
133 | 13 | View Code Duplication | public function createManHandler(Args $args, IO $io, Command $command) |
142 | |||
143 | /** |
||
144 | * Callback for creating the "--text" handler. |
||
145 | * |
||
146 | * @return HelpTextHandler The created handler. |
||
147 | */ |
||
148 | 20 | public function createTextHandler() |
|
152 | |||
153 | /** |
||
154 | * Callback for creating the "--xml" handler. |
||
155 | * |
||
156 | * @return HelpXmlHandler The created handler. |
||
157 | */ |
||
158 | 4 | public function createXmlHandler() |
|
162 | |||
163 | /** |
||
164 | * Callback for selecting the handler that should be run. |
||
165 | * |
||
166 | * @param Args $args The console arguments. |
||
167 | * @param IO $io The I/O. |
||
168 | * @param Command $command The handled command. |
||
169 | * |
||
170 | * @return string The name of the handler to run. |
||
171 | */ |
||
172 | 52 | public function getHandlerToRun(Args $args, IO $io, Command $command) |
|
173 | { |
||
174 | 52 | $rawArgs = $args->getRawArgs(); |
|
175 | |||
176 | // The raw arguments should always be available, but check anyway |
||
177 | 52 | if (!$rawArgs) { |
|
178 | return 'text'; |
||
179 | } |
||
180 | |||
181 | // If "-h" is given, always print the short text usage |
||
182 | 52 | if ($rawArgs->hasToken('-h')) { |
|
183 | 7 | return 'text'; |
|
184 | } |
||
185 | |||
186 | // Check if any of the options is set |
||
187 | 45 | foreach ($this->getRegisteredNames() as $handlerName) { |
|
188 | 45 | if ($rawArgs->hasToken('--'.$handlerName)) { |
|
189 | 45 | return $handlerName; |
|
190 | } |
||
191 | } |
||
192 | |||
193 | // No format option is set, "-h" is not set |
||
194 | // If a command is given or if "--help" is set, display the manual |
||
195 | 17 | if ($rawArgs->hasToken('--help')) { |
|
196 | // Return "man" if the binary is available and the man page exists |
||
197 | // The process launcher must be supported on the system |
||
198 | 14 | $manPage = $this->getManPage($command->getApplication(), $args); |
|
199 | |||
200 | 14 | if (file_exists($manPage) && $this->processLauncher->isSupported()) { |
|
201 | 6 | if (!$this->manBinary) { |
|
202 | 6 | $this->manBinary = $this->executableFinder->find('man'); |
|
203 | } |
||
204 | |||
205 | 6 | if ($this->manBinary) { |
|
206 | 5 | return 'man'; |
|
207 | } |
||
208 | } |
||
209 | |||
210 | // Return "ascii-doc" if the AsciiDoc page exists |
||
211 | 9 | $asciiDocPage = $this->getAsciiDocPage($command->getApplication(), $args); |
|
212 | |||
213 | 9 | if (file_exists($asciiDocPage)) { |
|
214 | 3 | return 'ascii-doc'; |
|
215 | } |
||
216 | } |
||
217 | |||
218 | // No command, no option -> display command list as text |
||
219 | 9 | return 'text'; |
|
220 | } |
||
221 | |||
222 | /** |
||
223 | * Returns the "man" binary used to display the man pages. |
||
224 | * |
||
225 | * @return string The "man" binary or `null` if the binary is auto-detected. |
||
226 | */ |
||
227 | public function getManBinary() |
||
231 | |||
232 | /** |
||
233 | * Sets the "man" binary used to display the AsciiDoc pages. |
||
234 | * |
||
235 | * @param string $manBinary The "man" binary to use. |
||
236 | */ |
||
237 | public function setManBinary($manBinary) |
||
238 | { |
||
239 | if (null !== $manBinary) { |
||
240 | Assert::string($manBinary, 'The man binary must be a string or null. Got: %s'); |
||
241 | Assert::notEmpty($manBinary, 'The man binary must not be empty.'); |
||
242 | } |
||
243 | |||
244 | $this->manBinary = $manBinary; |
||
245 | } |
||
246 | |||
247 | /** |
||
248 | * Returns the "less" binary used to display the AsciiDoc pages. |
||
249 | * |
||
250 | * @return string The "less" binary or `null` if the binary is auto-detected. |
||
251 | */ |
||
252 | public function getLessBinary() |
||
256 | |||
257 | /** |
||
258 | * Sets the "less" binary used to display the AsciiDoc pages. |
||
259 | * |
||
260 | * @param string $lessBinary The "less" binary to use. |
||
261 | */ |
||
262 | View Code Duplication | public function setLessBinary($lessBinary) |
|
263 | { |
||
264 | if (null !== $lessBinary) { |
||
265 | Assert::string($lessBinary, 'The less binary must be a string or null. Got: %s'); |
||
266 | Assert::notEmpty($lessBinary, 'The less binary must not be empty.'); |
||
267 | } |
||
268 | |||
269 | $this->lessBinary = $lessBinary; |
||
270 | } |
||
271 | |||
272 | /** |
||
273 | * Returns the directory containing the man pages. |
||
274 | * |
||
275 | * @return string The directory that contains the man pages. |
||
276 | */ |
||
277 | public function getManDir() |
||
281 | |||
282 | /** |
||
283 | * Sets the directory containing the man pages. |
||
284 | * |
||
285 | * @param string $dir The directory that contains the man pages. |
||
286 | */ |
||
287 | 41 | public function setManDir($dir) |
|
293 | |||
294 | /** |
||
295 | * Returns the directory containing the AsciiDoc pages. |
||
296 | * |
||
297 | * @return string The directory that contains the AsciiDoc pages. |
||
298 | */ |
||
299 | public function getAsciiDocDir() |
||
303 | |||
304 | /** |
||
305 | * Sets the directory containing the AsciiDoc pages. |
||
306 | * |
||
307 | * @param string $dir The directory that contains the AsciiDoc pages. |
||
308 | */ |
||
309 | 41 | public function setAsciiDocDir($dir) |
|
315 | |||
316 | /** |
||
317 | * Returns the name of the file displayed when the application help is |
||
318 | * shown with less/man. |
||
319 | * |
||
320 | * @return string The application page. |
||
321 | */ |
||
322 | public function getApplicationPage() |
||
326 | |||
327 | /** |
||
328 | * Sets the name of the file displayed when the application help is shown |
||
329 | * with less/man. |
||
330 | * |
||
331 | * @param string $page The application page. |
||
332 | */ |
||
333 | 7 | View Code Duplication | public function setApplicationPage($page) |
334 | { |
||
335 | 7 | if (null !== $page) { |
|
336 | 7 | Assert::string($page, 'The application page must be a string or null. Got: %s'); |
|
337 | 7 | Assert::notEmpty($page, 'The application page must not be empty.'); |
|
338 | } |
||
339 | |||
340 | 7 | $this->applicationPage = $page; |
|
341 | 7 | } |
|
342 | |||
343 | /** |
||
344 | * Returns the prefix of the files displayed when a command help is shown |
||
345 | * with less/man. |
||
346 | * |
||
347 | * @return string The page prefix. |
||
348 | */ |
||
349 | public function getCommandPagePrefix() |
||
353 | |||
354 | /** |
||
355 | * Sets the prefix of the files displayed when a command help is shown with |
||
356 | * less/man. |
||
357 | * |
||
358 | * @param string $prefix The page prefix. |
||
359 | */ |
||
360 | 5 | public function setCommandPagePrefix($prefix) |
|
364 | |||
365 | 17 | private function getAsciiDocPage(Application $application, Args $args) |
|
369 | |||
370 | 22 | private function getManPage(Application $application, Args $args) |
|
374 | |||
375 | 30 | private function getPageName(Application $application, Args $args) |
|
389 | } |
||
390 |
This check looks for
@param
annotations where the type inferred by our type inference engine differs from the declared type.It makes a suggestion as to what type it considers more descriptive.
Most often this is a case of a parameter that can be null in addition to its declared types.