NameVersion::render() - Code Metrics - webmozart/console - Measure and Improve Code Quality continuously with Scrutinizer

NameVersion::render() A
last analyzed 2016-08-15 15:54 UTC

↳ Parent: NameVersion

Complexity

Conditions	4
Paths	3

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	12
ccs	8
cts	8
cp	1
rs	9.2
cc	4
eloc	8
nc	3
nop	2
crap	4

<?php

/*
 * This file is part of the webmozart/console package.
 *
 * (c) Bernhard Schussek <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Webmozart\Console\UI\Component;

use Webmozart\Console\Api\Config\ApplicationConfig;
use Webmozart\Console\Api\IO\IO;
use Webmozart\Console\UI\Component;

/**
 * Renders the name and version of an application.
 *
 * @since  1.0
 *
 * @author Bernhard Schussek <[email protected]>
 */
class NameVersion implements Component
{
    private $config;

    /**
     * Creates the renderer.
     *
     * @param ApplicationConfig $config The application configuration.
     */
    public function __construct(ApplicationConfig $config)
    {
        $this->config = $config;
    }

    /**
     * Renders the name and version.
     *
     * @param IO  $io          The I/O.
     * @param int $indentation The number of spaces to indent.
     */
    public function render(IO $io, $indentation = 0)
    {
        if ($this->config->getDisplayName() && $this->config->getVersion()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $paragraph = new Paragraph("{$this->config->getDisplayName()} version <c1>{$this->config->getVersion()}</c1>");
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        } elseif ($this->config->getDisplayName()) {
            $paragraph = new Paragraph("{$this->config->getDisplayName()}");
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        } else {
            $paragraph = new Paragraph('Console Tool');
        }

        $paragraph->render($io, $indentation);
    }
}


1		<?php
2
3		/*
4		* This file is part of the webmozart/console package.
5		*
6		* (c) Bernhard Schussek <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Webmozart\Console\UI\Component;
13
14		use Webmozart\Console\Api\Config\ApplicationConfig;
15		use Webmozart\Console\Api\IO\IO;
16		use Webmozart\Console\UI\Component;
17
18		/**
19		* Renders the name and version of an application.
20		*
21		* @since 1.0
22		*
23		* @author Bernhard Schussek <[email protected]>
24		*/
25		class NameVersion implements Component
26		{
27		private $config;
28
29		/**
30		* Creates the renderer.
31		*
32		* @param ApplicationConfig $config The application configuration.
33		*/
34	23	public function __construct(ApplicationConfig $config)
35		{
36	23	$this->config = $config;
37	23	}
38
39		/**
40		* Renders the name and version.
41		*
42		* @param IO $io The I/O.
43		* @param int $indentation The number of spaces to indent.
44		*/
45	23	public function render(IO $io, $indentation = 0)
46		{
47	23	if ($this->config->getDisplayName() && $this->config->getVersion()) {
		0 ignored issues – show Bug Best Practice introduced 2015-12-16 14:17 UTC by Report Bug Copy Issue Report The expression `$this->config->getDisplayName()` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
48	11	$paragraph = new Paragraph("{$this->config->getDisplayName()} version <c1>{$this->config->getVersion()}</c1>");
		0 ignored issues – show Coding Style Best Practice introduced 2015-12-16 14:17 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$this` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
49	12	} elseif ($this->config->getDisplayName()) {
50	3	$paragraph = new Paragraph("{$this->config->getDisplayName()}");
		0 ignored issues – show Coding Style Best Practice introduced 2015-12-16 14:17 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$this` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
51		} else {
52	9	$paragraph = new Paragraph('Console Tool');
53		}
54
55	23	$paragraph->render($io, $indentation);
56	23	}
57		}
58

webmozart / console

NameVersion::render() A last analyzed 2016-08-15 15:54 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

NameVersion::render() A
last analyzed 2016-08-15 15:54 UTC