Ext.define(ꞌShopware.apps.WbmTemplateManager.view.main.Listꞌ).getActionColumnItems - Code Metrics - Inspection of "get Bare theme templates for base syntax compariso..." - webmatch/WbmTemplateManager - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( f4d769...4483e5 )

by David

created 2017-04-05 18:06 UTC

A

↳ Parent: Ext.define(ꞌShopware.apps.WbmTemplateManager.view.main.Listꞌ).getActionColumnItems

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0
cc	2
nc	2
nop	3

/**
 * Template Manager
 * Copyright (c) Webmatch GmbH
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 */

//{namespace name=backend/plugins/wbm/templatemanager}
//
Ext.define('Shopware.apps.WbmTemplateManager.view.main.List', {

    extend:'Ext.grid.Panel',
    border: false,
    alias:'widget.template-manager-list',
    region:'center',
    autoScroll:true,
    listeners: {
        itemclick: function(dv, record, item, rowIndex, e) {

            var me = this;
            me.fireEvent('openTemplateDetail', me, rowIndex);
        }
    },
    initComponent:function () {
        var me = this;
        me.columns = me.getColumns();
        me.dockedItems = [
            {
                xtype: 'toolbar',
                dock: 'top',
                cls: 'shopware-toolbar',
                ui: 'shopware-ui',
                items: me.getButtons()
            }
        ];
        me.callParent(arguments);
    },
    getColumns:function () {
        var me = this;
        return [
            {
                header: '{s name="nameColumnHeader"}Name{/s}',
                dataIndex:'name',
                flex:1,
                renderer:function(value, metaData, record) {
                    if (record.get('custom') != 1) {
                        return '<span style="color:#999">' + value + '</span>';
                    } else {
                        return value;
                    }
                }
            },
            {
                xtype:'actioncolumn',
                width:30,
                items:me.getActionColumnItems()
            }
        ];
    },
    getButtons : function()
    {
        var me = this;
            return [
                {
                    text    : '{s name="add"}Hinzufügen{/s}',
                    scope   : me,
                    iconCls : 'sprite-plus-circle-frame',
                    action : 'addTemplate'
                }
            ];
    },
    getActionColumnItems: function () {
        var me = this;
        return [
            {
                iconCls:'x-action-col-icon sprite-minus-circle-frame',
                cls:'duplicateColumn',
                tooltip:'{s name="delete"}Löschen{/s}',
                getClass: function(value, metadata, record) {
                    if (record.get("custom") != 1) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
                        return 'x-hidden';
                    }
                },
                handler:function (view, rowIndex, colIndex, item) {
                    me.fireEvent('deleteTemplate', view, rowIndex, colIndex, item);
                }
            }
        ];
    }
});


1			/**
2			* Template Manager
3			* Copyright (c) Webmatch GmbH
4			*
5			* This program is free software: you can redistribute it and/or modify
6			* it under the terms of the GNU General Public License as published by
7			* the Free Software Foundation, either version 3 of the License, or
8			* (at your option) any later version.
9			*
10			* This program is distributed in the hope that it will be useful,
11			* but WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13			* GNU General Public License for more details.
14			*/
15
16			//{namespace name=backend/plugins/wbm/templatemanager}
17			//
18			Ext.define('Shopware.apps.WbmTemplateManager.view.main.List', {
			0 ignored issues – show Bug introduced 2017-04-04 14:47 UTC by Report Bug Copy Issue Report The variable `Ext` seems to be never declared. If this is a global, consider adding a `/** global: Ext */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
19			extend:'Ext.grid.Panel',
20			border: false,
21			alias:'widget.template-manager-list',
22			region:'center',
23			autoScroll:true,
24			listeners: {
25			itemclick: function(dv, record, item, rowIndex, e) {
			0 ignored issues – show Unused Code introduced 2017-04-04 14:47 UTC by Report Bug Copy Issue Report The parameter `e` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
26			var me = this;
27			me.fireEvent('openTemplateDetail', me, rowIndex);
28			}
29			},
30			initComponent:function () {
31			var me = this;
32			me.columns = me.getColumns();
33			me.dockedItems = [
34			{
35			xtype: 'toolbar',
36			dock: 'top',
37			cls: 'shopware-toolbar',
38			ui: 'shopware-ui',
39			items: me.getButtons()
40			}
41			];
42			me.callParent(arguments);
43			},
44			getColumns:function () {
45			var me = this;
46			return [
47			{
48			header: '{s name="nameColumnHeader"}Name{/s}',
49			dataIndex:'name',
50			flex:1,
51			renderer:function(value, metaData, record) {
52			if (record.get('custom') != 1) {
53			return '<span style="color:#999">' + value + '</span>';
54			} else {
55			return value;
56			}
57			}
58			},
59			{
60			xtype:'actioncolumn',
61			width:30,
62			items:me.getActionColumnItems()
63			}
64			];
65			},
66			getButtons : function()
67			{
68			var me = this;
69			return [
70			{
71			text : '{s name="add"}Hinzufügen{/s}',
72			scope : me,
73			iconCls : 'sprite-plus-circle-frame',
74			action : 'addTemplate'
75			}
76			];
77			},
78			getActionColumnItems: function () {
79			var me = this;
80			return [
81			{
82			iconCls:'x-action-col-icon sprite-minus-circle-frame',
83			cls:'duplicateColumn',
84			tooltip:'{s name="delete"}Löschen{/s}',
85			getClass: function(value, metadata, record) {
86			if (record.get("custom") != 1) {
			0 ignored issues – show Complexity Best Practice introduced 2017-04-05 18:08 UTC by Report Bug Copy Issue Report There is no return statement if `record.get("custom") != 1` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
87			return 'x-hidden';
88			}
89			},
90			handler:function (view, rowIndex, colIndex, item) {
91			me.fireEvent('deleteTemplate', view, rowIndex, colIndex, item);
92			}
93			}
94			];
95			}
96			});
97

webmatch / WbmTemplateManager

Push — master ( f4d769...4483e5 )

A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like