WebMarketingROI\OptimizelyPHP\Resource\v2\InPageEventConfig

Complexity

Total Complexity

8

Size/Duplication

Total Lines	51
Duplicated Lines	29.41 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	3
A	toArray()	15	15	3
A	getSelector()	0	4	1
A	setSelector()	0	4	1

<?php
/**
 * @author Oleg Krivtsov <oleg@webmarketingroi.com.au>
 * @date 09 May 2017
 * @copyright (c) 2017, Web Marketing ROI
 */
namespace WebMarketingROI\OptimizelyPHP\Resource\v2;

use WebMarketingROI\OptimizelyPHP\Exception;

/**
 * Optimizely InPage config.
 */
class InPageEventConfig
{    

The opening class brace should be on a newline by itself.

    /**
     * CSS selector for the page element(s) that trigger an Event
     * @var string 
     */
    private $selector;
    
    /**
     * Constructor.
     */
    public function __construct($options = array())
    {
        foreach ($options as $name=>$value) {
            switch ($name) {                
                case 'selector': $this->setSelector($value); break;

The case body in a switch statement must start on the line following the statement.

Terminating statement must be on a line by itself

                default:
                    throw new Exception('Unknown option found in the InPageConfig entity: ' . $name);
            }
        }
    }
    
    /**
     * Returns this object as array.
     */
    public function toArray()

This method seems to be duplicated in your project.

    {
        $options = array(            
            'selector' => $this->getSelector(),            
        );
        
        // Remove options with empty values
        $cleanedOptions = array();
        foreach ($options as $name=>$value) {
            if ($value!==null)
                $cleanedOptions[$name] = $value;
        }
        
        return $cleanedOptions;
    }
    
    public function getSelector()
    {
        return $this->selector;
    }
    
    public function setSelector($selector)
    {
        $this->selector = $selector;
    }        
}