Experiment::__construct() - Code Metrics - Inspection of "Improved README.md" - webmarketingroi/optimizely-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 6fdb58...dee5cf )

by Oleg

created 2016-10-19 03:45 UTC

Experiment::__construct() D

↳ Parent: Experiment

Complexity

Conditions	21
Paths	21

Size

Total Lines	46
Code Lines	36

Duplication

Lines	16
Ratio	34.78 %

Code Coverage

Tests	35
CRAP Score	21

Importance

Changes

Metric	Value
cc	21
eloc	36
nc	21
nop	1
dl	16
loc	46
ccs	35
cts	35
cp	1
crap	21
rs	4.8366
c	0
b	0
f	0

How to fix Complexity

<?php
/**
 * @author Oleg Krivtsov <[email protected]>
 * @date 05 October 2016
 * @copyright (c) 2016, Web Marketing ROI
 */
namespace WebMarketingROI\OptimizelyPHP\Resource\v2;

use WebMarketingROI\OptimizelyPHP\Resource\v2\Schedule;
use WebMarketingROI\OptimizelyPHP\Resource\v2\Variation;
use WebMarketingROI\OptimizelyPHP\Resource\v2\Change;
use WebMarketingROI\OptimizelyPHP\Resource\v2\Metric;

/**
 * An Optimizely experiment.
 */
class Experiment
{
    /**
     * The project the Experiment is in
     * @var integer
     */
    private $projectId;
    
    /**
     * List of IDs of all audiences the Experiment is targeted at
     * @var array[integer] 
     */
    private $audienceIds;
    
    /**
     * The ID for the Campaign that the Experiment is in
     * @var integer 
     */
    private $campaignId;
    
    /**
     * Experiment-level changes that will run before all Variations. Typically 
     * this is custom CSS or custom JavaScript.
     * @var array[Change] 
     */
    private $changes;
    
    /**
     * The time the experiment was initially created
     * @var string 
     */
    private $created;
    
    /**
     * The description or hypothesis for an Experiment
     * @var string 
     */
    private $description;
    
    /**
     * Percentage expressed as a number from 0-10000 to hold back from being 
     * included in the experiment
     * @var integer 
     */
    private $holdback;
    
    /**
     * Unique string identifier for this experiment within the project.
     * @var string
     */
    private $key;
    
    /**
     * The last time the experiment was modified
     * @var string 
     */
    private $lastModified;
    
    /**
     * An ordered list of metrics to track for the experiment
     * @var array[Metric] 
     */
    private $metrics;
    
    /**
     * Name of the Experiment
     * @var string 
     */
    private $name;
    
    /**
     * The last time the experiment was modified
     * @var Schedule 
     */
    private $schedule;
    
    /**
     * Current state of the experiment. Can be 'active', 'paused' or 'archived'.
     * @var string 
     */
    private $status;
    
    /**
     * A list of Variations that each define an experience to show in the context 
     * of the Experiment for the purpose of comparison against each other
     * @var array[Variation]
     */
    private $variations = array();
    
    /**
     * The unique identifier for the Experiment
     * @var integer 
     */
    private $id;
    
    /**
     * Whether or not the Experiment is a classic Experiment
     * @var boolean
     */
    private $isClassic;
    
    /**
     * Constructor.
     */
    public function __construct($options = array())
    {
        foreach ($options as $name=>$value) {
            switch ($name) {
                case 'project_id': $this->setProjectId($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'audience_ids': $this->setAudienceIds($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'campaign_id': $this->setCampaignId($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'changes': {
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    $changes = array();
                    foreach ($value as $changeInfo) {
                        $changes[] = new Change($changeInfo);
                    }
                    $this->setChanges($changes); 
                    break;
                }
                case 'created': $this->setCreated($value); break;    
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'description': $this->setDescription($value); break;    
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'holdback': $this->setHoldback($value); break;    
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'key': $this->setKey($value); break;    
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'last_modified': $this->setLastModified($value); break;    
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'metrics': {
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    $metrics = array();
                    foreach ($value as $metricInfo) {
                        $metrics[] = new Metric($metricInfo);
                    }
                    $this->setMetrics($metrics); 
                    break;    
                }
                case 'name': $this->setName($value); break;    
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'schedule': $this->setSchedule(new Schedule($value)); break;    
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'status': $this->setStatus($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'variations': {
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    $variations = array();
                    foreach ($value as $variationInfo) {
                        $variations[] = new Variation($variationInfo);
                    }
                    $this->setVariations($variations); 
                    break;
                }
                case 'id': $this->setId($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'is_classic': $this->setIsClassic($value); break;                
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                default:
                    throw new \Exception('Unknown option: ' . $name);
            }
        }
    }
    
    /**
     * Returns this object as array.
     */
    public function toArray()
    {
        $options = array(
            'project_id' => $this->getProjectId(),
            'audience_ids' => $this->getAudienceIds(),
            'campaign_id' => $this->getCampaignId(),
            'changes' => array(),
            'created' => $this->getCreated(),
            'description' => $this->getDescription(),
            'holdback' => $this->getHoldback(),
            'key' => $this->getKey(),
            'last_modified' => $this->getLastModified(),
            'metrics' => array(),
            'name' => $this->getName(),
            'schedule' => $this->getSchedule()?$this->getSchedule()->toArray():null,
            'status' => $this->getStatus(),
            'variations' => array(),
            'id' => $this->getId(),
            'is_classic' => $this->getIsClassic(),
        );
        
        foreach ($this->getChanges() as $change) {
            $options['changes'][] = $change->toArray();
        }
        
        foreach ($this->getMetrics() as $metric) {
            $options['metrics'][] = $metric->toArray();
        }
        
        foreach ($this->getVariations() as $variation) {
            $options['variations'][] = $variation->toArray();
        }
        
        // Remove options with empty values
        $cleanedOptions = array();
        foreach ($options as $name=>$value) {
            if ($value!==null)
                $cleanedOptions[$name] = $value;
        }
        
        return $cleanedOptions;
    }
    
    public function getProjectId()
    {
        return $this->projectId;
    }
    
    public function setProjectId($projectId)
    {
        $this->projectId = $projectId;
    }
    
    public function getAudienceIds()
    {
        return $this->audienceIds;
    }
    
    public function setAudienceIds($audienceIds)
    {
        $this->audienceIds = $audienceIds;
    }
    
    public function getCampaignId()
    {
        return $this->campaignId;
    }
    
    public function setCampaignId($campaignId)
    {
        $this->campaignId = $campaignId;
    }
    
    public function getChanges()
    {
        return $this->changes;
    }
    
    public function setChanges($changes)
    {
        $this->changes = $changes;
    }
    
    public function getCreated()
    {
        return $this->created;
    }
    
    public function setCreated($created)
    {
        $this->created = $created;
    }
    
    public function getDescription()
    {
        return $this->description;
    }
    
    public function setDescription($description)
    {
        $this->description = $description;
    }
    
    public function getHoldback()
    {
        return $this->holdback;
    }
    
    public function setHoldback($holdback)
    {
        $this->holdback = $holdback;
    }
    
    public function getKey()
    {
        return $this->key;
    }
    
    public function setKey($key)
    {
        $this->key = $key;
    }
    
    public function getLastModified()
    {
        return $this->lastModified;
    }
    
    public function setLastModified($lastModified)
    {
        $this->lastModified = $lastModified;
    }
    
    public function getMetrics()
    {
        return $this->metrics;
    }
    
    public function setMetrics($metrics)
    {
        $this->metrics = $metrics;
    }
    
    public function getName()
    {
        return $this->name;
    }
    
    public function setName($name)
    {
        $this->name = $name;
    }
    
    public function getSchedule()
    {
        return $this->schedule;
    }
    
    public function setSchedule($schedule)
    {
        $this->schedule = $schedule;
    }
    
    public function getStatus()
    {
        return $this->status;
    }
    
    public function setStatus($status)
    {
        $this->status = $status;
    }
    
    public function getVariations()
    {
        return $this->variations;
    }
    
    public function setVariations($variations)
    {
        $this->variations = $variations;
    }
    
    public function getId()
    {
        return $this->id;
    }
    
    public function setId($id)
    {
        $this->id = $id;
    }
    
    public function getIsClassic()
    {
        return $this->isClassic;
    }
    
    public function setIsClassic($isClassic)
    {
        $this->isClassic = $isClassic;
    }
}



1			<?php
2			/**
3			* @author Oleg Krivtsov <[email protected]>
4			* @date 05 October 2016
5			* @copyright (c) 2016, Web Marketing ROI
6			*/
7			namespace WebMarketingROI\OptimizelyPHP\Resource\v2;
8
9			use WebMarketingROI\OptimizelyPHP\Resource\v2\Schedule;
10			use WebMarketingROI\OptimizelyPHP\Resource\v2\Variation;
11			use WebMarketingROI\OptimizelyPHP\Resource\v2\Change;
12			use WebMarketingROI\OptimizelyPHP\Resource\v2\Metric;
13
14			/**
15			* An Optimizely experiment.
16			*/
17			class Experiment
18			{
19			/**
20			* The project the Experiment is in
21			* @var integer
22			*/
23			private $projectId;
24
25			/**
26			* List of IDs of all audiences the Experiment is targeted at
27			* @var array[integer]
28			*/
29			private $audienceIds;
30
31			/**
32			* The ID for the Campaign that the Experiment is in
33			* @var integer
34			*/
35			private $campaignId;
36
37			/**
38			* Experiment-level changes that will run before all Variations. Typically
39			* this is custom CSS or custom JavaScript.
40			* @var array[Change]

webmarketingroi / optimizely-php

Push — develop ( 6fdb58...dee5cf )

Experiment::__construct() D

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like