CampaignResults - Code Metrics - Inspection of "Improved README.md" - webmarketingroi/optimizely-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 6fdb58...dee5cf )

by Oleg

created 2016-10-19 03:45 UTC

CampaignResults A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	137
Duplicated Lines	15.33 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
dl	21
loc	137
ccs	51
cts	51
cp	1
rs	10
c	0
b	0
f	0
wmc	22
lcom	1
cbo	1

12 Methods

Rating	Name	Duplication	Size	Complexity
A	getCampaignId()	0	4	1
A	setCampaignId()	0	4	1
A	getConfidenceThreshold()	0	4	1
A	setConfidenceThreshold()	0	4	1
A	getEndTime()	0	4	1
A	setEndTime()	0	4	1
A	getMetrics()	0	4	1
A	setMetrics()	0	4	1
A	getStartTime()	0	4	1
A	setStartTime()	0	4	1
B	__construct()	21	21	8
B	toArray()	0	23	4

How to fix Duplicated Code

<?php
/**
 * @author Oleg Krivtsov <[email protected]>
 * @date 12 October 2016
 * @copyright (c) 2016, Web Marketing ROI
 */
namespace WebMarketingROI\OptimizelyPHP\Resource\v2;

use WebMarketingROI\OptimizelyPHP\Resource\v2\CampaignMetricResults;

/**
 * Optimizely campaign results.
 */
class CampaignResults
{
    /**
     * The unique identifier for the Campaign
     * @var integer
     */
    private $campaignId;
    
    /**
     * The significance level at which you would like to declare winning and 
     * losing variations. A lower number minimizes the time needed to declare a 
     * winning or losing variation, but increases the risk that your results 
     * aren't true winners and losers.
     * @var number
     */
    private $confidenceThreshold;
    
    /**
     * The latest time to count events in results
     * @var string 
     */
    private $endTime;
    
    /**
     * The breakdown of campaign results by metric.
     * @var array[CampaignMetricResults]
     */
    private $metrics;
    
    /**
     * The earliest time to count events in results
     * @var string
     */
    private $startTime;
    
    /**
     * Constructor.
     */
    public function __construct($options = array())

    {
        foreach ($options as $name=>$value) {
            switch ($name) {                
                case 'campaign_id': $this->setCampaignId($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'confidence_threshold': $this->setConfidenceThreshold($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'end_time': $this->setEndTime($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'metrics': {
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    $metrics = array();
                    foreach ($value as $metricInfo) {
                        $metrics[] = new CampaignMetricResults($metricInfo);
                    }
                    $this->setMetrics($metrics); 
                    break;
                }
                case 'start_time': $this->setStartTime($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                default:
                    throw new \Exception('Unknown option: ' . $name);
            }
        }
    }
    
    /**
     * Returns this object as array.
     */
    public function toArray()
    {
        $options = array(
            'campaign_id' => $this->getCampaignId(),
            'confidence_threshold' => $this->getConfidenceThreshold(),
            'end_time' => $this->getEndTime(),
            'metrics' => array(),
            'start_time' => $this->getStartTime()
        );
        
        foreach ($this->getMetrics() as $metric) {
            $options['metrics'][] = $metric->toArray();
        }
        
        // Remove options with empty values
        $cleanedOptions = array();
        foreach ($options as $name=>$value) {
            if ($value!==null)
                $cleanedOptions[$name] = $value;
        }
        
        return $cleanedOptions;
    }
    
    public function getCampaignId()
    {
        return $this->campaignId;
    }
    
    public function setCampaignId($campaignId)
    {
        $this->campaignId = $campaignId;
    }
    
    public function getConfidenceThreshold()
    {
        return $this->confidenceThreshold;
    }
    
    public function setConfidenceThreshold($confidenceThreshold)
    {
        $this->confidenceThreshold = $confidenceThreshold;
    }
    
    public function getEndTime()
    {
        return $this->endTime;
    }
    
    public function setEndTime($endTime)
    {
        $this->endTime = $endTime;
    }
    
    public function getMetrics()
    {
        return $this->metrics;
    }
    
    public function setMetrics($metrics)
    {
        $this->metrics = $metrics;
    }
    
    public function getStartTime()
    {
        return $this->startTime;
    }
    
    public function setStartTime($startTime)
    {
        $this->startTime = $startTime;
    }
}






1			<?php
2			/**
3			* @author Oleg Krivtsov <[email protected]>
4			* @date 12 October 2016
5			* @copyright (c) 2016, Web Marketing ROI
6			*/
7			namespace WebMarketingROI\OptimizelyPHP\Resource\v2;
8
9			use WebMarketingROI\OptimizelyPHP\Resource\v2\CampaignMetricResults;
10
11			/**
12			* Optimizely campaign results.
13			*/
14			class CampaignResults
15			{
16			/**
17			* The unique identifier for the Campaign
18			* @var integer
19			*/
20			private $campaignId;
21
22			/**
23			* The significance level at which you would like to declare winning and
24			* losing variations. A lower number minimizes the time needed to declare a
25			* winning or losing variation, but increases the risk that your results
26			* aren't true winners and losers.
27			* @var number
28			*/
29			private $confidenceThreshold;
30
31			/**
32			* The latest time to count events in results
33			* @var string
34			*/
35			private $endTime;
36
37			/**
38			* The breakdown of campaign results by metric.
39			* @var array[CampaignMetricResults]
40			*/
41			private $metrics;
42
43			/**
44			* The earliest time to count events in results
45			* @var string
46			*/
47			private $startTime;
48
49			/**
50			* Constructor.
51			*/
52	3	View Code Duplication	public function __construct($options = array())
			0 ignored issues – show Duplication introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53			{
54	3		foreach ($options as $name=>$value) {
55			switch ($name) {
56	3		case 'campaign_id': $this->setCampaignId($value); break;
			0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
57	3		case 'confidence_threshold': $this->setConfidenceThreshold($value); break;
			0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
58	3		case 'end_time': $this->setEndTime($value); break;
			0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
59	3		case 'metrics': {
			0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
60	3		$metrics = array();
61	3		foreach ($value as $metricInfo) {
62	3		$metrics[] = new CampaignMetricResults($metricInfo);
63			}
64	3		$this->setMetrics($metrics);
65	3		break;
66			}
67	3		case 'start_time': $this->setStartTime($value); break;
			0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
68			default:
69	3		throw new \Exception('Unknown option: ' . $name);
70			}
71			}
72	3		}
73
74			/**
75			* Returns this object as array.
76			*/
77	1		public function toArray()
78			{
79			$options = array(
80	1		'campaign_id' => $this->getCampaignId(),
81	1		'confidence_threshold' => $this->getConfidenceThreshold(),
82	1		'end_time' => $this->getEndTime(),
83			'metrics' => array(),
84	1		'start_time' => $this->getStartTime()
85			);
86
87	1		foreach ($this->getMetrics() as $metric) {
88	1		$options['metrics'][] = $metric->toArray();
89			}
90
91			// Remove options with empty values
92	1		$cleanedOptions = array();
93	1		foreach ($options as $name=>$value) {
94	1		if ($value!==null)
95	1		$cleanedOptions[$name] = $value;
96			}
97
98	1		return $cleanedOptions;
99			}
100
101	1		public function getCampaignId()
102			{
103	1		return $this->campaignId;
104			}
105
106	3		public function setCampaignId($campaignId)
107			{
108	3		$this->campaignId = $campaignId;
109	3		}
110
111	3		public function getConfidenceThreshold()
112			{
113	3		return $this->confidenceThreshold;
114			}
115
116	3		public function setConfidenceThreshold($confidenceThreshold)
117			{
118	3		$this->confidenceThreshold = $confidenceThreshold;
119	3		}
120
121	1		public function getEndTime()
122			{
123	1		return $this->endTime;
124			}
125
126	3		public function setEndTime($endTime)
127			{
128	3		$this->endTime = $endTime;
129	3		}
130
131	1		public function getMetrics()
132			{
133	1		return $this->metrics;
134			}
135
136	3		public function setMetrics($metrics)
137			{
138	3		$this->metrics = $metrics;
139	3		}
140
141	3		public function getStartTime()
142			{
143	3		return $this->startTime;
144			}
145
146	3		public function setStartTime($startTime)
147			{
148	3		$this->startTime = $startTime;
149	3		}
150			}
151
152
153
154
155

webmarketingroi / optimizely-php

Push — develop ( 6fdb58...dee5cf )

CampaignResults A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

12 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like