webmarketingroi / optimizely-php

lib/WebMarketingROI/OptimizelyPHP/Service/v2/Pages.php

Spacing +3 added lines, -3 removed lines

@@ -36,13 +36,13 @@
      * @return Result
      * @throws Exception
      */
-    public function listAll($projectId, $page=1, $perPage=25)
+    public function listAll($projectId, $page = 1, $perPage = 25)
     {
-        if ($page<0) {
+        if ($page < 0) {
             throw new Exception('Invalid page number passed');
         }
         
-        if ($perPage<0) {
+        if ($perPage < 0) {
             throw new Exception('Invalid page size passed');
         }
         

lib/WebMarketingROI/OptimizelyPHP/Resource/v2/ExperimentMetricResults.php

Spacing +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
                 case 'unit': $this->setUnit($value); break;
                 case 'variation_results': $this->setVariationResults($value); break;
                 default:
-                    throw new Exception('Unknown option: ' . $name);
+                    throw new Exception('Unknown option: '.$name);
             }
         }
     }

lib/WebMarketingROI/OptimizelyPHP/Exception.php

Braces +15 added lines, -10 removed lines

@@ -55,20 +55,25 @@
     {
         parent::__construct($message, $code);
         
-        if (isset($options['http_code']))
-            $this->setHttpCode($options['http_code']);
+        if (isset($options['http_code'])) {
+                    $this->setHttpCode($options['http_code']);
+        }
                 
-        if (isset($options['uuid']))
-            $this->setUuid($options['uuid']);
+        if (isset($options['uuid'])) {
+                    $this->setUuid($options['uuid']);
+        }
         
-        if (isset($options['rate_limit']))
-            $this->setRateLimit($options['rate_limit']);
+        if (isset($options['rate_limit'])) {
+                    $this->setRateLimit($options['rate_limit']);
+        }
         
-        if (isset($options['rate_limit_remaining']))
-            $this->setRateLimitRemaining($options['rate_limit_remaining']);
+        if (isset($options['rate_limit_remaining'])) {
+                    $this->setRateLimitRemaining($options['rate_limit_remaining']);
+        }
         
-        if (isset($options['rate_limit_reset']))
-            $this->setRateLimitReset($options['rate_limit_reset']);
+        if (isset($options['rate_limit_reset'])) {
+                    $this->setRateLimitReset($options['rate_limit_reset']);
+        }
     }
     
     /**

Doc Comments +1 added lines, -3 removed lines

@@ -82,7 +82,6 @@ 
             
     /**
      * Set HTTP response code.
-     * @param integer $code
      */
     public function setHttpCode($httpCode)
     {
@@ -100,7 +99,6 @@ 
             
     /**
      * Set message
-     * @param string $message
      */
     public function setUuid($uuid)
     {
@@ -145,7 +143,7 @@ 
     
     /**
      * Return the exact time that your fresh new rate limit kicks in.
-     * @return integer|null
+     * @return string
      */
     public function getRateLimitReset()
     {

lib/WebMarketingROI/OptimizelyPHP/Result.php

Doc Comments +2 added lines, -5 removed lines

@@ -70,8 +70,6 @@ 
     /**
      * Constructor.
      * @param array $decodedJsonData
-     * @param string $rawHttpResponseData
-     * @param array[string] $rawHttpResponseHeaders
      */
     public function __construct($decodedJsonData, $httpCode)
     {
@@ -90,7 +88,6 @@ 
             
     /**
      * Set HTTP response code.
-     * @param integer $code
      */
     public function setHttpCode($httpCode)
     {
@@ -108,7 +105,7 @@ 
     
     /**
      * Set payload (parsed and wrapped response data).
-     * @param mixed $payload
+     * @param integer $payload
      */
     public function setPayload($payload)
     {
@@ -225,7 +222,7 @@ 
     
     /**
      * Return the exact time that your fresh new rate limit kicks in.
-     * @return integer|null
+     * @return string
      */
     public function getRateLimitReset()
     {

tests/OptimizelyPHPTest/Service/v2/ProjectsTest.php

Indentation +36 added lines, -36 removed lines

@@ -176,16 +176,16 @@ 
                             "platform" => "web",
                             "status" => "active",
                             "web_snippet" => array(
-                              "enable_force_variation" => false,
-                              "exclude_disabled_experiments" => false,
-                              "exclude_names" => true,
-                              "include_jquery" => true,
-                              "ip_anonymization" => false,
-                              "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
-                              "library" => "jquery-1.11.3-trim",
-                              "project_javascript" => "alert(\"Active Experiment\")",
-                              "code_revision" => 0,
-                              "js_file_size" => 63495
+                                "enable_force_variation" => false,
+                                "exclude_disabled_experiments" => false,
+                                "exclude_names" => true,
+                                "include_jquery" => true,
+                                "ip_anonymization" => false,
+                                "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
+                                "library" => "jquery-1.11.3-trim",
+                                "project_javascript" => "alert(\"Active Experiment\")",
+                                "code_revision" => 0,
+                                "js_file_size" => 63495
                             ),
                             "created" => "2016-10-17T07:04:59.991Z",
                             "id" => 1000,
@@ -206,14 +206,14 @@ 
             "platform" => "web",
             "status" => "active",
             "web_snippet" => array(
-              "enable_force_variation" => false,
-              "exclude_disabled_experiments" => false,
-              "exclude_names" => true,
-              "include_jquery" => true,
-              "ip_anonymization" => false,
-              "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
-              "library" => "jquery-1.11.3-trim",
-              "project_javascript" => "alert(\"Active Experiment\")"
+                "enable_force_variation" => false,
+                "exclude_disabled_experiments" => false,
+                "exclude_names" => true,
+                "include_jquery" => true,
+                "ip_anonymization" => false,
+                "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
+                "library" => "jquery-1.11.3-trim",
+                "project_javascript" => "alert(\"Active Experiment\")"
             )
         ));
         
@@ -257,16 +257,16 @@ 
                             "platform" => "web",
                             "status" => "active",
                             "web_snippet" => array(
-                              "enable_force_variation" => false,
-                              "exclude_disabled_experiments" => false,
-                              "exclude_names" => true,
-                              "include_jquery" => true,
-                              "ip_anonymization" => false,
-                              "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
-                              "library" => "jquery-1.11.3-trim",
-                              "project_javascript" => "alert(\"Active Experiment\")",
-                              "code_revision" => 0,
-                              "js_file_size" => 63495
+                                "enable_force_variation" => false,
+                                "exclude_disabled_experiments" => false,
+                                "exclude_names" => true,
+                                "include_jquery" => true,
+                                "ip_anonymization" => false,
+                                "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
+                                "library" => "jquery-1.11.3-trim",
+                                "project_javascript" => "alert(\"Active Experiment\")",
+                                "code_revision" => 0,
+                                "js_file_size" => 63495
                             ),
                             "created" => "2016-10-17T07:04:59.999Z",
                             "id" => 1000,
@@ -286,14 +286,14 @@ 
             "name" => "Test Project",
             "status" => "active",
             "web_snippet" => array(
-              "enable_force_variation" => false,
-              "exclude_disabled_experiments" => false,
-              "exclude_names" => true,
-              "include_jquery" => true,
-              "ip_anonymization" => false,
-              "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
-              "library" => "jquery-1.11.3-trim",
-              "project_javascript" => "alert(\"Active Experiment\")"
+                "enable_force_variation" => false,
+                "exclude_disabled_experiments" => false,
+                "exclude_names" => true,
+                "include_jquery" => true,
+                "ip_anonymization" => false,
+                "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
+                "library" => "jquery-1.11.3-trim",
+                "project_javascript" => "alert(\"Active Experiment\")"
             )
         ));
         

Spacing +16 added lines, -16 removed lines

@@ -51,9 +51,9 @@ 
         $result = $projectsService->listAll();
         $projects = $result->getPayload();
         
-        $this->assertTrue(count($projects)==1);
+        $this->assertTrue(count($projects) == 1);
         $this->assertTrue($projects[0] instanceOf Project);
-        $this->assertTrue($projects[0]->getName()=='Some Optimizely Project');        
+        $this->assertTrue($projects[0]->getName() == 'Some Optimizely Project');        
     }
     
     /**
@@ -126,7 +126,7 @@ 
         $project = $result->getPayload();
         
         $this->assertTrue($project instanceOf Project);
-        $this->assertTrue($project->getName()=='Some Optimizely Project');        
+        $this->assertTrue($project->getName() == 'Some Optimizely Project');        
     }
     
     /**
@@ -221,8 +221,8 @@ 
         $createdProject = $result->getPayload();
         
         $this->assertTrue($createdProject instanceOf Project);
-        $this->assertTrue($createdProject->getName()=='Test Project');        
-        $this->assertTrue($createdProject->getAccountId()==12345);        
+        $this->assertTrue($createdProject->getName() == 'Test Project');        
+        $this->assertTrue($createdProject->getAccountId() == 12345);        
     }
     
     /**
@@ -301,8 +301,8 @@ 
         $updatedProject = $result->getPayload();
         
         $this->assertTrue($updatedProject instanceOf Project);
-        $this->assertTrue($updatedProject->getName()=='Test Project');        
-        $this->assertTrue($updatedProject->getAccountId()==12345);        
+        $this->assertTrue($updatedProject->getName() == 'Test Project');        
+        $this->assertTrue($updatedProject->getAccountId() == 12345);        
     }
     
     /**
@@ -362,7 +362,7 @@ 
         $credentials = $this->loadCredentialsFromFile();
         
         $optimizelyClient = new OptimizelyApiClient($credentials, 'v2');
-        $this->assertTrue($optimizelyClient!=null);
+        $this->assertTrue($optimizelyClient != null);
         
         $curDate = date('Y-m-d H:i:s');
         /*// Create new project        
@@ -408,17 +408,17 @@ 
                 $projects = $result->getPayload();
 
                 foreach ($projects as $project) {
-                    if ($project->getName()=="Test Project $curDate") {
+                    if ($project->getName() == "Test Project $curDate") {
                         $projectId = $project->getId();
                         $found = true;
                         break;
                     }
                 }
 
-                if ($result->getNextPage()==null)
+                if ($result->getNextPage() == null)
                     break;
 
-                $page ++;
+                $page++;
             }
         }
         catch (Exception $e) {
@@ -437,13 +437,13 @@ 
         try {
             $result = $optimizelyClient->projects()->get(12345678);        
         } 
-        catch(Exception $e) {
+        catch (Exception $e) {
             $this->assertEquals(Exception::CODE_API_ERROR, $e->getCode());
             $this->assertEquals(400, $e->getHttpCode());
-            $this->assertTrue(strlen($e->getUuid())!=0);
-            $this->assertTrue($e->getRateLimit()>0);
-            $this->assertTrue($e->getRateLimitRemaining()>0);
-            $this->assertTrue($e->getRateLimitReset()>0);
+            $this->assertTrue(strlen($e->getUuid()) != 0);
+            $this->assertTrue($e->getRateLimit() > 0);
+            $this->assertTrue($e->getRateLimitRemaining() > 0);
+            $this->assertTrue($e->getRateLimitReset() > 0);
         }
         
         // Retrieve existing project by ID        

Braces +8 added lines, -8 removed lines

@@ -356,8 +356,9 @@ 
     
     public function testIntegration()
     {
-        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) 
-            $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
+                    $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        }
         
         $credentials = $this->loadCredentialsFromFile();
         
@@ -415,13 +416,13 @@ 
                     }
                 }
 
-                if ($result->getNextPage()==null)
-                    break;
+                if ($result->getNextPage()==null) {
+                                    break;
+                }
 
                 $page ++;
             }
-        }
-        catch (Exception $e) {
+        } catch (Exception $e) {
             print_r($optimizelyClient->getDiagnosticsInfo());
             // Handle error.
             $code = $e->getCode();
@@ -436,8 +437,7 @@ 
         // Try a non-existing project by ID - assume failure
         try {
             $result = $optimizelyClient->projects()->get(12345678);        
-        } 
-        catch(Exception $e) {
+        } catch(Exception $e) {
             $this->assertEquals(Exception::CODE_API_ERROR, $e->getCode());
             $this->assertEquals(400, $e->getHttpCode());
             $this->assertTrue(strlen($e->getUuid())!=0);

tests/OptimizelyPHPTest/OptimizelyApiClientTest.php

Braces +1 added lines, -2 removed lines

@@ -163,8 +163,7 @@
         // refresh token, since the provided access token is invalid.
         try {
             $result = $client->sendApiRequest('/projects');        
-        }
-        catch (Exception $e) {
+        } catch (Exception $e) {
             $this->assertEquals(Exception::CODE_API_ERROR, $e->getCode());
             $this->assertEquals(400, $e->getHttpCode());            
         }

tests/OptimizelyPHPTest/ResultTest.php

Indentation +8 added lines, -8 removed lines

@@ -16,14 +16,14 @@
             "platform" => "web",
             "status" => "active",
             "web_snippet" => array(
-              "enable_force_variation" => false,
-              "exclude_disabled_experiments" => false,
-              "exclude_names" => true,
-              "include_jquery" => true,
-              "ip_anonymization" => false,
-              "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
-              "library" => "jquery-1.11.3-trim",
-              "project_javascript" => "alert(\"Active Experiment\")"
+                "enable_force_variation" => false,
+                "exclude_disabled_experiments" => false,
+                "exclude_names" => true,
+                "include_jquery" => true,
+                "ip_anonymization" => false,
+                "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
+                "library" => "jquery-1.11.3-trim",
+                "project_javascript" => "alert(\"Active Experiment\")"
             ));
         
         $result = new Result($data, 200);

lib/WebMarketingROI/OptimizelyPHP/Service/v2/Audiences.php

Spacing +3 added lines, -3 removed lines

@@ -36,13 +36,13 @@
      * @return Result
      * @throws Exception
      */
-    public function listAll($projectId, $page=1, $perPage=25)
+    public function listAll($projectId, $page = 1, $perPage = 25)
     {
-        if ($page<0) {
+        if ($page < 0) {
             throw new Exception('Invalid page number passed');
         }
         
-        if ($perPage<0 || $perPage>100) {
+        if ($perPage < 0 || $perPage > 100) {
             throw new Exception('Invalid page size passed');
         }
         

lib/WebMarketingROI/OptimizelyPHP/Service/v2/Experiments.php

Spacing +6 added lines, -6 removed lines

@@ -39,17 +39,17 @@ 
      * @return Result
      * @throws Exception
      */
-    public function listAll($projectId, $campaignId=null, $includeClassic=false, $page=1, $perPage=25)
+    public function listAll($projectId, $campaignId = null, $includeClassic = false, $page = 1, $perPage = 25)
     {
-        if ($projectId==null && $campaignId==null) {
+        if ($projectId == null && $campaignId == null) {
             throw new Exception('Project ID or Campaign ID must be non-null');
         }
         
-        if ($page<0) {
+        if ($page < 0) {
             throw new Exception('Invalid page number passed');
         }
         
-        if ($perPage<0 || $perPage>100) {
+        if ($perPage < 0 || $perPage > 100) {
             throw new Exception('Invalid page size passed');
         }
         
@@ -85,7 +85,7 @@ 
                     Exception::CODE_INVALID_ARG);
         }
         
-        if ($experimentId<0) {
+        if ($experimentId < 0) {
             throw new Exception("A positive experiment ID expected");
         }
         
@@ -175,7 +175,7 @@ 
             throw new Exception("Expected argument of type Experiment");
         }
         
-        if ($experimentId<0) {
+        if ($experimentId < 0) {
             throw new Exception("Expected positive experiment ID argument");
         }