UrlTargeting - Code Metrics - Inspection of "Fixed: UrlTargeting" - webmarketingroi/optimizely-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 39a82f...96059f )

by Oleg

created 2018-02-23 10:44 UTC

UrlTargeting A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	137
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	137
ccs	0
cts	75
cp	0
rs	10
wmc	21
lcom	1
cbo	1

14 Methods

Rating	Name	Size	Complexity
B	__construct()	16	8
A	toArray()	13	1
A	getConditions()	4	1
A	setConditions()	4	1
A	getEditUrl()	4	1
A	setEditUrl()	4	1
A	getActivationCode()	4	1
A	setActivationCode()	4	1
A	getActivationType()	4	1
A	setActivationType()	4	1
A	getKey()	4	1
A	setKey()	4	1
A	getPageId()	4	1
A	setPageId()	4	1

<?php
/**
 * @author Oleg Krivtsov <[email protected]>
 * @date 05 October 2016
 * @copyright (c) 2016, Web Marketing ROI
 */
namespace WebMarketingROI\OptimizelyPHP\Resource\v2;

use WebMarketingROI\OptimizelyPHP\Exception;

/**
 * An Optimizely experiment.
 */
class UrlTargeting
{
    /**
     * Conditions to activate the experiment; our knowledge base article on 
     * Activation Types is the best guide for how to set up this data.
     * @var type 
     */
    private $conditions;
    
    /**
     * URL to load in the editor for this page
     * @var type 
     */
    private $editUrl;
    
    /**
     * Stringified Javascript function that determines when the Page is activated. 
     * Only required when activation_type is 'polling' or 'callback'.
     * @var type 
     */
    private $activationCode;
    
    /**
     * How this page is activated. See the full documentation on the Page object.
     * @var type 
     */
    private $activationType;
    
    /**
     * Unique string identifier for this Page within the Project
     * @var type 
     */
    private $key;
    
    /**
     * The unique identifier of the Page that represents the experiment or campaign's URL Targeting.
     * @var type 
     */
    private $pageId;
    
    /**
     * Constructor.
     */
    public function __construct($options = array())
    {
        foreach ($options as $name=>$value) {
            switch ($name) {
                case 'conditions': $this->setConditions($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'edit_url': $this->setEditUrl($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'activation_code': $this->setActivationCode($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'activation_type': $this->setActivationType($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'key': $this->setKey($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'page_id': $this->setPageId($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                
                default:
                    throw new Exception('Unknown option found in the UrlTargeting entity: ' . $name);
            }
        }
    }
    
    /**
     * Returns this object as array.
     */
    public function toArray()
    {
        $options = array(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            'conditions' => $this->getConditions(),
            'edit_url' => $this->getEditUrl(),
            'activation_code' => $this->getActivationCode(),
            'activation_type' => $this->getActivationType(),
            'key' => $this->getKey(),
            'page_id' => $this->getPageId(),
        );
                
        return $cleanedOptions;

    }
    
    public function getConditions()
    {
        return $this->conditions;
    }
    
    public function setConditions($conditions)
    {
        $this->conditions = $conditions;
    }
    
    public function getEditUrl()
    {
        return $this->editUrl;
    }
    
    public function setEditUrl($editUrl)
    {
        $this->editUrl = $editUrl;
    }
    
    public function getActivationCode()
    {
        return $this->activationCode;
    }
    
    public function setActivationCode($activationCode)
    {
        $this->activationCode = $activationCode;
    }
    
    public function getActivationType()
    {
        return $this->activationType;
    }
    
    public function setActivationType($activationType)
    {
        $this->activationType = $activationType;
    }
    
    public function getKey()
    {
        return $this->key;
    }
    
    public function setKey($key)
    {
        $this->key = $key;
    }
    
    public function getPageId()
    {
        return $this->pageId;
    }
    
    public function setPageId($pageId)
    {
        $this->pageId = $pageId;
    }
}



1			<?php
2			/**
3			* @author Oleg Krivtsov <[email protected]>
4			* @date 05 October 2016
5			* @copyright (c) 2016, Web Marketing ROI
6			*/
7			namespace WebMarketingROI\OptimizelyPHP\Resource\v2;
8
9			use WebMarketingROI\OptimizelyPHP\Exception;
10
11			/**
12			* An Optimizely experiment.
13			*/
14			class UrlTargeting
15			{
16			/**
17			* Conditions to activate the experiment; our knowledge base article on
18			* Activation Types is the best guide for how to set up this data.
19			* @var type
20			*/
21			private $conditions;
22
23			/**
24			* URL to load in the editor for this page
25			* @var type
26			*/
27			private $editUrl;
28
29			/**
30			* Stringified Javascript function that determines when the Page is activated.
31			* Only required when activation_type is 'polling' or 'callback'.
32			* @var type
33			*/
34			private $activationCode;
35
36			/**
37			* How this page is activated. See the full documentation on the Page object.
38			* @var type
39			*/
40			private $activationType;
41
42			/**
43			* Unique string identifier for this Page within the Project
44			* @var type
45			*/
46			private $key;
47
48			/**
49			* The unique identifier of the Page that represents the experiment or campaign's URL Targeting.
50			* @var type
51			*/
52			private $pageId;
53
54			/**
55			* Constructor.
56			*/
57			public function __construct($options = array())
58			{
59			foreach ($options as $name=>$value) {
60			switch ($name) {
61			case 'conditions': $this->setConditions($value); break;
			0 ignored issues – show Coding Style introduced 2018-02-23 10:47 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2018-02-23 10:47 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
62			case 'edit_url': $this->setEditUrl($value); break;
			0 ignored issues – show Coding Style introduced 2018-02-22 12:14 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2018-02-22 12:14 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
63			case 'activation_code': $this->setActivationCode($value); break;
			0 ignored issues – show Coding Style introduced 2018-02-22 12:14 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2018-02-22 12:14 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
64			case 'activation_type': $this->setActivationType($value); break;
			0 ignored issues – show Coding Style introduced 2018-02-22 12:14 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2018-02-22 12:14 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
65			case 'key': $this->setKey($value); break;
			0 ignored issues – show Coding Style introduced 2018-02-22 12:14 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2018-02-22 12:14 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
66			case 'page_id': $this->setPageId($value); break;
			0 ignored issues – show Coding Style introduced 2018-02-22 12:14 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2018-02-22 12:14 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
67
68			default:
69			throw new Exception('Unknown option found in the UrlTargeting entity: ' . $name);
70			}
71			}
72			}
73
74			/**
75			* Returns this object as array.
76			*/
77			public function toArray()
78			{
79			$options = array(
			0 ignored issues – show Unused Code introduced 2018-02-22 12:14 UTC by Report Bug Copy Issue Report `$options` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
80			'conditions' => $this->getConditions(),
81			'edit_url' => $this->getEditUrl(),
82			'activation_code' => $this->getActivationCode(),
83			'activation_type' => $this->getActivationType(),
84			'key' => $this->getKey(),
85			'page_id' => $this->getPageId(),
86			);
87
88			return $cleanedOptions;
			0 ignored issues – show Bug introduced 2018-02-22 12:14 UTC by Report Bug Copy Issue Report The variable `$cleanedOptions` does not exist. Did you mean `$options`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history...
89			}
90
91			public function getConditions()
92			{
93			return $this->conditions;
94			}
95
96			public function setConditions($conditions)
97			{
98			$this->conditions = $conditions;
99			}
100
101			public function getEditUrl()
102			{
103			return $this->editUrl;
104			}
105
106			public function setEditUrl($editUrl)
107			{
108			$this->editUrl = $editUrl;
109			}
110
111			public function getActivationCode()
112			{
113			return $this->activationCode;
114			}
115
116			public function setActivationCode($activationCode)
117			{
118			$this->activationCode = $activationCode;
119			}
120
121			public function getActivationType()
122			{
123			return $this->activationType;
124			}
125
126			public function setActivationType($activationType)
127			{
128			$this->activationType = $activationType;
129			}
130
131			public function getKey()
132			{
133			return $this->key;
134			}
135
136			public function setKey($key)
137			{
138			$this->key = $key;
139			}
140
141			public function getPageId()
142			{
143			return $this->pageId;
144			}
145
146			public function setPageId($pageId)
147			{
148			$this->pageId = $pageId;
149			}
150			}
151
152

webmarketingroi / optimizely-php

Push — master ( 39a82f...96059f )

UrlTargeting A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

14 Methods

Duplication Side-by-Side

Filter issues like