CampaignResults - Code Metrics - Inspection of "Fixing: Campaigns doesn't accept string projectId" - webmarketingroi/optimizely-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 96059f...fe2237 )

by Oleg

created 2018-02-23 10:56 UTC

CampaignResults A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	137
Duplicated Lines	15.33 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

94.92%

Importance

Changes

Metric	Value
dl	21
loc	137
ccs	56
cts	59
cp	0.9492
rs	10
c	0
b	0
f	0
wmc	22
lcom	1
cbo	2

12 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	21	21	8
B	toArray()	0	23	4
A	getCampaignId()	0	4	1
A	setCampaignId()	0	4	1
A	getConfidenceThreshold()	0	4	1
A	setConfidenceThreshold()	0	4	1
A	getEndTime()	0	4	1
A	setEndTime()	0	4	1
A	getMetrics()	0	4	1
A	setMetrics()	0	4	1
A	getStartTime()	0	4	1
A	setStartTime()	0	4	1

How to fix Duplicated Code

<?php
/**
 * @author Oleg Krivtsov <[email protected]>
 * @date 12 October 2016
 * @copyright (c) 2016, Web Marketing ROI
 */
namespace WebMarketingROI\OptimizelyPHP\Resource\v2;

use WebMarketingROI\OptimizelyPHP\Exception;
use WebMarketingROI\OptimizelyPHP\Resource\v2\CampaignMetricResults;

/**
 * Optimizely campaign results.
 */
class CampaignResults
{
    /**
     * The unique identifier for the Campaign
     * @var integer
     */
    private $campaignId;
    
    /**
     * The significance level at which you would like to declare winning and 
     * losing variations. A lower number minimizes the time needed to declare a 
     * winning or losing variation, but increases the risk that your results 
     * aren't true winners and losers.
     * @var number
     */
    private $confidenceThreshold;
    
    /**
     * The latest time to count events in results
     * @var string 
     */
    private $endTime;
    
    /**
     * The breakdown of campaign results by metric.
     * @var array[CampaignMetricResults]
     */
    private $metrics;
    
    /**
     * The earliest time to count events in results
     * @var string
     */
    private $startTime;
    
    /**
     * Constructor.
     */
    public function __construct($options = array())

    {
        foreach ($options as $name=>$value) {
            switch ($name) {                
                case 'campaign_id': $this->setCampaignId($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'confidence_threshold': $this->setConfidenceThreshold($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'end_time': $this->setEndTime($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'metrics': {
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    $metrics = array();
                    foreach ($value as $metricInfo) {
                        $metrics[] = new CampaignMetricResults($metricInfo);
                    }
                    $this->setMetrics($metrics); 
                    break;
                }
                case 'start_time': $this->setStartTime($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                default:
                    throw new Exception('Unknown option found in CampaignResults entity: ' . $name);
            }
        }
    }
    
    /**
     * Returns this object as array.
     */
    public function toArray()
    {
        $options = array(
            'campaign_id' => $this->getCampaignId(),
            'confidence_threshold' => $this->getConfidenceThreshold(),
            'end_time' => $this->getEndTime(),
            'metrics' => array(),
            'start_time' => $this->getStartTime()
        );
        
        foreach ($this->getMetrics() as $metric) {
            $options['metrics'][] = $metric->toArray();
        }
        
        // Remove options with empty values
        $cleanedOptions = array();
        foreach ($options as $name=>$value) {
            if ($value!==null)
                $cleanedOptions[$name] = $value;
        }
        
        return $cleanedOptions;
    }
    
    public function getCampaignId()
    {
        return $this->campaignId;
    }
    
    public function setCampaignId($campaignId)
    {
        $this->campaignId = $campaignId;
    }
    
    public function getConfidenceThreshold()
    {
        return $this->confidenceThreshold;
    }
    
    public function setConfidenceThreshold($confidenceThreshold)
    {
        $this->confidenceThreshold = $confidenceThreshold;
    }
    
    public function getEndTime()
    {
        return $this->endTime;
    }
    
    public function setEndTime($endTime)
    {
        $this->endTime = $endTime;
    }
    
    public function getMetrics()
    {
        return $this->metrics;
    }
    
    public function setMetrics($metrics)
    {
        $this->metrics = $metrics;
    }
    
    public function getStartTime()
    {
        return $this->startTime;
    }
    
    public function setStartTime($startTime)
    {
        $this->startTime = $startTime;
    }
}






1			<?php
2			/**
3			* @author Oleg Krivtsov <[email protected]>
4			* @date 12 October 2016
5			* @copyright (c) 2016, Web Marketing ROI
6			*/
7			namespace WebMarketingROI\OptimizelyPHP\Resource\v2;
8
9			use WebMarketingROI\OptimizelyPHP\Exception;
10			use WebMarketingROI\OptimizelyPHP\Resource\v2\CampaignMetricResults;
11
12			/**
13			* Optimizely campaign results.
14			*/
15			class CampaignResults
16			{
17			/**
18			* The unique identifier for the Campaign
19			* @var integer
20			*/
21			private $campaignId;
22
23			/**
24			* The significance level at which you would like to declare winning and
25			* losing variations. A lower number minimizes the time needed to declare a
26			* winning or losing variation, but increases the risk that your results
27			* aren't true winners and losers.
28			* @var number
29			*/
30			private $confidenceThreshold;
31
32			/**
33			* The latest time to count events in results
34			* @var string
35			*/
36			private $endTime;
37
38			/**
39			* The breakdown of campaign results by metric.
40			* @var array[CampaignMetricResults]
41			*/
42			private $metrics;
43
44			/**
45			* The earliest time to count events in results
46			* @var string
47			*/
48			private $startTime;
49
50			/**
51			* Constructor.
52			*/
53	3	View Code Duplication	public function __construct($options = array())
			0 ignored issues – show Duplication introduced 2017-07-31 14:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
54			{
55	3		foreach ($options as $name=>$value) {
56			switch ($name) {
57	3		case 'campaign_id': $this->setCampaignId($value); break;
			0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
58	3		case 'confidence_threshold': $this->setConfidenceThreshold($value); break;
			0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
59	3		case 'end_time': $this->setEndTime($value); break;
			0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
60	3		case 'metrics': {
			0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
61	3		$metrics = array();
62	3		foreach ($value as $metricInfo) {
63	3		$metrics[] = new CampaignMetricResults($metricInfo);
64	3		}
65	3		$this->setMetrics($metrics);
66	3		break;
67			}
68	3		case 'start_time': $this->setStartTime($value); break;
			0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
69			default:
70			throw new Exception('Unknown option found in CampaignResults entity: ' . $name);
71			}
72	3		}
73	3		}
74
75			/**
76			* Returns this object as array.
77			*/
78	2		public function toArray()
79			{
80			$options = array(
81	1		'campaign_id' => $this->getCampaignId(),
82	1		'confidence_threshold' => $this->getConfidenceThreshold(),
83	1		'end_time' => $this->getEndTime(),
84	2		'metrics' => array(),
85	1		'start_time' => $this->getStartTime()
86	1		);
87
88	1		foreach ($this->getMetrics() as $metric) {
89	1		$options['metrics'][] = $metric->toArray();
90	1		}
91
92			// Remove options with empty values
93	1		$cleanedOptions = array();
94	1		foreach ($options as $name=>$value) {
95	1		if ($value!==null)
96	1		$cleanedOptions[$name] = $value;
97	1		}
98
99	1		return $cleanedOptions;
100			}
101
102	1		public function getCampaignId()
103			{
104	1		return $this->campaignId;
105			}
106
107	3		public function setCampaignId($campaignId)
108			{
109	3		$this->campaignId = $campaignId;
110	3		}
111
112	3		public function getConfidenceThreshold()
113			{
114	3		return $this->confidenceThreshold;
115			}
116
117	3		public function setConfidenceThreshold($confidenceThreshold)
118			{
119	3		$this->confidenceThreshold = $confidenceThreshold;
120	3		}
121
122	1		public function getEndTime()
123			{
124	1		return $this->endTime;
125			}
126
127	3		public function setEndTime($endTime)
128			{
129	3		$this->endTime = $endTime;
130	3		}
131
132	1		public function getMetrics()
133			{
134	1		return $this->metrics;
135			}
136
137	3		public function setMetrics($metrics)
138			{
139	3		$this->metrics = $metrics;
140	3		}
141
142	3		public function getStartTime()
143			{
144	3		return $this->startTime;
145			}
146
147	3		public function setStartTime($startTime)
148			{
149	3		$this->startTime = $startTime;
150	3		}
151			}
152
153
154
155
156

webmarketingroi / optimizely-php

Push — master ( 96059f...fe2237 )

CampaignResults A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

12 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like