Action - Code Metrics - Inspection of "Fixing: Campaigns doesn't accept string projectId" - webmarketingroi/optimizely-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 96059f...fe2237 )

by Oleg

created 2018-02-23 10:56 UTC

Action A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	97
Duplicated Lines	7.22 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

84.09%

Importance

Changes

Metric	Value
dl	7
loc	97
ccs	37
cts	44
cp	0.8409
rs	10
c	0
b	0
f	0
wmc	16
lcom	1
cbo	2

8 Methods

Rating	Name	Duplication	Size	Complexity
A	getChanges()	0	4	1
A	setChanges()	0	4	1
A	getPageId()	0	4	1
A	setPageId()	0	4	1
A	getShareLink()	0	4	1
A	setShareLink()	0	4	1
B	__construct()	7	18	6
A	toArray()	0	21	4

How to fix Duplicated Code

<?php
/**
 * @author Oleg Krivtsov <[email protected]>
 * @date 12 October 2016
 * @copyright (c) 2016, Web Marketing ROI
 */
namespace WebMarketingROI\OptimizelyPHP\Resource\v2;

use WebMarketingROI\OptimizelyPHP\Exception;
use WebMarketingROI\OptimizelyPHP\Resource\v2\Change;

/**
 * Optimizely action.
 */
class Action
{
    /**
     * The list of changes to apply to the Page
     * @var array[Change] 
     */
    private $changes;
    
    /**
     * The Page ID to apply changes to
     * @var integer 
     */
    private $pageId;
    
    /**
     * The share link for the provided Variation and Page combination
     * @var string 
     */
    private $shareLink;
    
    /**
     * Constructor.
     */
    public function __construct($options = array())
    {
        foreach ($options as $name=>$value) {
            switch ($name) {                
                case 'changes': {
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    $changes = array();
                    foreach ($value as $changeInfo) {
                        $changes[] = new Change($changeInfo);
                    }
                    $this->setChanges($changes); break;
                }
                case 'page_id': $this->setPageId($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'share_link': $this->setShareLink($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                default:
                    throw new Exception('Unknown option found in the Action entity: ' . $name);
            }
        }
    }
    
    /**
     * Returns this object as array.
     */
    public function toArray()
    {
        $options = array(
            'changes' => array(),
            'page_id' => $this->getPageId(),   
            'share_link' => $this->getShareLink(),
        );
        
        foreach ($this->getChanges() as $change) {
            $options['changes'][] = $change->toArray();
        }
        
        // Remove options with empty values
        $cleanedOptions = array();
        foreach ($options as $name=>$value) {
            if ($value!==null)
                $cleanedOptions[$name] = $value;
        }
        
        return $cleanedOptions;
    }
    
    public function getChanges()
    {
        return $this->changes;
    }
    
    public function setChanges($changes)
    {
        $this->changes = $changes;
    }
    
    public function getPageId()
    {
        return $this->pageId;
    }
    
    public function setPageId($pageId)
    {
        $this->pageId = $pageId;
    }
    
    public function getShareLink()
    {
        return $this->shareLink;
    }
    
    public function setShareLink($shareLink)
    {
        $this->shareLink = $shareLink;
    }
}












1			<?php
2			/**
3			* @author Oleg Krivtsov <[email protected]>
4			* @date 12 October 2016
5			* @copyright (c) 2016, Web Marketing ROI
6			*/
7			namespace WebMarketingROI\OptimizelyPHP\Resource\v2;
8
9			use WebMarketingROI\OptimizelyPHP\Exception;
10			use WebMarketingROI\OptimizelyPHP\Resource\v2\Change;
11
12			/**
13			* Optimizely action.
14			*/
15			class Action
16			{
17			/**
18			* The list of changes to apply to the Page
19			* @var array[Change]
20			*/
21			private $changes;
22
23			/**
24			* The Page ID to apply changes to
25			* @var integer
26			*/
27			private $pageId;
28
29			/**
30			* The share link for the provided Variation and Page combination
31			* @var string
32			*/
33			private $shareLink;
34
35			/**
36			* Constructor.
37			*/
38	7		public function __construct($options = array())
39			{
40	7		foreach ($options as $name=>$value) {
41			switch ($name) {
42	6	View Code Duplication	case 'changes': {
			0 ignored issues – show Duplication introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
43	6		$changes = array();
44	6		foreach ($value as $changeInfo) {
45	6		$changes[] = new Change($changeInfo);
46	6		}
47	6		$this->setChanges($changes); break;
48			}
49	6		case 'page_id': $this->setPageId($value); break;
			0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
50			case 'share_link': $this->setShareLink($value); break;
			0 ignored issues – show Coding Style introduced 2017-08-29 09:29 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-08-29 09:29 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
51			default:
52			throw new Exception('Unknown option found in the Action entity: ' . $name);
53			}
54	7		}
55	7		}
56
57			/**
58			* Returns this object as array.
59			*/
60	3		public function toArray()
61			{
62			$options = array(
63	3		'changes' => array(),
64	3		'page_id' => $this->getPageId(),
65	3		'share_link' => $this->getShareLink(),
66	3		);
67
68	3		foreach ($this->getChanges() as $change) {
69	3		$options['changes'][] = $change->toArray();
70	3		}
71
72			// Remove options with empty values
73	3		$cleanedOptions = array();
74	3		foreach ($options as $name=>$value) {
75	3		if ($value!==null)
76	3		$cleanedOptions[$name] = $value;
77	3		}
78
79	3		return $cleanedOptions;
80			}
81
82	3		public function getChanges()
83			{
84	3		return $this->changes;
85			}
86
87	7		public function setChanges($changes)
88			{
89	7		$this->changes = $changes;
90	7		}
91
92	3		public function getPageId()
93			{
94	3		return $this->pageId;
95			}
96
97	7		public function setPageId($pageId)
98			{
99	7		$this->pageId = $pageId;
100	7		}
101
102	3		public function getShareLink()
103			{
104	3		return $this->shareLink;
105			}
106
107			public function setShareLink($shareLink)
108			{
109			$this->shareLink = $shareLink;
110			}
111			}
112
113
114
115
116
117
118
119
120
121
122

webmarketingroi / optimizely-php

Push — master ( 96059f...fe2237 )

Action A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like