Inspection of "Update README" - webmarketingroi/optimizely-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5c0b02...4f84cc )

by James

created 2017-05-09 14:11 UTC

Status

Indentation +40 added lines, -40 removed lines patch added patch discarded remove patch

@@ -113,14 +113,14 @@  discard block
 block discarded – undo
         $options = array(
             "project_id" => 1000,
             "audience_ids" => array(
-              1234,
-              1212,
-              1432
+                1234,
+                1212,
+                1432
             ),
             "campaign_id" => 2000,
             "audience_conditions" => "[\"and\", {\"audience_id\": 7000}, {\"audience_id\":7001}]",
             "changes" => array(
-              array(
+                array(
                 "type" => "custom_code",
                 "allow_additional_redirect" => true,
                 "async" => true,
@@ -135,8 +135,8 @@  discard block
 block discarded – undo
                     "text" => "Some nice message"
                 ),                
                 "dependencies" => array(
-                  24,
-                  26
+                    24,
+                    26
                 ),
                 "destination" => "https://app.optimizely.com/",
                 "extension_id" => 1234,
@@ -145,57 +145,57 @@  discard block
 block discarded – undo
                 "selector" => "a[href*=\"optimizely\"]",
                 "src" => 524,
                 "value" => "window.someGlobalFunction();"
-              )
+                )
             ),
             "type" => "a/b",
             "description" => "string",
             "holdback" => 5000,
             "key" => "home_page_experiment",
             "metrics" => array(
-              array(
+                array(
                 "aggregator" => "unique",
                 "event_id" => 0,
                 "field" => "revenue",
                 "scope" => "session"
-              )
+                )
             ),
             "name" => "Blue Button Experiment",
             "schedule" => array(
-              "start_time" => "2016-10-14T05:08:42.850Z",
-              "stop_time" => "2016-10-14T05:08:42.850Z",
-              "time_zone" => "UTC"
+                "start_time" => "2016-10-14T05:08:42.850Z",
+                "stop_time" => "2016-10-14T05:08:42.850Z",
+                "time_zone" => "UTC"
             ),
             "status" => "active",
             "variations" => array(
-              array(
+                array(
                 "actions" => array(
-                  array(
+                    array(
                     "changes" => array(
-                      array(
+                        array(
                         "type" => "custom_code",
                         "allow_additional_redirect" => true,
                         "async" => true,
                         "selector" => "a[href*=\"optimizely\"]",
                         "dependencies" => array(
-                          24,
-                          26
+                            24,
+                            26
                         ),
                         "destination" => "https://app.optimizely.com/",
                         "extension_id" => 1234,
                         "preserve_parameters" => true,
                         "src" => 524,
                         "value" => "window.someGlobalFunction();"
-                     )
+                        )
                     ),
                     "page_id" => 0
-                  )
+                    )
                 ),
                 "archived" => true,
                 "key" => "blue_button_variation",
                 "name" => "Blue Button",
                 "variation_id" => 0,
                 "weight" => 0,                
-              )
+                )
             )
         );
         
@@ -210,13 +210,13 @@  discard block
 block discarded – undo
         $options = array(
             "project_id" => 1000,
             "audience_ids" => array(
-              1234,
-              1212,
-              1432
+                1234,
+                1212,
+                1432
             ),
             "campaign_id" => 2000,
             "changes" => array(
-              array(
+                array(
                 "type" => "custom_code",
                 "allow_additional_redirect" => true,
                 "async" => true,
@@ -232,64 +232,64 @@  discard block
 block discarded – undo
                 ), 
                 "selector" => "a[href*=\"optimizely\"]",
                 "dependencies" => array(
-                  24,
-                  26
+                    24,
+                    26
                 ),
                 "destination" => "https://app.optimizely.com/",
                 "extension_id" => 1234,
                 "preserve_parameters" => true,
                 "src" => 524,
                 "value" => "window.someGlobalFunction();"
-              )
+                )
             ),
             "description" => "string",
             "holdback" => 5000,
             "key" => "home_page_experiment",
             "metrics" => array(
-              array(
+                array(
                 "aggregator" => "unique",
                 "event_id" => 0,
                 "field" => "revenue",
                 "scope" => "session"
-              )
+                )
             ),
             "name" => "Blue Button Experiment",
             "schedule" => array(
-              "start_time" => "2016-10-14T05:08:42.850Z",
-              "stop_time" => "2016-10-14T05:08:42.850Z",
-              "time_zone" => "UTC"
+                "start_time" => "2016-10-14T05:08:42.850Z",
+                "stop_time" => "2016-10-14T05:08:42.850Z",
+                "time_zone" => "UTC"
             ),
             "status" => "active",
             "variations" => array(
-              array(
+                array(
                 "actions" => array(
-                  array(
+                    array(
                     "changes" => array(
-                      array(
+                        array(
                         "type" => "custom_code",
                         "allow_additional_redirect" => true,
                         "async" => true,
                         "selector" => "a[href*=\"optimizely\"]",
                         "dependencies" => array(
-                          24,
-                          26
+                            24,
+                            26
                         ),
                         "destination" => "https://app.optimizely.com/",
                         "extension_id" => 1234,
                         "preserve_parameters" => true,
                         "src" => 524,
                         "value" => "window.someGlobalFunction();"
-                     )
+                        )
                     ),
                     "page_id" => 0
-                  )
+                    )
                 ),
                 "archived" => true,
                 "key" => "blue_button_variation",
                 "name" => "Blue Button",
                 "variation_id" => 0,
                 "weight" => 0
-              )
+                )
             )
         );
         

Please login to merge, or discard this patch.

tests/OptimizelyPHPTest/Service/v2/AudiencesTest.php 3 patches

Indentation +33 added lines, -33 removed lines patch added patch discarded remove patch

@@ -86,15 +86,15 @@  discard block
 block discarded – undo
                             "project_id" => 1000,
                             "archived" => false,
                             "conditions" => array(
-                              "and",
-                              array(
+                                "and",
+                                array(
                                 "type" => "language",
                                 "value" => "es"
-                              ),
-                              array(
+                                ),
+                                array(
                                 "type" => "location",
                                 "value" => "US-CA-SANFRANCISCO"
-                              )
+                                )
                             ),
                             "description" => "People that speak spanish and are in San Francisco",
                             "name" => "Spanish speaking San Franciscans",
@@ -127,15 +127,15 @@  discard block
 block discarded – undo
                             "project_id" => 1000,
                             "archived" => false,
                             "conditions" => array(
-                              "and",
-                              array(
+                                "and",
+                                array(
                                 "type" => "language",
                                 "value" => "es"
-                              ),
-                              array(
+                                ),
+                                array(
                                 "type" => "location",
                                 "value" => "US-CA-SANFRANCISCO"
-                              )
+                                )
                             ),
                             "description" => "People that speak spanish and are in San Francisco",
                             "name" => "Spanish speaking San Franciscans",
@@ -154,15 +154,15 @@  discard block
 block discarded – undo
                 "project_id" => 1000,
                 "archived" => false,
                 "conditions" => array(
-                  "and",
-                  array(
+                    "and",
+                    array(
                     "type" => "language",
                     "value" => "es"
-                  ),
-                  array(
+                    ),
+                    array(
                     "type" => "location",
                     "value" => "US-CA-SANFRANCISCO"
-                  )
+                    )
                 ),
                 "description" => "People that speak spanish and are in San Francisco",
                 "name" => "Spanish speaking San Franciscans",
@@ -187,15 +187,15 @@  discard block
 block discarded – undo
                             "project_id" => 1000,
                             "archived" => false,
                             "conditions" => array(
-                              "and",
-                              array(
+                                "and",
+                                array(
                                 "type" => "language",
                                 "value" => "es"
-                              ),
-                              array(
+                                ),
+                                array(
                                 "type" => "location",
                                 "value" => "US-CA-SANFRANCISCO"
-                              )
+                                )
                             ),
                             "description" => "People that speak spanish and are in San Francisco",
                             "name" => "Spanish speaking San Franciscans",
@@ -214,15 +214,15 @@  discard block
 block discarded – undo
                 "project_id" => 1000,
                 "archived" => false,
                 "conditions" => array(
-                  "and",
-                  array(
+                    "and",
+                    array(
                     "type" => "language",
                     "value" => "es"
-                  ),
-                  array(
+                    ),
+                    array(
                     "type" => "location",
                     "value" => "US-CA-SANFRANCISCO"
-                  )
+                    )
                 ),
                 "description" => "People that speak spanish and are in San Francisco",
                 "name" => "Spanish speaking San Franciscans",
@@ -255,14 +255,14 @@  discard block
 block discarded – undo
             "platform" => "web",
             "status" => "active",
             "web_snippet" => array(
-              "enable_force_variation" => false,
-              "exclude_disabled_experiments" => false,
-              "exclude_names" => true,
-              "include_jquery" => true,
-              "ip_anonymization" => false,
-              "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
-              "library" => "jquery-1.11.3-trim",
-              "project_javascript" => "alert(\"Active Experiment\")"
+                "enable_force_variation" => false,
+                "exclude_disabled_experiments" => false,
+                "exclude_names" => true,
+                "include_jquery" => true,
+                "ip_anonymization" => false,
+                "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
+                "library" => "jquery-1.11.3-trim",
+                "project_javascript" => "alert(\"Active Experiment\")"
             )
         ));
         

Please login to merge, or discard this patch.

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -40,9 +40,9 @@  discard block
 block discarded – undo
         $result = $audiencesService->listAll(1000);
         $audiences = $result->getPayload();
         
-        $this->assertTrue(count($audiences)==1);
+        $this->assertTrue(count($audiences) == 1);
         $this->assertTrue($audiences[0] instanceOf Audience);
-        $this->assertTrue($audiences[0]->getName()=='Spanish speaking San Franciscans');        
+        $this->assertTrue($audiences[0]->getName() == 'Spanish speaking San Franciscans');        
     }
     
     /**
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
         $audience = $result->getPayload();
         
         $this->assertTrue($audience instanceOf Audience);
-        $this->assertTrue($audience->getName()=='Spanish speaking San Franciscans');        
+        $this->assertTrue($audience->getName() == 'Spanish speaking San Franciscans');        
     }
     
     public function testCreate()
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
         $createdAudience = $result->getPayload();
         
         $this->assertTrue($createdAudience instanceOf Audience);
-        $this->assertTrue($createdAudience->getName()=='Spanish speaking San Franciscans');                
+        $this->assertTrue($createdAudience->getName() == 'Spanish speaking San Franciscans');                
     }
     
     public function testUpdate()
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
         $createdAudience = $result->getPayload();
         
         $this->assertTrue($createdAudience instanceOf Audience);
-        $this->assertTrue($createdAudience->getName()=='Spanish speaking San Franciscans');                
+        $this->assertTrue($createdAudience->getName() == 'Spanish speaking San Franciscans');                
     }
     
     public function testIntegration()
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
         $credentials = $this->loadCredentialsFromFile();
         
         $optimizelyClient = new OptimizelyApiClient($credentials, 'v2');
-        $this->assertTrue($optimizelyClient!=null);
+        $this->assertTrue($optimizelyClient != null);
         
         // Create new project        
         $curDate = date('Y-m-d H:i:s');
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
         $createdAudience = $result->getPayload();
         
         $this->assertTrue($createdAudience instanceOf Audience);
-        $this->assertTrue($createdAudience->getName()=='Spanish speaking San Franciscans');  
+        $this->assertTrue($createdAudience->getName() == 'Spanish speaking San Franciscans');  
         
         // List all existing audiences and try to find the created audience
         $audienceFound = false;        
@@ -295,16 +295,16 @@  discard block
 block discarded – undo
                 $audiences = $result->getPayload();
 
                 foreach ($audiences as $audience) {
-                    if ($audience->getName()=="Spanish speaking San Franciscans") {
+                    if ($audience->getName() == "Spanish speaking San Franciscans") {
                         $audienceFound = true;
                         break;
                     }
                 }
 
-                if ($result->getNextPage()==null)
+                if ($result->getNextPage() == null)
                     break;
 
-                $page ++;
+                $page++;
             }
         }
         catch (Exception $e) {
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
         $updatedAudience = $result->getPayload();                
         
         $this->assertTrue($updatedAudience instanceOf Audience);
-        $this->assertTrue($updatedAudience->getName()=='Some new audience name');  
+        $this->assertTrue($updatedAudience->getName() == 'Some new audience name');  
         
         // Make project archived
         

Please login to merge, or discard this patch.

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -238,8 +238,9 @@  discard block
 block discarded – undo
     
     public function testIntegration()
     {
-        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) 
-            $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
+                    $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        }
         
         $credentials = $this->loadCredentialsFromFile();
         
@@ -301,13 +302,13 @@  discard block
 block discarded – undo
                     }
                 }
 
-                if ($result->getNextPage()==null)
-                    break;
+                if ($result->getNextPage()==null) {
+                                    break;
+                }
 
                 $page ++;
             }
-        }
-        catch (Exception $e) {
+        } catch (Exception $e) {
             // Handle error.
             $code = $e->getCode();
             $httpCode = $e->getHttpCode();

Please login to merge, or discard this patch.

tests/OptimizelyPHPTest/Service/v2/EventsTest.php 3 patches

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -49,9 +49,9 @@  discard block
 block discarded – undo
         $result = $eventsService->listAll(1000, true);
         $events = $result->getPayload();
         
-        $this->assertTrue(count($events)==1);
+        $this->assertTrue(count($events) == 1);
         $this->assertTrue($events[0] instanceOf Event);
-        $this->assertTrue($events[0]->getName()=='Add to Cart');        
+        $this->assertTrue($events[0]->getName() == 'Add to Cart');        
     }
     
     public function testGet()
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
         $event = $result->getPayload();
         
         $this->assertTrue($event instanceOf Event);
-        $this->assertTrue($event->getName()=='Add to Cart');        
+        $this->assertTrue($event->getName() == 'Add to Cart');        
     }
     
     public function testCreateClickEvent()
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
         $createdEvent = $result->getPayload();
         
         $this->assertTrue($createdEvent instanceOf ClickEvent);
-        $this->assertTrue($createdEvent->getName()=='Add to Cart');                
+        $this->assertTrue($createdEvent->getName() == 'Add to Cart');                
     }
     
     public function testCreateCustomEvent()
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
         $createdEvent = $result->getPayload();
         
         $this->assertTrue($createdEvent instanceOf CustomEvent);
-        $this->assertTrue($createdEvent->getName()=='Loaded New App');                
+        $this->assertTrue($createdEvent->getName() == 'Loaded New App');                
     }
     
     public function testUpdateClickEvent()
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
         $updatedEvent = $result->getPayload();
         
         $this->assertTrue($updatedEvent instanceOf ClickEvent);
-        $this->assertTrue($updatedEvent->getName()=='Add to Cart');                
+        $this->assertTrue($updatedEvent->getName() == 'Add to Cart');                
     }
     
     public function testUpdateCustomEvent()
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
         $updatedEvent = $result->getPayload();
         
         $this->assertTrue($updatedEvent instanceOf CustomEvent);
-        $this->assertTrue($updatedEvent->getName()=='Loaded New App');                
+        $this->assertTrue($updatedEvent->getName() == 'Loaded New App');                
     }
     
     public function testIntegration()
@@ -288,7 +288,7 @@  discard block
 block discarded – undo
         $credentials = $this->loadCredentialsFromFile();
         
         $optimizelyClient = new OptimizelyApiClient($credentials, 'v2');
-        $this->assertTrue($optimizelyClient!=null);
+        $this->assertTrue($optimizelyClient != null);
         
         // Create new project        
         $curDate = date('Y-m-d H:i:s');
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
         $createdPage = $result->getPayload();
         
         $this->assertTrue($createdPage instanceOf Page);
-        $this->assertTrue($createdPage->getName()=='Home Page'); 
+        $this->assertTrue($createdPage->getName() == 'Home Page'); 
         
         // Create new event in the project
         $event = new ClickEvent(array(
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
         $createdEvent = $result->getPayload();
         
         $this->assertTrue($createdEvent instanceOf ClickEvent);
-        $this->assertTrue($createdEvent->getName()=='Add to Cart');  
+        $this->assertTrue($createdEvent->getName() == 'Add to Cart');  
         
         // List all existing events and try to find the created event
         $eventFound = false;        
@@ -372,16 +372,16 @@  discard block
 block discarded – undo
                 $events = $result->getPayload();
 
                 foreach ($events as $event) {
-                    if ($event->getName()=="Add to Cart") {
+                    if ($event->getName() == "Add to Cart") {
                         $eventFound = true;
                         break;
                     }
                 }
 
-                if ($result->getNextPage()==null)
+                if ($result->getNextPage() == null)
                     break;
 
-                $page ++;
+                $page++;
             }
         }
         catch (Exception $e) {
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
         $updatedEvent = $result->getPayload();                
         
         $this->assertTrue($updatedEvent instanceOf Event);
-        $this->assertTrue($updatedEvent->getName()=='Add to Cart 2');  
+        $this->assertTrue($updatedEvent->getName() == 'Add to Cart 2');  
         
         // Make project archived
         

Please login to merge, or discard this patch.

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -238,8 +238,9 @@  discard block
 block discarded – undo
     
     public function testIntegration()
     {
-        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) 
-            $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
+                    $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        }
         
         $credentials = $this->loadCredentialsFromFile();
         
@@ -301,13 +302,13 @@  discard block
 block discarded – undo
                     }
                 }
 
-                if ($result->getNextPage()==null)
-                    break;
+                if ($result->getNextPage()==null) {
+                                    break;
+                }
 
                 $page ++;
             }
-        }
-        catch (Exception $e) {
+        } catch (Exception $e) {
             // Handle error.
             $code = $e->getCode();
             $httpCode = $e->getHttpCode();

Please login to merge, or discard this patch.

Indentation +70 added lines, -70 removed lines patch added patch discarded remove patch

@@ -26,8 +26,8 @@  discard block
 block discarded – undo
                             "category" => "add_to_cart",
                             "description" => "Item added to cart",
                             "event_filter" => array(
-                              "filter_type" => "target_selector",
-                              "selector" => ".menu-options"
+                                "filter_type" => "target_selector",
+                                "selector" => ".menu-options"
                             ),
                             "event_type" => "custom",
                             "key" => "add_to_cart",
@@ -66,8 +66,8 @@  discard block
 block discarded – undo
                             "category" => "add_to_cart",
                             "description" => "Item added to cart",
                             "event_filter" => array(
-                              "filter_type" => "target_selector",
-                              "selector" => ".menu-options"
+                                "filter_type" => "target_selector",
+                                "selector" => ".menu-options"
                             ),
                             "event_type" => "custom",
                             "key" => "add_to_cart",
@@ -100,22 +100,22 @@  discard block
 block discarded – undo
                             ->getMock();
 
         $result = new Result(array(
-                              "event_filter" => array(
+                                "event_filter" => array(
                                 "filter_type" => "target_selector",
                                 "selector" => ".menu-options"
-                              ),
-                              "name" => "Add to Cart",
-                              "archived" => true,
-                              "category" => "add_to_cart",
-                              "description" => "string",
-                              "event_type" => "click",
-                              "key" => "add_to_cart",
-                              "created" => "2016-10-18T05:07:04.153Z",
-                              "id" => 0,
-                              "is_classic" => false,
-                              "is_editable" => true,
-                              "page_id" => 0,
-                              "project_id" => 1000
+                                ),
+                                "name" => "Add to Cart",
+                                "archived" => true,
+                                "category" => "add_to_cart",
+                                "description" => "string",
+                                "event_type" => "click",
+                                "key" => "add_to_cart",
+                                "created" => "2016-10-18T05:07:04.153Z",
+                                "id" => 0,
+                                "is_classic" => false,
+                                "is_editable" => true,
+                                "page_id" => 0,
+                                "project_id" => 1000
                         ), 201);
         
         $optimizelyApiClientMock->method('sendApiRequest')
@@ -124,16 +124,16 @@  discard block
 block discarded – undo
         $eventsService = new Events($optimizelyApiClientMock);
         
         $event = new ClickEvent(array(
-              "event_filter" => array(
+                "event_filter" => array(
                 "filter_type" => "target_selector",
                 "selector" => ".menu-options"
-              ),
-              "name" => "Add to Cart",
-              "archived" => true,
-              "category" => "add_to_cart",
-              "description" => "string",
-              "event_type" => "click",
-              "key" => "add_to_cart"
+                ),
+                "name" => "Add to Cart",
+                "archived" => true,
+                "category" => "add_to_cart",
+                "description" => "string",
+                "event_type" => "click",
+                "key" => "add_to_cart"
         ));
         
         $result = $eventsService->createClickEvent(0, $event);
@@ -194,22 +194,22 @@  discard block
 block discarded – undo
                             ->getMock();
 
         $result = new Result(array(
-                              "event_filter" => array(
+                                "event_filter" => array(
                                 "filter_type" => "target_selector",
                                 "selector" => ".menu-options"
-                              ),
-                              "name" => "Add to Cart",
-                              "archived" => true,
-                              "category" => "add_to_cart",
-                              "description" => "string",
-                              "event_type" => "click",
-                              "key" => "add_to_cart",
-                              "created" => "2016-10-18T05:07:04.153Z",
-                              "id" => 0,
-                              "is_classic" => false,
-                              "is_editable" => true,
-                              "page_id" => 0,
-                              "project_id" => 1000
+                                ),
+                                "name" => "Add to Cart",
+                                "archived" => true,
+                                "category" => "add_to_cart",
+                                "description" => "string",
+                                "event_type" => "click",
+                                "key" => "add_to_cart",
+                                "created" => "2016-10-18T05:07:04.153Z",
+                                "id" => 0,
+                                "is_classic" => false,
+                                "is_editable" => true,
+                                "page_id" => 0,
+                                "project_id" => 1000
                         ), 200);
         
         $optimizelyApiClientMock->method('sendApiRequest')
@@ -218,16 +218,16 @@  discard block
 block discarded – undo
         $eventsService = new Events($optimizelyApiClientMock);
         
         $event = new ClickEvent(array(
-              "event_filter" => array(
+                "event_filter" => array(
                 "filter_type" => "target_selector",
                 "selector" => ".menu-options"
-              ),
-              "name" => "Add to Cart",
-              "archived" => true,
-              "category" => "add_to_cart",
-              "description" => "string",
-              "event_type" => "click",
-              "key" => "add_to_cart"
+                ),
+                "name" => "Add to Cart",
+                "archived" => true,
+                "category" => "add_to_cart",
+                "description" => "string",
+                "event_type" => "click",
+                "key" => "add_to_cart"
         ));
         
         $result = $eventsService->updateClickEvent(0, 0, $event);
@@ -299,14 +299,14 @@  discard block
 block discarded – undo
             "platform" => "web",
             "status" => "active",
             "web_snippet" => array(
-              "enable_force_variation" => false,
-              "exclude_disabled_experiments" => false,
-              "exclude_names" => true,
-              "include_jquery" => true,
-              "ip_anonymization" => false,
-              "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
-              "library" => "jquery-1.11.3-trim",
-              "project_javascript" => "alert(\"Active Experiment\")"
+                "enable_force_variation" => false,
+                "exclude_disabled_experiments" => false,
+                "exclude_names" => true,
+                "include_jquery" => true,
+                "ip_anonymization" => false,
+                "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
+                "library" => "jquery-1.11.3-trim",
+                "project_javascript" => "alert(\"Active Experiment\")"
             )
         ));
         
@@ -338,22 +338,22 @@  discard block
 block discarded – undo
         
         // Create new event in the project
         $event = new ClickEvent(array(
-              "event_filter" => array(
+                "event_filter" => array(
                 "filter_type" => "target_selector",
                 "selector" => ".menu-options"
-              ),
-              "name" => "Add to Cart",
-              "archived" => true,
-              "category" => "add_to_cart",
-              "description" => "Some simple event",
-              "event_type" => "click",
-              "key" => "add_to_cart",
-              "created" => "2016-10-18T05:07:04.153Z",
-              "id" => 0,
-              "is_classic" => false,
-              //"is_editable" => true,
-              "page_id" => $createdPage->getId(),
-              "project_id" => $createdProject->getId()
+                ),
+                "name" => "Add to Cart",
+                "archived" => true,
+                "category" => "add_to_cart",
+                "description" => "Some simple event",
+                "event_type" => "click",
+                "key" => "add_to_cart",
+                "created" => "2016-10-18T05:07:04.153Z",
+                "id" => 0,
+                "is_classic" => false,
+                //"is_editable" => true,
+                "page_id" => $createdPage->getId(),
+                "project_id" => $createdProject->getId()
         ));
         
         $result = $optimizelyClient->events()->createClickEvent($createdPage->getId(), $event);

Please login to merge, or discard this patch.

tests/OptimizelyPHPTest/Service/v2/AttributesTest.php 3 patches

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -205,14 +205,14 @@
 block discarded – undo
             "platform" => "web",
             "status" => "active",
             "web_snippet" => array(
-              "enable_force_variation" => false,
-              "exclude_disabled_experiments" => false,
-              "exclude_names" => true,
-              "include_jquery" => true,
-              "ip_anonymization" => false,
-              "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
-              "library" => "jquery-1.11.3-trim",
-              "project_javascript" => "alert(\"Active Experiment\")"
+                "enable_force_variation" => false,
+                "exclude_disabled_experiments" => false,
+                "exclude_names" => true,
+                "include_jquery" => true,
+                "ip_anonymization" => false,
+                "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
+                "library" => "jquery-1.11.3-trim",
+                "project_javascript" => "alert(\"Active Experiment\")"
             )
         ));
         

Please login to merge, or discard this patch.

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -238,8 +238,9 @@  discard block
 block discarded – undo
     
     public function testIntegration()
     {
-        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) 
-            $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
+                    $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        }
         
         $credentials = $this->loadCredentialsFromFile();
         
@@ -301,13 +302,13 @@  discard block
 block discarded – undo
                     }
                 }
 
-                if ($result->getNextPage()==null)
-                    break;
+                if ($result->getNextPage()==null) {
+                                    break;
+                }
 
                 $page ++;
             }
-        }
-        catch (Exception $e) {
+        } catch (Exception $e) {
             // Handle error.
             $code = $e->getCode();
             $httpCode = $e->getHttpCode();

Please login to merge, or discard this patch.

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -39,9 +39,9 @@  discard block
 block discarded – undo
         $result = $attributesService->listAll(0);
         $attributes = $result->getPayload();
         
-        $this->assertTrue(count($attributes)==1);
+        $this->assertTrue(count($attributes) == 1);
         $this->assertTrue($attributes[0] instanceOf Attribute);
-        $this->assertTrue($attributes[0]->getName()=='Subscriber Status');        
+        $this->assertTrue($attributes[0]->getName() == 'Subscriber Status');        
     }
     
     /**
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
         $attribute = $result->getPayload();
         
         $this->assertTrue($attribute instanceOf Attribute);
-        $this->assertTrue($attribute->getName()=='Subscriber Status');        
+        $this->assertTrue($attribute->getName() == 'Subscriber Status');        
     }
     
     public function testCreate()
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
         $createdAttribute = $result->getPayload();
         
         $this->assertTrue($createdAttribute instanceOf Attribute);
-        $this->assertTrue($createdAttribute->getName()=='Subscriber Status');                
+        $this->assertTrue($createdAttribute->getName() == 'Subscriber Status');                
     }
     
     public function testUpdate()
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
         $createdAttribute = $result->getPayload();
         
         $this->assertTrue($createdAttribute instanceOf Attribute);
-        $this->assertTrue($createdAttribute->getName()=='Subscriber Status');                
+        $this->assertTrue($createdAttribute->getName() == 'Subscriber Status');                
     }
     
     public function testIntegration()
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
         $credentials = $this->loadCredentialsFromFile();
         
         $optimizelyClient = new OptimizelyApiClient($credentials, 'v2');
-        $this->assertTrue($optimizelyClient!=null);
+        $this->assertTrue($optimizelyClient != null);
         
         // Create new project        
         $curDate = date('Y-m-d H:i:s');
@@ -235,7 +235,7 @@  discard block
 block discarded – undo
         $createdAttribute = $result->getPayload();
         
         $this->assertTrue($createdAttribute instanceOf Attribute);
-        $this->assertTrue($createdAttribute->getName()=='Subscriber Status');  
+        $this->assertTrue($createdAttribute->getName() == 'Subscriber Status');  
         
         // List all existing attributes and try to find the created attribute
         $attributeFound = false;        
@@ -247,16 +247,16 @@  discard block
 block discarded – undo
                 $attributes = $result->getPayload();
 
                 foreach ($attributes as $attribute) {
-                    if ($attribute->getName()=="Subscriber Status") {
+                    if ($attribute->getName() == "Subscriber Status") {
                         $attributeFound = true;
                         break;
                     }
                 }
 
-                if ($result->getNextPage()==null)
+                if ($result->getNextPage() == null)
                     break;
 
-                $page ++;
+                $page++;
             }
         }
         catch (Exception $e) {
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
         $updatedAttribute = $result->getPayload();                
         
         $this->assertTrue($updatedAttribute instanceOf Attribute);
-        $this->assertTrue($updatedAttribute->getName()=='Some new attribute name');  
+        $this->assertTrue($updatedAttribute->getName() == 'Some new attribute name');  
         
         // Make project archived
         

Please login to merge, or discard this patch.

tests/OptimizelyPHPTest/Service/v2/PagesTest.php 3 patches

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -43,9 +43,9 @@  discard block
 block discarded – undo
         $result = $pagesService->listAll(1000);
         $pages = $result->getPayload();
         
-        $this->assertTrue(count($pages)==1);
+        $this->assertTrue(count($pages) == 1);
         $this->assertTrue($pages[0] instanceOf Page);
-        $this->assertTrue($pages[0]->getName()=='Home Page');        
+        $this->assertTrue($pages[0]->getName() == 'Home Page');        
     }
     
     public function testGet()
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
         $createdPage = $result->getPayload();
         
         $this->assertTrue($createdPage instanceOf Page);
-        $this->assertTrue($createdPage->getName()=='Home Page');                
+        $this->assertTrue($createdPage->getName() == 'Home Page');                
     }
     
     public function testUpdate()
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
         $updatedPage = $result->getPayload();
         
         $this->assertTrue($updatedPage instanceOf Page);
-        $this->assertTrue($updatedPage->getName()=='Home Page');                  
+        $this->assertTrue($updatedPage->getName() == 'Home Page');                  
     }
     
     public function testDelete()
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
         $credentials = $this->loadCredentialsFromFile();
         
         $optimizelyClient = new OptimizelyApiClient($credentials, 'v2');
-        $this->assertTrue($optimizelyClient!=null);
+        $this->assertTrue($optimizelyClient != null);
         
         // Create new project        
         $curDate = date('Y-m-d H:i:s');
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
         $createdPage = $result->getPayload();
         
         $this->assertTrue($createdPage instanceOf Page);
-        $this->assertTrue($createdPage->getName()=='Home Page');  
+        $this->assertTrue($createdPage->getName() == 'Home Page');  
         
         // List all existing pages and try to find the created page
         $pageFound = false;        
@@ -264,16 +264,16 @@  discard block
 block discarded – undo
                 $pages = $result->getPayload();
 
                 foreach ($pages as $pageObject) {
-                    if ($pageObject->getName()=="Home Page") {
+                    if ($pageObject->getName() == "Home Page") {
                         $pageFound = true;
                         break;
                     }
                 }
 
-                if ($result->getNextPage()==null)
+                if ($result->getNextPage() == null)
                     break;
 
-                $page ++;
+                $page++;
             }
         }
         catch (Exception $e) {
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
         $updatedPage = $result->getPayload();                
         
         $this->assertTrue($updatedPage instanceOf Page);
-        $this->assertTrue($updatedPage->getName()=='Some new page name');  
+        $this->assertTrue($updatedPage->getName() == 'Some new page name');  
         
         // Make project archived
         

Please login to merge, or discard this patch.

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -205,14 +205,14 @@
 block discarded – undo
             "platform" => "web",
             "status" => "active",
             "web_snippet" => array(
-              "enable_force_variation" => false,
-              "exclude_disabled_experiments" => false,
-              "exclude_names" => true,
-              "include_jquery" => true,
-              "ip_anonymization" => false,
-              "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
-              "library" => "jquery-1.11.3-trim",
-              "project_javascript" => "alert(\"Active Experiment\")"
+                "enable_force_variation" => false,
+                "exclude_disabled_experiments" => false,
+                "exclude_names" => true,
+                "include_jquery" => true,
+                "ip_anonymization" => false,
+                "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
+                "library" => "jquery-1.11.3-trim",
+                "project_javascript" => "alert(\"Active Experiment\")"
             )
         ));
         

Please login to merge, or discard this patch.

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -238,8 +238,9 @@  discard block
 block discarded – undo
     
     public function testIntegration()
     {
-        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) 
-            $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
+                    $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        }
         
         $credentials = $this->loadCredentialsFromFile();
         
@@ -301,13 +302,13 @@  discard block
 block discarded – undo
                     }
                 }
 
-                if ($result->getNextPage()==null)
-                    break;
+                if ($result->getNextPage()==null) {
+                                    break;
+                }
 
                 $page ++;
             }
-        }
-        catch (Exception $e) {
+        } catch (Exception $e) {
             // Handle error.
             $code = $e->getCode();
             $httpCode = $e->getHttpCode();

Please login to merge, or discard this patch.

lib/WebMarketingROI/OptimizelyPHP/Resource/v2/InPageEventConfig.php 2 patches

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -28,7 +28,7 @@  discard block
 block discarded – undo
             switch ($name) {                
                 case 'selector': $this->setSelector($value); break;
                 default:
-                    throw new Exception('Unknown option found in the InPageConfig entity: ' . $name);
+                    throw new Exception('Unknown option found in the InPageConfig entity: '.$name);
             }
         }
     }
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
         // Remove options with empty values
         $cleanedOptions = array();
         foreach ($options as $name=>$value) {
-            if ($value!==null)
+            if ($value !== null)
                 $cleanedOptions[$name] = $value;
         }
         

Please login to merge, or discard this patch.

Braces +3 added lines, -2 removed lines patch added patch discarded remove patch

@@ -91,8 +91,9 @@
 block discarded – undo
         // Remove options with empty values
         $cleanedOptions = array();
         foreach ($options as $name=>$value) {
-            if ($value!==null)
-                $cleanedOptions[$name] = $value;
+            if ($value!==null) {
+                            $cleanedOptions[$name] = $value;
+            }
         }
         
         return $cleanedOptions;

Please login to merge, or discard this patch.

		@@ -238,8 +238,9 @@ discard block
		block discarded – undo
238	238
239	239	public function testIntegration()
240	240	{
241		- if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION'))
242		- $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	241	+ if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
	242	+ $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	243	+ }
243	244
244	245	$credentials = $this->loadCredentialsFromFile();
245	246
		@@ -301,13 +302,13 @@ discard block
		block discarded – undo
301	302	}
302	303	}
303	304
304		- if ($result->getNextPage()==null)
305		- break;
	305	+ if ($result->getNextPage()==null) {
	306	+ break;
	307	+ }
306	308
307	309	$page ++;
308	310	}
309		- }
310		- catch (Exception $e) {
	311	+ } catch (Exception $e) {
311	312	// Handle error.
312	313	$code = $e->getCode();
313	314	$httpCode = $e->getHttpCode();

		@@ -238,8 +238,9 @@ discard block
		block discarded – undo
238	238
239	239	public function testIntegration()
240	240	{
241		- if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION'))
242		- $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	241	+ if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
	242	+ $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	243	+ }
243	244
244	245	$credentials = $this->loadCredentialsFromFile();
245	246
		@@ -301,13 +302,13 @@ discard block
		block discarded – undo
301	302	}
302	303	}
303	304
304		- if ($result->getNextPage()==null)
305		- break;
	305	+ if ($result->getNextPage()==null) {
	306	+ break;
	307	+ }
306	308
307	309	$page ++;
308	310	}
309		- }
310		- catch (Exception $e) {
	311	+ } catch (Exception $e) {
311	312	// Handle error.
312	313	$code = $e->getCode();
313	314	$httpCode = $e->getHttpCode();

		@@ -238,8 +238,9 @@ discard block
		block discarded – undo
238	238
239	239	public function testIntegration()
240	240	{
241		- if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION'))
242		- $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	241	+ if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
	242	+ $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	243	+ }
243	244
244	245	$credentials = $this->loadCredentialsFromFile();
245	246
		@@ -301,13 +302,13 @@ discard block
		block discarded – undo
301	302	}
302	303	}
303	304
304		- if ($result->getNextPage()==null)
305		- break;
	305	+ if ($result->getNextPage()==null) {
	306	+ break;
	307	+ }
306	308
307	309	$page ++;
308	310	}
309		- }
310		- catch (Exception $e) {
	311	+ } catch (Exception $e) {
311	312	// Handle error.
312	313	$code = $e->getCode();
313	314	$httpCode = $e->getHttpCode();

		@@ -238,8 +238,9 @@ discard block
		block discarded – undo
238	238
239	239	public function testIntegration()
240	240	{
241		- if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION'))
242		- $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	241	+ if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
	242	+ $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	243	+ }
243	244
244	245	$credentials = $this->loadCredentialsFromFile();
245	246
		@@ -301,13 +302,13 @@ discard block
		block discarded – undo
301	302	}
302	303	}
303	304
304		- if ($result->getNextPage()==null)
305		- break;
	305	+ if ($result->getNextPage()==null) {
	306	+ break;
	307	+ }
306	308
307	309	$page ++;
308	310	}
309		- }
310		- catch (Exception $e) {
	311	+ } catch (Exception $e) {
311	312	// Handle error.
312	313	$code = $e->getCode();
313	314	$httpCode = $e->getHttpCode();

		@@ -113,14 +113,14 @@ discard block
		block discarded – undo
113	113	$options = array(
114	114	"project_id" => 1000,
115	115	"audience_ids" => array(
116		- 1234,
117		- 1212,
118		- 1432
	116	+ 1234,
	117	+ 1212,
	118	+ 1432
119	119	),
120	120	"campaign_id" => 2000,
121	121	"audience_conditions" => "[\"and\", {\"audience_id\": 7000}, {\"audience_id\":7001}]",
122	122	"changes" => array(
123		- array(
	123	+ array(
124	124	"type" => "custom_code",
125	125	"allow_additional_redirect" => true,
126	126	"async" => true,
		@@ -135,8 +135,8 @@ discard block
		block discarded – undo
135	135	"text" => "Some nice message"
136	136	),
137	137	"dependencies" => array(
138		- 24,
139		- 26
	138	+ 24,
	139	+ 26
140	140	),
141	141	"destination" => "https://app.optimizely.com/",
142	142	"extension_id" => 1234,
		@@ -145,57 +145,57 @@ discard block
		block discarded – undo
145	145	"selector" => "a[href*=\"optimizely\"]",
146	146	"src" => 524,
147	147	"value" => "window.someGlobalFunction();"
148		- )
	148	+ )
149	149	),
150	150	"type" => "a/b",
151	151	"description" => "string",
152	152	"holdback" => 5000,
153	153	"key" => "home_page_experiment",
154	154	"metrics" => array(
155		- array(
	155	+ array(
156	156	"aggregator" => "unique",
157	157	"event_id" => 0,
158	158	"field" => "revenue",
159	159	"scope" => "session"
160		- )
	160	+ )
161	161	),
162	162	"name" => "Blue Button Experiment",
163	163	"schedule" => array(
164		- "start_time" => "2016-10-14T05:08:42.850Z",
165		- "stop_time" => "2016-10-14T05:08:42.850Z",
166		- "time_zone" => "UTC"
	164	+ "start_time" => "2016-10-14T05:08:42.850Z",
	165	+ "stop_time" => "2016-10-14T05:08:42.850Z",
	166	+ "time_zone" => "UTC"
167	167	),
168	168	"status" => "active",
169	169	"variations" => array(
170		- array(
	170	+ array(
171	171	"actions" => array(
172		- array(
	172	+ array(
173	173	"changes" => array(
174		- array(
	174	+ array(
175	175	"type" => "custom_code",
176	176	"allow_additional_redirect" => true,
177	177	"async" => true,
178	178	"selector" => "a[href*=\"optimizely\"]",
179	179	"dependencies" => array(
180		- 24,
181		- 26
	180	+ 24,
	181	+ 26
182	182	),
183	183	"destination" => "https://app.optimizely.com/",
184	184	"extension_id" => 1234,
185	185	"preserve_parameters" => true,
186	186	"src" => 524,
187	187	"value" => "window.someGlobalFunction();"
188		- )
	188	+ )
189	189	),
190	190	"page_id" => 0
191		- )
	191	+ )
192	192	),
193	193	"archived" => true,
194	194	"key" => "blue_button_variation",
195	195	"name" => "Blue Button",
196	196	"variation_id" => 0,
197	197	"weight" => 0,
198		- )
	198	+ )
199	199	)
200	200	);
201	201
		@@ -210,13 +210,13 @@ discard block
		block discarded – undo
210	210	$options = array(
211	211	"project_id" => 1000,
212	212	"audience_ids" => array(
213		- 1234,
214		- 1212,
215		- 1432
	213	+ 1234,
	214	+ 1212,
	215	+ 1432
216	216	),
217	217	"campaign_id" => 2000,
218	218	"changes" => array(
219		- array(
	219	+ array(
220	220	"type" => "custom_code",
221	221	"allow_additional_redirect" => true,
222	222	"async" => true,
		@@ -232,64 +232,64 @@ discard block
		block discarded – undo
232	232	),
233	233	"selector" => "a[href*=\"optimizely\"]",
234	234	"dependencies" => array(
235		- 24,
236		- 26
	235	+ 24,
	236	+ 26
237	237	),
238	238	"destination" => "https://app.optimizely.com/",
239	239	"extension_id" => 1234,
240	240	"preserve_parameters" => true,
241	241	"src" => 524,
242	242	"value" => "window.someGlobalFunction();"
243		- )
	243	+ )
244	244	),
245	245	"description" => "string",
246	246	"holdback" => 5000,
247	247	"key" => "home_page_experiment",
248	248	"metrics" => array(
249		- array(
	249	+ array(
250	250	"aggregator" => "unique",
251	251	"event_id" => 0,
252	252	"field" => "revenue",
253	253	"scope" => "session"
254		- )
	254	+ )
255	255	),
256	256	"name" => "Blue Button Experiment",
257	257	"schedule" => array(
258		- "start_time" => "2016-10-14T05:08:42.850Z",
259		- "stop_time" => "2016-10-14T05:08:42.850Z",
260		- "time_zone" => "UTC"
	258	+ "start_time" => "2016-10-14T05:08:42.850Z",
	259	+ "stop_time" => "2016-10-14T05:08:42.850Z",
	260	+ "time_zone" => "UTC"
261	261	),
262	262	"status" => "active",
263	263	"variations" => array(
264		- array(
	264	+ array(
265	265	"actions" => array(
266		- array(
	266	+ array(
267	267	"changes" => array(
268		- array(
	268	+ array(
269	269	"type" => "custom_code",
270	270	"allow_additional_redirect" => true,
271	271	"async" => true,
272	272	"selector" => "a[href*=\"optimizely\"]",
273	273	"dependencies" => array(
274		- 24,
275		- 26
	274	+ 24,
	275	+ 26
276	276	),
277	277	"destination" => "https://app.optimizely.com/",
278	278	"extension_id" => 1234,
279	279	"preserve_parameters" => true,
280	280	"src" => 524,
281	281	"value" => "window.someGlobalFunction();"
282		- )
	282	+ )
283	283	),
284	284	"page_id" => 0
285		- )
	285	+ )
286	286	),
287	287	"archived" => true,
288	288	"key" => "blue_button_variation",
289	289	"name" => "Blue Button",
290	290	"variation_id" => 0,
291	291	"weight" => 0
292		- )
	292	+ )
293	293	)
294	294	);
295	295

		@@ -86,15 +86,15 @@ discard block
		block discarded – undo
86	86	"project_id" => 1000,
87	87	"archived" => false,
88	88	"conditions" => array(
89		- "and",
90		- array(
	89	+ "and",
	90	+ array(
91	91	"type" => "language",
92	92	"value" => "es"
93		- ),
94		- array(
	93	+ ),
	94	+ array(
95	95	"type" => "location",
96	96	"value" => "US-CA-SANFRANCISCO"
97		- )
	97	+ )
98	98	),
99	99	"description" => "People that speak spanish and are in San Francisco",
100	100	"name" => "Spanish speaking San Franciscans",
		@@ -127,15 +127,15 @@ discard block
		block discarded – undo
127	127	"project_id" => 1000,
128	128	"archived" => false,
129	129	"conditions" => array(
130		- "and",
131		- array(
	130	+ "and",
	131	+ array(
132	132	"type" => "language",
133	133	"value" => "es"
134		- ),
135		- array(
	134	+ ),
	135	+ array(
136	136	"type" => "location",
137	137	"value" => "US-CA-SANFRANCISCO"
138		- )
	138	+ )
139	139	),
140	140	"description" => "People that speak spanish and are in San Francisco",
141	141	"name" => "Spanish speaking San Franciscans",
		@@ -154,15 +154,15 @@ discard block
		block discarded – undo
154	154	"project_id" => 1000,
155	155	"archived" => false,
156	156	"conditions" => array(
157		- "and",
158		- array(
	157	+ "and",
	158	+ array(
159	159	"type" => "language",
160	160	"value" => "es"
161		- ),
162		- array(
	161	+ ),
	162	+ array(
163	163	"type" => "location",
164	164	"value" => "US-CA-SANFRANCISCO"
165		- )
	165	+ )
166	166	),
167	167	"description" => "People that speak spanish and are in San Francisco",
168	168	"name" => "Spanish speaking San Franciscans",
		@@ -187,15 +187,15 @@ discard block
		block discarded – undo
187	187	"project_id" => 1000,
188	188	"archived" => false,
189	189	"conditions" => array(
190		- "and",
191		- array(
	190	+ "and",
	191	+ array(
192	192	"type" => "language",
193	193	"value" => "es"
194		- ),
195		- array(
	194	+ ),
	195	+ array(
196	196	"type" => "location",
197	197	"value" => "US-CA-SANFRANCISCO"
198		- )
	198	+ )
199	199	),
200	200	"description" => "People that speak spanish and are in San Francisco",
201	201	"name" => "Spanish speaking San Franciscans",
		@@ -214,15 +214,15 @@ discard block
		block discarded – undo
214	214	"project_id" => 1000,
215	215	"archived" => false,
216	216	"conditions" => array(
217		- "and",
218		- array(
	217	+ "and",
	218	+ array(
219	219	"type" => "language",
220	220	"value" => "es"
221		- ),
222		- array(
	221	+ ),
	222	+ array(
223	223	"type" => "location",
224	224	"value" => "US-CA-SANFRANCISCO"
225		- )
	225	+ )
226	226	),
227	227	"description" => "People that speak spanish and are in San Francisco",
228	228	"name" => "Spanish speaking San Franciscans",
		@@ -255,14 +255,14 @@ discard block
		block discarded – undo
255	255	"platform" => "web",
256	256	"status" => "active",
257	257	"web_snippet" => array(
258		- "enable_force_variation" => false,
259		- "exclude_disabled_experiments" => false,
260		- "exclude_names" => true,
261		- "include_jquery" => true,
262		- "ip_anonymization" => false,
263		- "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]\|1([0-4][0-9]\|50))$",
264		- "library" => "jquery-1.11.3-trim",
265		- "project_javascript" => "alert(\"Active Experiment\")"
	258	+ "enable_force_variation" => false,
	259	+ "exclude_disabled_experiments" => false,
	260	+ "exclude_names" => true,
	261	+ "include_jquery" => true,
	262	+ "ip_anonymization" => false,
	263	+ "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]\|1([0-4][0-9]\|50))$",
	264	+ "library" => "jquery-1.11.3-trim",
	265	+ "project_javascript" => "alert(\"Active Experiment\")"
266	266	)
267	267	));
268	268

		@@ -40,9 +40,9 @@ discard block
		block discarded – undo
40	40	$result = $audiencesService->listAll(1000);
41	41	$audiences = $result->getPayload();
42	42
43		- $this->assertTrue(count($audiences)==1);
	43	+ $this->assertTrue(count($audiences) == 1);
44	44	$this->assertTrue($audiences[0] instanceOf Audience);
45		- $this->assertTrue($audiences[0]->getName()=='Spanish speaking San Franciscans');
	45	+ $this->assertTrue($audiences[0]->getName() == 'Spanish speaking San Franciscans');
46	46	}
47	47
48	48	/**
		@@ -113,7 +113,7 @@ discard block
		block discarded – undo
113	113	$audience = $result->getPayload();
114	114
115	115	$this->assertTrue($audience instanceOf Audience);
116		- $this->assertTrue($audience->getName()=='Spanish speaking San Franciscans');
	116	+ $this->assertTrue($audience->getName() == 'Spanish speaking San Franciscans');
117	117	}
118	118
119	119	public function testCreate()
		@@ -173,7 +173,7 @@ discard block
		block discarded – undo
173	173	$createdAudience = $result->getPayload();
174	174
175	175	$this->assertTrue($createdAudience instanceOf Audience);
176		- $this->assertTrue($createdAudience->getName()=='Spanish speaking San Franciscans');
	176	+ $this->assertTrue($createdAudience->getName() == 'Spanish speaking San Franciscans');
177	177	}
178	178
179	179	public function testUpdate()
		@@ -233,7 +233,7 @@ discard block
		block discarded – undo
233	233	$createdAudience = $result->getPayload();
234	234
235	235	$this->assertTrue($createdAudience instanceOf Audience);
236		- $this->assertTrue($createdAudience->getName()=='Spanish speaking San Franciscans');
	236	+ $this->assertTrue($createdAudience->getName() == 'Spanish speaking San Franciscans');
237	237	}
238	238
239	239	public function testIntegration()
		@@ -244,7 +244,7 @@ discard block
		block discarded – undo
244	244	$credentials = $this->loadCredentialsFromFile();
245	245
246	246	$optimizelyClient = new OptimizelyApiClient($credentials, 'v2');
247		- $this->assertTrue($optimizelyClient!=null);
	247	+ $this->assertTrue($optimizelyClient != null);
248	248
249	249	// Create new project
250	250	$curDate = date('Y-m-d H:i:s');
		@@ -283,7 +283,7 @@ discard block
		block discarded – undo
283	283	$createdAudience = $result->getPayload();
284	284
285	285	$this->assertTrue($createdAudience instanceOf Audience);
286		- $this->assertTrue($createdAudience->getName()=='Spanish speaking San Franciscans');
	286	+ $this->assertTrue($createdAudience->getName() == 'Spanish speaking San Franciscans');
287	287
288	288	// List all existing audiences and try to find the created audience
289	289	$audienceFound = false;
		@@ -295,16 +295,16 @@ discard block
		block discarded – undo
295	295	$audiences = $result->getPayload();
296	296
297	297	foreach ($audiences as $audience) {
298		- if ($audience->getName()=="Spanish speaking San Franciscans") {
	298	+ if ($audience->getName() == "Spanish speaking San Franciscans") {
299	299	$audienceFound = true;
300	300	break;
301	301	}
302	302	}
303	303
304		- if ($result->getNextPage()==null)
	304	+ if ($result->getNextPage() == null)
305	305	break;
306	306
307		- $page ++;
	307	+ $page++;
308	308	}
309	309	}
310	310	catch (Exception $e) {
		@@ -324,7 +324,7 @@ discard block
		block discarded – undo
324	324	$updatedAudience = $result->getPayload();
325	325
326	326	$this->assertTrue($updatedAudience instanceOf Audience);
327		- $this->assertTrue($updatedAudience->getName()=='Some new audience name');
	327	+ $this->assertTrue($updatedAudience->getName() == 'Some new audience name');
328	328
329	329	// Make project archived
330	330

		@@ -49,9 +49,9 @@ discard block
		block discarded – undo
49	49	$result = $eventsService->listAll(1000, true);
50	50	$events = $result->getPayload();
51	51
52		- $this->assertTrue(count($events)==1);
	52	+ $this->assertTrue(count($events) == 1);
53	53	$this->assertTrue($events[0] instanceOf Event);
54		- $this->assertTrue($events[0]->getName()=='Add to Cart');
	54	+ $this->assertTrue($events[0]->getName() == 'Add to Cart');
55	55	}
56	56
57	57	public function testGet()
		@@ -89,7 +89,7 @@ discard block
		block discarded – undo
89	89	$event = $result->getPayload();
90	90
91	91	$this->assertTrue($event instanceOf Event);
92		- $this->assertTrue($event->getName()=='Add to Cart');
	92	+ $this->assertTrue($event->getName() == 'Add to Cart');
93	93	}
94	94
95	95	public function testCreateClickEvent()
		@@ -140,7 +140,7 @@ discard block
		block discarded – undo
140	140	$createdEvent = $result->getPayload();
141	141
142	142	$this->assertTrue($createdEvent instanceOf ClickEvent);
143		- $this->assertTrue($createdEvent->getName()=='Add to Cart');
	143	+ $this->assertTrue($createdEvent->getName() == 'Add to Cart');
144	144	}
145	145
146	146	public function testCreateCustomEvent()
		@@ -183,7 +183,7 @@ discard block
		block discarded – undo
183	183	$createdEvent = $result->getPayload();
184	184
185	185	$this->assertTrue($createdEvent instanceOf CustomEvent);
186		- $this->assertTrue($createdEvent->getName()=='Loaded New App');
	186	+ $this->assertTrue($createdEvent->getName() == 'Loaded New App');
187	187	}
188	188
189	189	public function testUpdateClickEvent()
		@@ -234,7 +234,7 @@ discard block
		block discarded – undo
234	234	$updatedEvent = $result->getPayload();
235	235
236	236	$this->assertTrue($updatedEvent instanceOf ClickEvent);
237		- $this->assertTrue($updatedEvent->getName()=='Add to Cart');
	237	+ $this->assertTrue($updatedEvent->getName() == 'Add to Cart');
238	238	}
239	239
240	240	public function testUpdateCustomEvent()
		@@ -277,7 +277,7 @@ discard block
		block discarded – undo
277	277	$updatedEvent = $result->getPayload();
278	278
279	279	$this->assertTrue($updatedEvent instanceOf CustomEvent);
280		- $this->assertTrue($updatedEvent->getName()=='Loaded New App');
	280	+ $this->assertTrue($updatedEvent->getName() == 'Loaded New App');
281	281	}
282	282
283	283	public function testIntegration()
		@@ -288,7 +288,7 @@ discard block
		block discarded – undo
288	288	$credentials = $this->loadCredentialsFromFile();
289	289
290	290	$optimizelyClient = new OptimizelyApiClient($credentials, 'v2');
291		- $this->assertTrue($optimizelyClient!=null);
	291	+ $this->assertTrue($optimizelyClient != null);
292	292
293	293	// Create new project
294	294	$curDate = date('Y-m-d H:i:s');
		@@ -334,7 +334,7 @@ discard block
		block discarded – undo
334	334	$createdPage = $result->getPayload();
335	335
336	336	$this->assertTrue($createdPage instanceOf Page);
337		- $this->assertTrue($createdPage->getName()=='Home Page');
	337	+ $this->assertTrue($createdPage->getName() == 'Home Page');
338	338
339	339	// Create new event in the project
340	340	$event = new ClickEvent(array(
		@@ -360,7 +360,7 @@ discard block
		block discarded – undo
360	360	$createdEvent = $result->getPayload();
361	361
362	362	$this->assertTrue($createdEvent instanceOf ClickEvent);
363		- $this->assertTrue($createdEvent->getName()=='Add to Cart');
	363	+ $this->assertTrue($createdEvent->getName() == 'Add to Cart');
364	364
365	365	// List all existing events and try to find the created event
366	366	$eventFound = false;
		@@ -372,16 +372,16 @@ discard block
		block discarded – undo
372	372	$events = $result->getPayload();
373	373
374	374	foreach ($events as $event) {
375		- if ($event->getName()=="Add to Cart") {
	375	+ if ($event->getName() == "Add to Cart") {
376	376	$eventFound = true;
377	377	break;
378	378	}
379	379	}
380	380
381		- if ($result->getNextPage()==null)
	381	+ if ($result->getNextPage() == null)
382	382	break;
383	383
384		- $page ++;
	384	+ $page++;
385	385	}
386	386	}
387	387	catch (Exception $e) {
		@@ -401,7 +401,7 @@ discard block
		block discarded – undo
401	401	$updatedEvent = $result->getPayload();
402	402
403	403	$this->assertTrue($updatedEvent instanceOf Event);
404		- $this->assertTrue($updatedEvent->getName()=='Add to Cart 2');
	404	+ $this->assertTrue($updatedEvent->getName() == 'Add to Cart 2');
405	405
406	406	// Make project archived
407	407

		@@ -26,8 +26,8 @@ discard block
		block discarded – undo
26	26	"category" => "add_to_cart",
27	27	"description" => "Item added to cart",
28	28	"event_filter" => array(
29		- "filter_type" => "target_selector",
30		- "selector" => ".menu-options"
	29	+ "filter_type" => "target_selector",
	30	+ "selector" => ".menu-options"
31	31	),
32	32	"event_type" => "custom",
33	33	"key" => "add_to_cart",
		@@ -66,8 +66,8 @@ discard block
		block discarded – undo
66	66	"category" => "add_to_cart",
67	67	"description" => "Item added to cart",
68	68	"event_filter" => array(
69		- "filter_type" => "target_selector",
70		- "selector" => ".menu-options"
	69	+ "filter_type" => "target_selector",
	70	+ "selector" => ".menu-options"
71	71	),
72	72	"event_type" => "custom",
73	73	"key" => "add_to_cart",
		@@ -100,22 +100,22 @@ discard block
		block discarded – undo
100	100	->getMock();
101	101
102	102	$result = new Result(array(
103		- "event_filter" => array(
	103	+ "event_filter" => array(
104	104	"filter_type" => "target_selector",
105	105	"selector" => ".menu-options"
106		- ),
107		- "name" => "Add to Cart",
108		- "archived" => true,
109		- "category" => "add_to_cart",
110		- "description" => "string",
111		- "event_type" => "click",
112		- "key" => "add_to_cart",
113		- "created" => "2016-10-18T05:07:04.153Z",
114		- "id" => 0,
115		- "is_classic" => false,
116		- "is_editable" => true,
117		- "page_id" => 0,
118		- "project_id" => 1000
	106	+ ),
	107	+ "name" => "Add to Cart",
	108	+ "archived" => true,
	109	+ "category" => "add_to_cart",
	110	+ "description" => "string",
	111	+ "event_type" => "click",
	112	+ "key" => "add_to_cart",
	113	+ "created" => "2016-10-18T05:07:04.153Z",
	114	+ "id" => 0,
	115	+ "is_classic" => false,
	116	+ "is_editable" => true,
	117	+ "page_id" => 0,
	118	+ "project_id" => 1000
119	119	), 201);
120	120
121	121	$optimizelyApiClientMock->method('sendApiRequest')
		@@ -124,16 +124,16 @@ discard block
		block discarded – undo
124	124	$eventsService = new Events($optimizelyApiClientMock);
125	125
126	126	$event = new ClickEvent(array(
127		- "event_filter" => array(
	127	+ "event_filter" => array(
128	128	"filter_type" => "target_selector",
129	129	"selector" => ".menu-options"
130		- ),
131		- "name" => "Add to Cart",
132		- "archived" => true,
133		- "category" => "add_to_cart",
134		- "description" => "string",
135		- "event_type" => "click",
136		- "key" => "add_to_cart"
	130	+ ),
	131	+ "name" => "Add to Cart",
	132	+ "archived" => true,
	133	+ "category" => "add_to_cart",
	134	+ "description" => "string",
	135	+ "event_type" => "click",
	136	+ "key" => "add_to_cart"
137	137	));
138	138
139	139	$result = $eventsService->createClickEvent(0, $event);
		@@ -194,22 +194,22 @@ discard block
		block discarded – undo
194	194	->getMock();
195	195
196	196	$result = new Result(array(
197		- "event_filter" => array(
	197	+ "event_filter" => array(
198	198	"filter_type" => "target_selector",
199	199	"selector" => ".menu-options"
200		- ),
201		- "name" => "Add to Cart",
202		- "archived" => true,
203		- "category" => "add_to_cart",
204		- "description" => "string",
205		- "event_type" => "click",
206		- "key" => "add_to_cart",
207		- "created" => "2016-10-18T05:07:04.153Z",
208		- "id" => 0,
209		- "is_classic" => false,
210		- "is_editable" => true,
211		- "page_id" => 0,
212		- "project_id" => 1000
	200	+ ),
	201	+ "name" => "Add to Cart",
	202	+ "archived" => true,
	203	+ "category" => "add_to_cart",
	204	+ "description" => "string",
	205	+ "event_type" => "click",
	206	+ "key" => "add_to_cart",
	207	+ "created" => "2016-10-18T05:07:04.153Z",
	208	+ "id" => 0,
	209	+ "is_classic" => false,
	210	+ "is_editable" => true,
	211	+ "page_id" => 0,
	212	+ "project_id" => 1000
213	213	), 200);
214	214
215	215	$optimizelyApiClientMock->method('sendApiRequest')
		@@ -218,16 +218,16 @@ discard block
		block discarded – undo
218	218	$eventsService = new Events($optimizelyApiClientMock);
219	219
220	220	$event = new ClickEvent(array(
221		- "event_filter" => array(
	221	+ "event_filter" => array(
222	222	"filter_type" => "target_selector",
223	223	"selector" => ".menu-options"
224		- ),
225		- "name" => "Add to Cart",
226		- "archived" => true,
227		- "category" => "add_to_cart",
228		- "description" => "string",
229		- "event_type" => "click",
230		- "key" => "add_to_cart"
	224	+ ),
	225	+ "name" => "Add to Cart",
	226	+ "archived" => true,
	227	+ "category" => "add_to_cart",
	228	+ "description" => "string",
	229	+ "event_type" => "click",
	230	+ "key" => "add_to_cart"
231	231	));
232	232
233	233	$result = $eventsService->updateClickEvent(0, 0, $event);
		@@ -299,14 +299,14 @@ discard block
		block discarded – undo
299	299	"platform" => "web",
300	300	"status" => "active",
301	301	"web_snippet" => array(
302		- "enable_force_variation" => false,
303		- "exclude_disabled_experiments" => false,
304		- "exclude_names" => true,
305		- "include_jquery" => true,
306		- "ip_anonymization" => false,
307		- "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]\|1([0-4][0-9]\|50))$",
308		- "library" => "jquery-1.11.3-trim",
309		- "project_javascript" => "alert(\"Active Experiment\")"
	302	+ "enable_force_variation" => false,
	303	+ "exclude_disabled_experiments" => false,
	304	+ "exclude_names" => true,
	305	+ "include_jquery" => true,
	306	+ "ip_anonymization" => false,
	307	+ "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]\|1([0-4][0-9]\|50))$",
	308	+ "library" => "jquery-1.11.3-trim",
	309	+ "project_javascript" => "alert(\"Active Experiment\")"
310	310	)
311	311	));
312	312
		@@ -338,22 +338,22 @@ discard block
		block discarded – undo
338	338
339	339	// Create new event in the project
340	340	$event = new ClickEvent(array(
341		- "event_filter" => array(
	341	+ "event_filter" => array(
342	342	"filter_type" => "target_selector",
343	343	"selector" => ".menu-options"
344		- ),
345		- "name" => "Add to Cart",
346		- "archived" => true,
347		- "category" => "add_to_cart",
348		- "description" => "Some simple event",
349		- "event_type" => "click",
350		- "key" => "add_to_cart",
351		- "created" => "2016-10-18T05:07:04.153Z",
352		- "id" => 0,
353		- "is_classic" => false,
354		- //"is_editable" => true,
355		- "page_id" => $createdPage->getId(),
356		- "project_id" => $createdProject->getId()
	344	+ ),
	345	+ "name" => "Add to Cart",
	346	+ "archived" => true,
	347	+ "category" => "add_to_cart",
	348	+ "description" => "Some simple event",
	349	+ "event_type" => "click",
	350	+ "key" => "add_to_cart",
	351	+ "created" => "2016-10-18T05:07:04.153Z",
	352	+ "id" => 0,
	353	+ "is_classic" => false,
	354	+ //"is_editable" => true,
	355	+ "page_id" => $createdPage->getId(),
	356	+ "project_id" => $createdProject->getId()
357	357	));
358	358
359	359	$result = $optimizelyClient->events()->createClickEvent($createdPage->getId(), $event);

		@@ -205,14 +205,14 @@
		block discarded – undo
205	205	"platform" => "web",
206	206	"status" => "active",
207	207	"web_snippet" => array(
208		- "enable_force_variation" => false,
209		- "exclude_disabled_experiments" => false,
210		- "exclude_names" => true,
211		- "include_jquery" => true,
212		- "ip_anonymization" => false,
213		- "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]\|1([0-4][0-9]\|50))$",
214		- "library" => "jquery-1.11.3-trim",
215		- "project_javascript" => "alert(\"Active Experiment\")"
	208	+ "enable_force_variation" => false,
	209	+ "exclude_disabled_experiments" => false,
	210	+ "exclude_names" => true,
	211	+ "include_jquery" => true,
	212	+ "ip_anonymization" => false,
	213	+ "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]\|1([0-4][0-9]\|50))$",
	214	+ "library" => "jquery-1.11.3-trim",
	215	+ "project_javascript" => "alert(\"Active Experiment\")"
216	216	)
217	217	));
218	218

		@@ -39,9 +39,9 @@ discard block
		block discarded – undo
39	39	$result = $attributesService->listAll(0);
40	40	$attributes = $result->getPayload();
41	41
42		- $this->assertTrue(count($attributes)==1);
	42	+ $this->assertTrue(count($attributes) == 1);
43	43	$this->assertTrue($attributes[0] instanceOf Attribute);
44		- $this->assertTrue($attributes[0]->getName()=='Subscriber Status');
	44	+ $this->assertTrue($attributes[0]->getName() == 'Subscriber Status');
45	45	}
46	46
47	47	/**
		@@ -101,7 +101,7 @@ discard block
		block discarded – undo
101	101	$attribute = $result->getPayload();
102	102
103	103	$this->assertTrue($attribute instanceOf Attribute);
104		- $this->assertTrue($attribute->getName()=='Subscriber Status');
	104	+ $this->assertTrue($attribute->getName() == 'Subscriber Status');
105	105	}
106	106
107	107	public function testCreate()
		@@ -142,7 +142,7 @@ discard block
		block discarded – undo
142	142	$createdAttribute = $result->getPayload();
143	143
144	144	$this->assertTrue($createdAttribute instanceOf Attribute);
145		- $this->assertTrue($createdAttribute->getName()=='Subscriber Status');
	145	+ $this->assertTrue($createdAttribute->getName() == 'Subscriber Status');
146	146	}
147	147
148	148	public function testUpdate()
		@@ -183,7 +183,7 @@ discard block
		block discarded – undo
183	183	$createdAttribute = $result->getPayload();
184	184
185	185	$this->assertTrue($createdAttribute instanceOf Attribute);
186		- $this->assertTrue($createdAttribute->getName()=='Subscriber Status');
	186	+ $this->assertTrue($createdAttribute->getName() == 'Subscriber Status');
187	187	}
188	188
189	189	public function testIntegration()
		@@ -194,7 +194,7 @@ discard block
		block discarded – undo
194	194	$credentials = $this->loadCredentialsFromFile();
195	195
196	196	$optimizelyClient = new OptimizelyApiClient($credentials, 'v2');
197		- $this->assertTrue($optimizelyClient!=null);
	197	+ $this->assertTrue($optimizelyClient != null);
198	198
199	199	// Create new project
200	200	$curDate = date('Y-m-d H:i:s');
		@@ -235,7 +235,7 @@ discard block
		block discarded – undo
235	235	$createdAttribute = $result->getPayload();
236	236
237	237	$this->assertTrue($createdAttribute instanceOf Attribute);
238		- $this->assertTrue($createdAttribute->getName()=='Subscriber Status');
	238	+ $this->assertTrue($createdAttribute->getName() == 'Subscriber Status');
239	239
240	240	// List all existing attributes and try to find the created attribute
241	241	$attributeFound = false;
		@@ -247,16 +247,16 @@ discard block
		block discarded – undo
247	247	$attributes = $result->getPayload();
248	248
249	249	foreach ($attributes as $attribute) {
250		- if ($attribute->getName()=="Subscriber Status") {
	250	+ if ($attribute->getName() == "Subscriber Status") {
251	251	$attributeFound = true;
252	252	break;
253	253	}
254	254	}
255	255
256		- if ($result->getNextPage()==null)
	256	+ if ($result->getNextPage() == null)
257	257	break;
258	258
259		- $page ++;
	259	+ $page++;
260	260	}
261	261	}
262	262	catch (Exception $e) {
		@@ -276,7 +276,7 @@ discard block
		block discarded – undo
276	276	$updatedAttribute = $result->getPayload();
277	277
278	278	$this->assertTrue($updatedAttribute instanceOf Attribute);
279		- $this->assertTrue($updatedAttribute->getName()=='Some new attribute name');
	279	+ $this->assertTrue($updatedAttribute->getName() == 'Some new attribute name');
280	280
281	281	// Make project archived
282	282

		@@ -43,9 +43,9 @@ discard block
		block discarded – undo
43	43	$result = $pagesService->listAll(1000);
44	44	$pages = $result->getPayload();
45	45
46		- $this->assertTrue(count($pages)==1);
	46	+ $this->assertTrue(count($pages) == 1);
47	47	$this->assertTrue($pages[0] instanceOf Page);
48		- $this->assertTrue($pages[0]->getName()=='Home Page');
	48	+ $this->assertTrue($pages[0]->getName() == 'Home Page');
49	49	}
50	50
51	51	public function testGet()
		@@ -128,7 +128,7 @@ discard block
		block discarded – undo
128	128	$createdPage = $result->getPayload();
129	129
130	130	$this->assertTrue($createdPage instanceOf Page);
131		- $this->assertTrue($createdPage->getName()=='Home Page');
	131	+ $this->assertTrue($createdPage->getName() == 'Home Page');
132	132	}
133	133
134	134	public function testUpdate()
		@@ -176,7 +176,7 @@ discard block
		block discarded – undo
176	176	$updatedPage = $result->getPayload();
177	177
178	178	$this->assertTrue($updatedPage instanceOf Page);
179		- $this->assertTrue($updatedPage->getName()=='Home Page');
	179	+ $this->assertTrue($updatedPage->getName() == 'Home Page');
180	180	}
181	181
182	182	public function testDelete()
		@@ -206,7 +206,7 @@ discard block
		block discarded – undo
206	206	$credentials = $this->loadCredentialsFromFile();
207	207
208	208	$optimizelyClient = new OptimizelyApiClient($credentials, 'v2');
209		- $this->assertTrue($optimizelyClient!=null);
	209	+ $this->assertTrue($optimizelyClient != null);
210	210
211	211	// Create new project
212	212	$curDate = date('Y-m-d H:i:s');
		@@ -252,7 +252,7 @@ discard block
		block discarded – undo
252	252	$createdPage = $result->getPayload();
253	253
254	254	$this->assertTrue($createdPage instanceOf Page);
255		- $this->assertTrue($createdPage->getName()=='Home Page');
	255	+ $this->assertTrue($createdPage->getName() == 'Home Page');
256	256
257	257	// List all existing pages and try to find the created page
258	258	$pageFound = false;
		@@ -264,16 +264,16 @@ discard block
		block discarded – undo
264	264	$pages = $result->getPayload();
265	265
266	266	foreach ($pages as $pageObject) {
267		- if ($pageObject->getName()=="Home Page") {
	267	+ if ($pageObject->getName() == "Home Page") {
268	268	$pageFound = true;
269	269	break;
270	270	}
271	271	}
272	272
273		- if ($result->getNextPage()==null)
	273	+ if ($result->getNextPage() == null)
274	274	break;
275	275
276		- $page ++;
	276	+ $page++;
277	277	}
278	278	}
279	279	catch (Exception $e) {
		@@ -293,7 +293,7 @@ discard block
		block discarded – undo
293	293	$updatedPage = $result->getPayload();
294	294
295	295	$this->assertTrue($updatedPage instanceOf Page);
296		- $this->assertTrue($updatedPage->getName()=='Some new page name');
	296	+ $this->assertTrue($updatedPage->getName() == 'Some new page name');
297	297
298	298	// Make project archived
299	299

		@@ -28,7 +28,7 @@ discard block
		block discarded – undo
28	28	switch ($name) {
29	29	case 'selector': $this->setSelector($value); break;
30	30	default:
31		- throw new Exception('Unknown option found in the InPageConfig entity: ' . $name);
	31	+ throw new Exception('Unknown option found in the InPageConfig entity: '.$name);
32	32	}
33	33	}
34	34	}
		@@ -45,7 +45,7 @@ discard block
		block discarded – undo
45	45	// Remove options with empty values
46	46	$cleanedOptions = array();
47	47	foreach ($options as $name=>$value) {
48		- if ($value!==null)
	48	+ if ($value !== null)
49	49	$cleanedOptions[$name] = $value;
50	50	}
51	51

		@@ -91,8 +91,9 @@
		block discarded – undo
91	91	// Remove options with empty values
92	92	$cleanedOptions = array();
93	93	foreach ($options as $name=>$value) {
94		- if ($value!==null)
95		- $cleanedOptions[$name] = $value;
	94	+ if ($value!==null) {
	95	+ $cleanedOptions[$name] = $value;
	96	+ }
96	97	}
97	98
98	99	return $cleanedOptions;

webmarketingroi / optimizely-php

Push — master ( 5c0b02...4f84cc )

Status

Category

Indentation +40 added lines, -40 removed lines patch added patch discarded remove patch

Indentation +33 added lines, -33 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +70 added lines, -70 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -2 removed lines patch added patch discarded remove patch