VariantResults::__construct() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/webmar..." - webmarketingroi/optimizely-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0ca99d...7c70a3 )

by Oleg

created 2016-10-19 06:09 UTC

VariantResults::__construct() B

↳ Parent: VariantResults

Complexity

Conditions	11
Paths	11

Size

Total Lines	18
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	11.7975

Importance

Changes

Metric	Value
cc	11
eloc	14
nc	11
nop	1
dl	0
loc	18
ccs	13
cts	16
cp	0.8125
crap	11.7975
rs	7.1162
c	0
b	0
f	0

How to fix Complexity

<?php
/**
 * @author Oleg Krivtsov <[email protected]>
 * @date 12 October 2016
 * @copyright (c) 2016, Web Marketing ROI
 */
namespace WebMarketingROI\OptimizelyPHP\Resource\v2;

use WebMarketingROI\OptimizelyPHP\Resource\v2\Datapoint;

/**
 * Optimizely campaign variant results.
 */
class VariantResults
{
    /**
     * The unique identifier for the Experiment this entity contains results for (if applicable).
     * @var integer 
     */
    private $experimentId;
    
    /**
     * Indicates that this variant is the baseline that all other entities will 
     * be compared against. Also referred to as the 'Control' or 'Control Group'.
     * @var boolean
     */
    private $isBaseline;
    
    /**
     * The relative difference in performance of this variant vs. the baseline 
     * variant. Lift is calculated as follows: (Winning Conversion Rate % - Old 
     * Conversion Rate %) - Old Conversion Rate % = % Improvement
     * @var Datapoint
     */
    private $lift;
    
    /**
     * The name of the variant
     * @var string
     */
    private $name;
    
    /**
     *
     * @var number
     */
    private $rate;
    
    /**
     * The scope that this variant represents. Can be 'variation', 'experiment' or 'campaign'
     * @var string 
     */
    private $scope;
    
    /**
     *
     * @var Datapoint
     */
    private $totalIncrease;
    
    /**
     *
     * @var number
     */
    private $value;
    
    /**
     * 
     * @var string 
     */
    private $variationId;
    
    /**
     * Constructor.
     */
    public function __construct($options = array())
    {
        foreach ($options as $name=>$value) {
            switch ($name) {                
                case 'experiment_id': $this->setExperimentId($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'is_baseline': $this->setIsBaseline($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'lift': $this->setLift(new Datapoint($value)); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'name': $this->setName($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'rate': $this->setRate($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'scope': $this->setScope($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'total_increase': $this->setTotalIncrease(new Datapoint($value)); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'value': $this->setValue($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'variation_id': $this->setVariationId($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                default:
                    throw new \Exception('Unknown option: ' . $name);
            }
        }
    }
    
    /**
     * Returns this object as array.
     */
    public function toArray()
    {
        $options = array(
            'experiment_id' => $this->getExperimentId(),
            'is_baseline' => $this->getIsBaseline(),
            'lift' => $this->getLift()?$this->getLift()->toArray():null,
            'name' => $this->getName(),
            'rate' => $this->getRate(),
            'scope' => $this->getScope(),
            'total_increase' => $this->getTotalIncrease()?$this->getTotalIncrease()->toArray():null,
            'value' => $this->getValue(),
            'variation_id' => $this->getVariationId()
        );
        
        // Remove options with empty values
        $cleanedOptions = array();
        foreach ($options as $name=>$value) {
            if ($value!==null)
                $cleanedOptions[$name] = $value;
        }
        
        return $cleanedOptions;
    }
    
    public function getExperimentId()
    {
        return $this->experimentId;
    }
    
    public function setExperimentId($experimentId)
    {
        $this->experimentId = $experimentId;
    }
    
    public function getIsBaseline()
    {
        return $this->isBaseline;
    }
    
    public function setIsBaseline($isBaseline)
    {
        $this->isBaseline = $isBaseline;
    }
    
    public function getLift()
    {
        return $this->lift;
    }
    
    public function setLift($lift)
    {
        $this->lift = $lift;
    }
    
    public function getName()
    {
        return $this->name;
    }
    
    public function setName($name)
    {
        $this->name = $name;
    }
    
    public function getRate()
    {
        return $this->rate;
    }
    
    public function setRate($rate)
    {
        $this->rate = $rate;
    }
    
    public function getScope()
    {
        return $this->scope;
    }
    
    public function setScope($scope)
    {
        $this->scope = $scope;
    }
    
    public function getTotalIncrease()
    {
        return $this->totalIncrease;
    }
    
    public function setTotalIncrease($totalIncrease)
    {
        $this->totalIncrease = $totalIncrease;
    }
    
    public function getValue()
    {
        return $this->value;
    }
    
    public function setValue($value)
    {
        $this->value = $value;
    }
    
    public function getVariationId()
    {
        return $this->variationId;
    }
    
    public function setVariationId($variationId)
    {
        $this->variationId = $variationId;
    }
}










1		<?php
2		/**
3		* @author Oleg Krivtsov <[email protected]>
4		* @date 12 October 2016
5		* @copyright (c) 2016, Web Marketing ROI
6		*/
7		namespace WebMarketingROI\OptimizelyPHP\Resource\v2;
8
9		use WebMarketingROI\OptimizelyPHP\Resource\v2\Datapoint;
10
11		/**
12		* Optimizely campaign variant results.
13		*/
14		class VariantResults
15		{
16		/**
17		* The unique identifier for the Experiment this entity contains results for (if applicable).
18		* @var integer
19		*/
20		private $experimentId;
21
22		/**
23		* Indicates that this variant is the baseline that all other entities will
24		* be compared against. Also referred to as the 'Control' or 'Control Group'.
25		* @var boolean
26		*/
27		private $isBaseline;
28
29		/**
30		* The relative difference in performance of this variant vs. the baseline
31		* variant. Lift is calculated as follows: (Winning Conversion Rate % - Old
32		* Conversion Rate %) - Old Conversion Rate % = % Improvement
33		* @var Datapoint
34		*/
35		private $lift;
36
37		/**
38		* The name of the variant
39		* @var string
40		*/
41		private $name;
42
43		/**
44		*
45		* @var number
46		*/
47		private $rate;
48
49		/**
50		* The scope that this variant represents. Can be 'variation', 'experiment' or 'campaign'
51		* @var string
52		*/
53		private $scope;
54
55		/**
56		*
57		* @var Datapoint
58		*/
59		private $totalIncrease;
60
61		/**
62		*
63		* @var number
64		*/
65		private $value;
66
67		/**
68		*
69		* @var string
70		*/
71		private $variationId;
72
73		/**
74		* Constructor.
75		*/
76	3	public function __construct($options = array())
77		{
78	3	foreach ($options as $name=>$value) {
79		switch ($name) {
80	3	case 'experiment_id': $this->setExperimentId($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
81	3	case 'is_baseline': $this->setIsBaseline($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
82	3	case 'lift': $this->setLift(new Datapoint($value)); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
83	3	case 'name': $this->setName($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
84	3	case 'rate': $this->setRate($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
85	3	case 'scope': $this->setScope($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
86	3	case 'total_increase': $this->setTotalIncrease(new Datapoint($value)); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
87	3	case 'value': $this->setValue($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
88	3	case 'variation_id': $this->setVariationId($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
89		default:
90		throw new \Exception('Unknown option: ' . $name);
91		}
92	3	}
93	3	}
94
95		/**
96		* Returns this object as array.
97		*/
98	1	public function toArray()
99		{
100		$options = array(
101	1	'experiment_id' => $this->getExperimentId(),
102	1	'is_baseline' => $this->getIsBaseline(),
103	1	'lift' => $this->getLift()?$this->getLift()->toArray():null,
104	1	'name' => $this->getName(),
105	1	'rate' => $this->getRate(),
106	1	'scope' => $this->getScope(),
107	1	'total_increase' => $this->getTotalIncrease()?$this->getTotalIncrease()->toArray():null,
108	1	'value' => $this->getValue(),
109	1	'variation_id' => $this->getVariationId()
110	1	);
111
112		// Remove options with empty values
113	1	$cleanedOptions = array();
114	1	foreach ($options as $name=>$value) {
115	1	if ($value!==null)
116	1	$cleanedOptions[$name] = $value;
117	1	}
118
119	1	return $cleanedOptions;
120		}
121
122	1	public function getExperimentId()
123		{
124	1	return $this->experimentId;
125		}
126
127	3	public function setExperimentId($experimentId)
128		{
129	3	$this->experimentId = $experimentId;
130	3	}
131
132	1	public function getIsBaseline()
133		{
134	1	return $this->isBaseline;
135		}
136
137	3	public function setIsBaseline($isBaseline)
138		{
139	3	$this->isBaseline = $isBaseline;
140	3	}
141
142	1	public function getLift()
143		{
144	1	return $this->lift;
145		}
146
147	3	public function setLift($lift)
148		{
149	3	$this->lift = $lift;
150	3	}
151
152	1	public function getName()
153		{
154	1	return $this->name;
155		}
156
157	3	public function setName($name)
158		{
159	3	$this->name = $name;
160	3	}
161
162	1	public function getRate()
163		{
164	1	return $this->rate;
165		}
166
167	3	public function setRate($rate)
168		{
169	3	$this->rate = $rate;
170	3	}
171
172	1	public function getScope()
173		{
174	1	return $this->scope;
175		}
176
177	3	public function setScope($scope)
178		{
179	3	$this->scope = $scope;
180	3	}
181
182	1	public function getTotalIncrease()
183		{
184	1	return $this->totalIncrease;
185		}
186
187	3	public function setTotalIncrease($totalIncrease)
188		{
189	3	$this->totalIncrease = $totalIncrease;
190	3	}
191
192	1	public function getValue()
193		{
194	1	return $this->value;
195		}
196
197	3	public function setValue($value)
198		{
199	3	$this->value = $value;
200	3	}
201
202	1	public function getVariationId()
203		{
204	1	return $this->variationId;
205		}
206
207	3	public function setVariationId($variationId)
208		{
209	3	$this->variationId = $variationId;
210	3	}
211		}
212
213
214
215
216
217
218
219
220

webmarketingroi / optimizely-php

Push — master ( 0ca99d...7c70a3 )

VariantResults::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like