Page::__construct() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/webmar..." - webmarketingroi/optimizely-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0ca99d...7c70a3 )

by Oleg

created 2016-10-19 06:09 UTC

Page::__construct() C

↳ Parent: Page

Complexity

Conditions	16
Paths	16

Size

Total Lines	23
Code Lines	19

Duplication

Lines	23
Ratio	100 %

Code Coverage

Tests	18
CRAP Score	16.747

Importance

Changes

Metric	Value
cc	16
eloc	19
nc	16
nop	1
dl	23
loc	23
ccs	18
cts	21
cp	0.8571
crap	16.747
rs	5.2678
c	0
b	0
f	0

How to fix Complexity

<?php
/**
 * @author Oleg Krivtsov <[email protected]>
 * @date 07 October 2016
 * @copyright (c) 2016, Web Marketing ROI
 */
namespace WebMarketingROI\OptimizelyPHP\Resource\v2;

/**
 * An Optimizely project page.
 */
class Page
{
    /**
     * URL of the Page
     * @var string
     */
    private $editUrl;
    
    /**
     * Name of the Page
     * @var string 
     */
    private $name;
    
    /**
     * ID of the Page's project
     * @var integer 
     */
    private $projectId;
    
    /**
     * Code to determine Experiment start
     * @var string 
     */
    private $activationCode;
    
    /**
     * Page activation type. Can be immediate, manual, polling or callback
     * @var string 
     */
    private $activationType;
    
    /**
     *
     * @var string 
     */
    private $apiName;
    
    /**
     * Whether the Page has been archived
     * @var boolean 
     */
    private $archived;
    
    /**
     * The category this Page is grouped under. Can be article, cart, category, 
     * checkout, home, landing_page, pricing, product_detail, search_results or other
     * @var string
     */
    private $category;
    
    /**
     * Conditions that activate the Page
     * @var string 
     */
    private $conditions;
    
    /**
     * Unique string identifier for this page within the project.
     * @var string
     */
    private $key;
    
    /**
     * Type of Page. Can be single_url, url_set or global
     * @var string
     */
    private $pageType;
    
    /**
     * Date created
     * @var string
     */
    private $created;
    
    /**
     * The unique identifier of the Page
     * @var integer 
     */
    private $id;
    
    /**
     * Date last modified
     * @var string
     */
    private $lastModified;
    
    /**
     * Constructor.
     */
    public function __construct($options = array())

    {
        foreach ($options as $name=>$value) {
            switch ($name) {                
                case 'edit_url': $this->setEditUrl($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'name': $this->setName($value); break;    
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'project_id': $this->setProjectId($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'activation_code': $this->setActivationCode($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'activation_type': $this->setActivationType($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'api_name': $this->setApiName($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'archived': $this->setArchived($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'category': $this->setCategory($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'conditions': $this->setConditions($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'key': $this->setKey($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'page_type': $this->setPageType($value); break;                
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'created': $this->setCreated($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'id': $this->setId($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'last_modified': $this->setLastModified($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                default:
                    throw new \Exception('Unknown option: ' . $name);
            }
        }
    }
    
    /**
     * Returns this object as array.
     */
    public function toArray()

    {
        $options = array(
            'edit_url' => $this->getEditUrl(),
            'name' => $this->getName(),
            'project_id' => $this->getProjectId(),
            'activation_code' => $this->getActivationCode(),
            'activation_type' => $this->getActivationType(),
            'api_name' => $this->getApiName(),
            'archived' => $this->getArchived(),
            'category' => $this->getCategory(),
            'conditions' => $this->getConditions(),
            'key' => $this->getKey(),
            'page_type' => $this->getPageType(),            
            'created' => $this->getCreated(),
            'id' => $this->getId(),
            'last_modified' => $this->getLastModified()
        );
        
        // Remove options with empty values
        $cleanedOptions = array();
        foreach ($options as $name=>$value) {
            if ($value!==null)
                $cleanedOptions[$name] = $value;
        }
        
        return $cleanedOptions;
    }
    
    public function getEditUrl()
    {
        return $this->editUrl;
    }
    
    public function setEditUrl($editUrl)
    {
        $this->editUrl = $editUrl;
    }
    
    public function getName()
    {
        return $this->name;
    }
    
    public function setName($name)
    {
        $this->name = $name;
    }
    
    public function getProjectId()
    {
        return $this->projectId;
    }
    
    public function setProjectId($projectId)
    {
        $this->projectId = $projectId;
    }
    
    public function getActivationCode()
    {
        return $this->activationCode;
    }
    
    public function setActivationCode($activationCode)
    {
        $this->activationCode = $activationCode;
    }
    
    public function getActivationType()
    {
        return $this->activationType;
    }
    
    public function setActivationType($activationType)
    {
        $this->activationType = $activationType;
    }
    
    public function getApiName()
    {
        return $this->apiName;
    }
    
    public function setApiName($apiName)
    {
        $this->apiName = $apiName;
    }
    
    public function getArchived()
    {
        return $this->archived;
    }
    
    public function setArchived($archived)
    {
        $this->archived = $archived;
    }
    
    public function getCategory()
    {
        return $this->category;
    }
    
    public function setCategory($category)
    {
        $this->category = $category;
    }
    
    public function getConditions()
    {
        return $this->conditions;
    }
    
    public function setConditions($conditions)
    {
        $this->conditions = $conditions;
    }
    
    public function getKey()
    {
        return $this->key;
    }
    
    public function setKey($key)
    {
        $this->key = $key;
    }
    
    public function getPageType()
    {
        return $this->pageType;
    }
    
    public function setPageType($pageType)
    {
        $this->pageType = $pageType;
    }
        
    public function getCreated()
    {
        return $this->created;
    }
    
    public function setCreated($created)
    {
        $this->created = $created;
    }
    
    public function getId()
    {
        return $this->id;
    }
    
    public function setId($id)
    {
        $this->id = $id;
    }
    
    public function getLastModified()
    {
        return $this->lastModified;
    }
    
    public function setLastModified($lastModified)
    {
        $this->lastModified = $lastModified;
    }
}










1			<?php
2			/**
3			* @author Oleg Krivtsov <[email protected]>
4			* @date 07 October 2016
5			* @copyright (c) 2016, Web Marketing ROI
6			*/
7			namespace WebMarketingROI\OptimizelyPHP\Resource\v2;
8
9			/**
10			* An Optimizely project page.
11			*/
12			class Page
13			{
14			/**
15			* URL of the Page
16			* @var string
17			*/
18			private $editUrl;
19
20			/**
21			* Name of the Page
22			* @var string
23			*/
24			private $name;
25
26			/**
27			* ID of the Page's project
28			* @var integer
29			*/
30			private $projectId;
31
32			/**
33			* Code to determine Experiment start
34			* @var string
35			*/
36			private $activationCode;
37
38			/**
39			* Page activation type. Can be immediate, manual, polling or callback
40			* @var string

webmarketingroi / optimizely-php

Push — master ( 0ca99d...7c70a3 )

Page::__construct() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like