CampaignMetricResults::__construct() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/webmar..." - webmarketingroi/optimizely-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0ca99d...7c70a3 )

by Oleg

created 2016-10-19 06:09 UTC

CampaignMetricResults::__construct() C

↳ Parent: CampaignMetricResults

Complexity

Conditions	10
Paths	10

Size

Total Lines	23
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	10.3375

Importance

Changes

Metric	Value
cc	10
eloc	17
nc	10
nop	1
dl	0
loc	23
ccs	17
cts	20
cp	0.85
crap	10.3375
rs	5.6534
c	0
b	0
f	0

How to fix Complexity

<?php
/**
 * @author Oleg Krivtsov <[email protected]>
 * @date 12 October 2016
 * @copyright (c) 2016, Web Marketing ROI
 */
namespace WebMarketingROI\OptimizelyPHP\Resource\v2;

use WebMarketingROI\OptimizelyPHP\Resource\v2\VariantResults;

/**
 * Optimizely campaign metric results.
 */
class CampaignMetricResults
{
    /**
     * 
     * @var string
     */
    private $event;
    
    /**
     *
     * @var string
     */
    private $eventName;
    
    /**
     * Conversions indicate the total number of visitors or sessions where the 
     * event happened. Impressions indicate the total number of times the event 
     * happened (possibly multiple per visitor or session). Revenue indicates 
     * the sum of all revenue sent from all events in the Campaign. 
     * Can be 'conversions', 'impressions' or 'revenue'.
     * @var string
     */
    private $measure;
    
    /**
     *
     * @var string
     */
    private $metricId;
    
    /**
     *
     * @var integer
     */
    private $priority;
    
    /**
     * A map of results for the variants affected by the campaign. Variants may 
     * represent aggregated results scoped to the campaign and/or individual 
     * experiment results scoped to just that experiment. The special variant 
     * 'baseline' represents visitors that have been held back from any change 
     * in experience across all Experiments in the Campaign. The special variant 
     * 'campaign' represents the aggregated effect of all experiments included in 
     * the Campaign.
     * @var VariantResults
     */
    private $results;
    
    /**
     * Can be 'session', 'visitor' or 'event'.
     * @var string
     */
    private $unit;
    
    /**
     * Constructor.
     */
    public function __construct($options = array())
    {
        foreach ($options as $name=>$value) {
            switch ($name) {                
                case 'event': $this->setEvent($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'event_name': $this->setEventName($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'measure': $this->setMeasure($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'metric_id': $this->setMetricId($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'priority': $this->setPriority($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'results': {
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    $results = array();
                    foreach ($value as $name=>$info) {
                        $results[$name] = new VariantResults($info);
                    }
                    $this->setResults($results); 
                    break;
                }
                case 'unit': $this->setUnit($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                default:
                    throw new \Exception('Unknown option: ' . $name);
            }
        }
    }
    
    /**
     * Returns this object as array.
     */
    public function toArray()
    {
        $options = array(
            'event' => $this->getEvent(),
            'event_name' => $this->getEventName(),
            'measure' => $this->getMeasure(),
            'metric_id' => $this->getMetricId(),
            'priority' => $this->getPriority(),
            'results' => array(),
            'unit' => $this->getUnit()
        );
        
        foreach ($this->getResults() as $name=>$result) {

            $options['results'][$name] = $result->toArray();
        }
        
        // Remove options with empty values
        $cleanedOptions = array();
        foreach ($options as $name=>$value) {
            if ($value!==null)
                $cleanedOptions[$name] = $value;
        }
        
        return $cleanedOptions;
    }
    
    public function getEvent()
    {
        return $this->event;
    }
    
    public function setEvent($event)
    {
        $this->event = $event;
    }
    
    public function getEventName()
    {
        return $this->eventName;
    }
    
    public function setEventName($eventName)
    {
        $this->eventName = $eventName;
    }
    
    public function getMeasure()
    {
        return $this->measure;
    }
    
    public function setMeasure($measure)
    {
        $this->measure = $measure;
    }
    
    public function getMetricId()
    {
        return $this->metricId;
    }
    
    public function setMetricId($metricId)
    {
        $this->metricId = $metricId;
    }
    
    public function getPriority()
    {
        return $this->priority;
    }
    
    public function setPriority($priority)
    {
        $this->priority = $priority;
    }
    
    public function getResults()
    {
        return $this->results;
    }
    
    public function setResults($results)
    {
        $this->results = $results;
    }
    
    public function getUnit()
    {
        return $this->unit;
    }
    
    public function setUnit($unit)
    {
        $this->unit = $unit;
    }
}








1		<?php
2		/**
3		* @author Oleg Krivtsov <[email protected]>
4		* @date 12 October 2016
5		* @copyright (c) 2016, Web Marketing ROI
6		*/
7		namespace WebMarketingROI\OptimizelyPHP\Resource\v2;
8
9		use WebMarketingROI\OptimizelyPHP\Resource\v2\VariantResults;
10
11		/**
12		* Optimizely campaign metric results.
13		*/
14		class CampaignMetricResults
15		{
16		/**
17		*
18		* @var string
19		*/
20		private $event;
21
22		/**
23		*
24		* @var string
25		*/
26		private $eventName;
27
28		/**
29		* Conversions indicate the total number of visitors or sessions where the
30		* event happened. Impressions indicate the total number of times the event
31		* happened (possibly multiple per visitor or session). Revenue indicates
32		* the sum of all revenue sent from all events in the Campaign.
33		* Can be 'conversions', 'impressions' or 'revenue'.
34		* @var string
35		*/
36		private $measure;
37
38		/**
39		*
40		* @var string
41		*/
42		private $metricId;
43
44		/**
45		*
46		* @var integer
47		*/
48		private $priority;
49
50		/**
51		* A map of results for the variants affected by the campaign. Variants may
52		* represent aggregated results scoped to the campaign and/or individual
53		* experiment results scoped to just that experiment. The special variant
54		* 'baseline' represents visitors that have been held back from any change
55		* in experience across all Experiments in the Campaign. The special variant
56		* 'campaign' represents the aggregated effect of all experiments included in
57		* the Campaign.
58		* @var VariantResults
59		*/
60		private $results;
61
62		/**
63		* Can be 'session', 'visitor' or 'event'.
64		* @var string
65		*/
66		private $unit;
67
68		/**
69		* Constructor.
70		*/
71	3	public function __construct($options = array())
72		{
73	3	foreach ($options as $name=>$value) {
74		switch ($name) {
75	3	case 'event': $this->setEvent($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
76	3	case 'event_name': $this->setEventName($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
77	3	case 'measure': $this->setMeasure($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
78	3	case 'metric_id': $this->setMetricId($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
79	3	case 'priority': $this->setPriority($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
80	3	case 'results': {
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
81	3	$results = array();
82	3	foreach ($value as $name=>$info) {
83	3	$results[$name] = new VariantResults($info);
84	3	}
85	3	$this->setResults($results);
86	3	break;
87		}
88	3	case 'unit': $this->setUnit($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
89		default:
90		throw new \Exception('Unknown option: ' . $name);
91		}
92	3	}
93	3	}
94
95		/**
96		* Returns this object as array.
97		*/
98	1	public function toArray()
99		{
100		$options = array(
101	1	'event' => $this->getEvent(),
102	1	'event_name' => $this->getEventName(),
103	1	'measure' => $this->getMeasure(),
104	1	'metric_id' => $this->getMetricId(),
105	1	'priority' => $this->getPriority(),
106	1	'results' => array(),
107	1	'unit' => $this->getUnit()
108	1	);
109
110	1	foreach ($this->getResults() as $name=>$result) {
		0 ignored issues – show Bug introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The expression `$this->getResults()` of type `object<WebMarketingROI\O...urce\v2\VariantResults>` is not traversable. Loading history...
111	1	$options['results'][$name] = $result->toArray();
112	1	}
113
114		// Remove options with empty values
115	1	$cleanedOptions = array();
116	1	foreach ($options as $name=>$value) {
117	1	if ($value!==null)
118	1	$cleanedOptions[$name] = $value;
119	1	}
120
121	1	return $cleanedOptions;
122		}
123
124	1	public function getEvent()
125		{
126	1	return $this->event;
127		}
128
129	3	public function setEvent($event)
130		{
131	3	$this->event = $event;
132	3	}
133
134	1	public function getEventName()
135		{
136	1	return $this->eventName;
137		}
138
139	3	public function setEventName($eventName)
140		{
141	3	$this->eventName = $eventName;
142	3	}
143
144	1	public function getMeasure()
145		{
146	1	return $this->measure;
147		}
148
149	3	public function setMeasure($measure)
150		{
151	3	$this->measure = $measure;
152	3	}
153
154	1	public function getMetricId()
155		{
156	1	return $this->metricId;
157		}
158
159	3	public function setMetricId($metricId)
160		{
161	3	$this->metricId = $metricId;
162	3	}
163
164	1	public function getPriority()
165		{
166	1	return $this->priority;
167		}
168
169	3	public function setPriority($priority)
170		{
171	3	$this->priority = $priority;
172	3	}
173
174	1	public function getResults()
175		{
176	1	return $this->results;
177		}
178
179	3	public function setResults($results)
180		{
181	3	$this->results = $results;
182	3	}
183
184	1	public function getUnit()
185		{
186	1	return $this->unit;
187		}
188
189	3	public function setUnit($unit)
190		{
191	3	$this->unit = $unit;
192	3	}
193		}
194
195
196
197
198
199
200

webmarketingroi / optimizely-php

Push — master ( 0ca99d...7c70a3 )

CampaignMetricResults::__construct() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like