Campaign::__construct() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/webmar..." - webmarketingroi/optimizely-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0ca99d...7c70a3 )

by Oleg

created 2016-10-19 06:09 UTC

Campaign::__construct() D

↳ Parent: Campaign

Complexity

Conditions	18
Paths	18

Size

Total Lines	35
Code Lines	27

Duplication

Lines	7
Ratio	20 %

Code Coverage

Tests	28
CRAP Score	18.2938

Importance

Changes

Metric	Value
cc	18
eloc	27
nc	18
nop	1
dl	7
loc	35
ccs	28
cts	31
cp	0.9032
crap	18.2938
rs	4.947
c	0
b	0
f	0

How to fix Complexity

<?php
/**
 * @author Oleg Krivtsov <[email protected]>
 * @date 06 October 2016
 * @copyright (c) 2016, Web Marketing ROI
 */
namespace WebMarketingROI\OptimizelyPHP\Resource\v2;

use WebMarketingROI\OptimizelyPHP\Resource\v2\Change;
use WebMarketingROI\OptimizelyPHP\Resource\v2\Metric;

/**
 * An Optimizely campaign.
 */
class Campaign
{
    /**
     * The Project ID the Campaign is in
     * @var integer
     */
    private $projectId;
    
    /**
     * A list of changes to apply to the Campaign
     * @var array 
     */
    private $changes;
    
    /**
     * The time the Experiment was initially created
     * @var string
     */
    private $created;
    
    /**
     * The first time the Experiment was activated
     * @var string
     */
    private $earliest;
    
    /**
     * An ordered list of Experiment IDs used by the Campaign
     * @var array
     */
    private $experimentIds;
    
    /**
     * Percentage expressed as a number from 0-10000 to holdback from being 
     * included in the experiment.
     * @var integer
     */
    private $holdback;
    
    /**
     * The last time the Experiment was modified
     * @var string
     */
    private $lastModified;
    
    /**
     * The last time the Experiment was activated (not present if it is still activated)
     * @var string 
     */
    private $latest;
    
    /**
     * An ordered list of Metrics to track for the Campaign
     * @var array
     */
    private $metrics;
    
    /**
     * The name of the Campaign
     * @var string
     */
    private $name;
    
    /**
     * A list of Page IDs used in the Campaign.
     * @var array
     */
    private $pageIds;
    
    /**
     * Current state of the Campaign. Can be 'active', 'paused' or 'archived'
     * @var string
     */
    private $status;
    
    /**
     * The type of the Campaign. Can be a/b or personalization.
     * @var string
     */
    private $type;
    
    /**
     * The unique identifier for the Campaign
     * @var integer
     */
    private $id;
    
    /**
     * Constructor.
     */
    public function __construct($options = array())
    {
        foreach ($options as $name=>$value) {
            switch ($name) {                
                case 'project_id': $this->setProjectId($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'changes': {
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    $changes = array();
                    foreach ($value as $changeInfo) {
                        $changes[] = new Change($changeInfo);
                    }
                    $this->setChanges($changes); break;
                }
                case 'created': $this->setCreated($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'earliest': $this->setEarliest($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'experiment_ids': $this->setExperimentIds($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'holdback': $this->setHoldback($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'last_modified': $this->setLastModified($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'latest': $this->setLatest($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'metrics': {
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    $metrics = array();
                    foreach ($value as $metricInfo) {
                        $metrics[] = new Metric($metricInfo);
                    }
                    $this->setMetrics($metrics); break;
                }
                case 'name': $this->setName($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'page_ids': $this->setPageIds($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'status': $this->setStatus($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'type': $this->setType($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'id': $this->setId($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                default:
                    throw new \Exception('Unknown option: ' . $name);
            }
        }
    }
    
    /**
     * Returns this object as array.
     */
    public function toArray()
    {
        $options = array(
            'project_id' => $this->getProjectId(),
            'changes' => array(),
            'created' => $this->getCreated(),
            'earliest' => $this->getEarliest(),
            'experiment_ids' => $this->getExperimentIds(),
            'holdback' => $this->getHoldback(),
            'last_modified' => $this->getLastModified(),
            'latest' => $this->getLatest(),
            'metrics' => array(),
            'name' => $this->getName(),
            'page_ids' => $this->getPageIds(),
            'status' => $this->getStatus(),
            'type' => $this->getType(),
            'id' => $this->getId()
        );
        
        foreach ($this->getChanges() as $change) {
            $options['changes'][] = $change->toArray();
        }
        
        foreach ($this->getMetrics() as $metric) {
            $options['metrics'][] = $metric->toArray();
        }
        
        // Remove options with empty values
        $cleanedOptions = array();
        foreach ($options as $name=>$value) {
            if ($value!==null)
                $cleanedOptions[$name] = $value;
        }
        
        return $cleanedOptions;
    }
    
    public function getProjectId()
    {
        return $this->projectId;
    }
    
    public function setProjectId($projectId)
    {
        $this->projectId = $projectId;
    }
    
    public function getChanges()
    {
        return $this->changes;
    }
    
    public function setChanges($changes)
    {
        $this->changes = $changes;
    }
    
    public function getCreated()
    {
        return $this->created;
    }
    
    public function setCreated($created)
    {
        $this->created = $created;
    }
    
    public function getEarliest()
    {
        return $this->earliest;
    }
    
    public function setEarliest($earliest)
    {
        $this->earliest = $earliest;
    }
    
    public function getExperimentIds()
    {
        return $this->experimentIds;
    }
    
    public function setExperimentIds($experimentIds)
    {
        $this->experimentIds = $experimentIds;
    }
    
    public function getHoldback()
    {
        return $this->holdback;
    }
    
    public function setHoldback($holdback)
    {
        $this->holdback = $holdback;
    }
    
    public function getLastModified()
    {
        return $this->lastModified;
    }
    
    public function setLastModified($lastModified)
    {
        $this->lastModified = $lastModified;
    }
    
    public function getLatest()
    {
        return $this->latest;
    }
    
    public function setLatest($latest)
    {
        $this->latest = $latest;
    }
    
    public function getMetrics()
    {
        return $this->metrics;
    }
    
    public function setMetrics($metrics)
    {
        $this->metrics = $metrics;
    }
    
    public function getName()
    {
        return $this->name;
    }
    
    public function setName($name)
    {
        $this->name = $name;
    }
    
    public function getPageIds()
    {
        return $this->pageIds;
    }
    
    public function setPageIds($pageIds)
    {
        $this->pageIds = $pageIds;
    }
    
    public function getStatus()
    {
        return $this->status;
    }
    
    public function setStatus($status)
    {
        $this->status = $status;
    }
    
    public function getType()
    {
        return $this->type;
    }
    
    public function setType($type)
    {
        $this->type = $type;
    }
    
    public function getId()
    {
        return $this->id;
    }
    
    public function setId($id)
    {
        $this->id = $id;
    }
}






1			<?php
2			/**
3			* @author Oleg Krivtsov <[email protected]>
4			* @date 06 October 2016
5			* @copyright (c) 2016, Web Marketing ROI
6			*/
7			namespace WebMarketingROI\OptimizelyPHP\Resource\v2;
8
9			use WebMarketingROI\OptimizelyPHP\Resource\v2\Change;
10			use WebMarketingROI\OptimizelyPHP\Resource\v2\Metric;
11
12			/**
13			* An Optimizely campaign.
14			*/
15			class Campaign
16			{
17			/**
18			* The Project ID the Campaign is in
19			* @var integer
20			*/
21			private $projectId;
22
23			/**
24			* A list of changes to apply to the Campaign
25			* @var array
26			*/
27			private $changes;
28
29			/**
30			* The time the Experiment was initially created
31			* @var string
32			*/
33			private $created;
34
35			/**
36			* The first time the Experiment was activated
37			* @var string
38			*/
39			private $earliest;
40

webmarketingroi / optimizely-php

Push — master ( 0ca99d...7c70a3 )

Campaign::__construct() D

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like