WebMarketingROI\OptimizelyPHP\Service\v2\Pages

Complexity

Total Complexity

12

Size/Duplication

Total Lines	118
Duplicated Lines	31.36 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

88.1%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	listAll()	25	25	4
A	get()	12	12	2
A	create()	0	13	2
A	update()	0	13	2
A	delete()	0	5	1

<?php
/**
 * @author Oleg Krivtsov <oleg@webmarketingroi.com.au>
 * @date 07 October 2016
 * @copyright (c) 2016, Web Marketing ROI
 */
namespace WebMarketingROI\OptimizelyPHP\Service\v2;

use WebMarketingROI\OptimizelyPHP\Resource\v2\Page;

/**
 * Provides methods for working with Optimizely project pages.
 */
class Pages
{
    /**
     * Optimizely API Client.
     * @var WebMarketingROI\OptimizelyPHP\OptimizelyApiClient
     */
    private $client;
    
    /**
     * Constructor.
     */
    public function __construct($client)
    {
        $this->client = $client;
    }
    
    /**
     * List all Pages for a project.
     * @param integer $projectId
     * @param integer $page
     * @param integer $perPage
     * @return array[Page]

The doc-type array[Page] could not be parsed: Expected "]" at position 2, but found "Page". (view supported doc-types)

     * @throws \Exception
     */
    public function listAll($projectId, $page=0, $perPage=10)

This method seems to be duplicated in your project.

    {
        if ($page<0) {
            throw new \Exception('Invalid page number passed');
        }
        
        if ($perPage<0) {
            throw new \Exception('Invalid page size passed');
        }
        
        $response = $this->client->sendApiRequest('/pages', 
                array(
                    'project_id'=>$projectId,
                    'page'=>$page,
                    'per_page'=>$perPage
                ));
        
        $pages = array();
        foreach ($response as $pageInfo) {
            $page = new Page($pageInfo);
            $pages[] = $page;
        }
        
        return $pages;
    }
    
    /**
     * Get metadata for a single Page
     * @param integer $pageId
     * @return Page
     * @throws \Exception
     */
    public function get($pageId)

This method seems to be duplicated in your project.

    {
        if (!is_int($pageId)) {
            throw new \Exception("Integer page ID expected, while got '$pageId'");
        }
        
        $response = $this->client->sendApiRequest("/pages/$pageId");
        
        $page = new Page($response);
        
        return $page;
    }
    
    /**
     * Create a new Page in a provided Project
     * @param Page $page
     */
    public function create($page)
    {
        if (!($page instanceOf Page)) {
            throw new \Exception("Expected argument of type Page");
        }
        
        $postData = $page->toArray();
        
        $response = $this->client->sendApiRequest("/pages", array(), 'POST', 
                $postData, array(201));
        
        return new Page($response);
    }
    
    /**
     * Update a Page in a provided Project
     * @param integer $pageId
     * @param Audience $page
     * @throws \Exception
     */
    public function update($pageId, $page) 
    {
        if (!($page instanceOf Page)) {
            throw new \Exception("Expected argument of type Page");
        }
        
        $postData = $page->toArray();
                
        $response = $this->client->sendApiRequest("/pages/$pageId", array(), 'PATCH', 
                $postData, array(200));
        
        return new Page($response);
    }
    
    /**
     * Delete a Page within a Project by ID.
     * @param integer $pageId
     * @throws \Exception
     */
    public function delete($pageId) 
    {
        $response = $this->client->sendApiRequest("/pages/$pageId", array(), 'DELETE', 

$response is not used, you could remove the assignment.

                array(), array(200));
    }
}