Change - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/webmar..." - webmarketingroi/optimizely-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0ca99d...7c70a3 )

by Oleg

created 2016-10-19 06:09 UTC

Change B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	236
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

96.74%

Importance

Changes

Metric	Value
dl	0
loc	236
ccs	89
cts	92
cp	0.9674
rs	8.3999
c	0
b	0
f	0
wmc	38
lcom	1
cbo	0

24 Methods

Rating	Name	Size	Complexity
B	__construct()	20	13
B	toArray()	25	3
A	getType()	4	1
A	setType()	4	1
A	getAllowAdditionalRedirect()	4	1
A	setAllowAdditionalRedirect()	4	1
A	getAsync()	4	1
A	setAsync()	4	1
A	getCssSelector()	4	1
A	setCssSelector()	4	1
A	getDependencies()	4	1
A	setDependencies()	4	1
A	getDestination()	4	1
A	setDestination()	4	1
A	getExtensionId()	4	1
A	setExtensionId()	4	1
A	getPreserveParameters()	4	1
A	setPreserveParameters()	4	1
A	getSrc()	4	1
A	setSrc()	4	1
A	getValue()	4	1
A	setValue()	4	1
A	getId()	4	1
A	setId()	4	1

<?php
/**
 * @author Oleg Krivtsov <[email protected]>
 * @date 10 October 2016
 * @copyright (c) 2016, Web Marketing ROI
 */
namespace WebMarketingROI\OptimizelyPHP\Resource\v2;

/**
 * An Optimizely campaign change.
 */
class Change
{
    /**
     * The type of change to apply to the Page. Can be 'custom_code', 'custom_css', 
     * 'attribute', 'mobile_live_variable', 'mobile_code_block', 'mobile_visual_change', 
     * 'widget', 'insert_html', 'insert_image' or 'redirect'.
     * @var string 
     */
    private $type;
    
    /**
     * Whether or not to allow additional redirects after redirecting to 
     * destination. Required for changes of type redirect.
     * @var boolean
     */
    private $allowAdditionalRedirect;
    
    /**
     * Indicates whether or not to execute the change asyncronously.
     * @var boolean
     */
    private $async;
    
    /**
     * CSS selector to determine where changes are applied. Required for changes 
     * of type custom_css, insert_html and insert_image.
     * @var string
     */
    private $cssSelector;
    
    /**
     * A list of dependent change IDs that must happen before this change
     * @var array[string]
     */
    private $dependencies;
    
    /**
     * URL to redirect to. Required for changes of type redirect.
     * @var string 
     */
    private $destination;
    
    /**
     * ID of the extension to insert. Required for changes of type extension.
     * @var string
     */
    private $extensionId;
    
    /**
     * Whether or not to preserve parameters from original request when 
     * redirecting to new destination URL. Required for changes of type redirect.
     * @var boolean 
     */
    private $preserveParameters;
    
    /**
     * The Page ID to apply changes to
     * @var string
     */
    private $src;
    
    /**
     * The value for the change
     * @var string
     */
    private $value;
    
    /**
     * The ID of the change
     * @var integer
     */
    private $id;
    
    /**
     * Constructor.
     */
    public function __construct($options = array())
    {
        foreach ($options as $name=>$value) {
            switch ($name) {                
                case 'type': $this->setType($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'allow_additional_redirect': $this->setAllowAdditionalRedirect($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'async': $this->setAsync($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'css_selector': $this->setCssSelector($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'dependencies': $this->setDependencies($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'destination': $this->setDestination($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'extension_id': $this->setExtensionId($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'preserve_parameters': $this->setPreserveParameters($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'src': $this->setSrc($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'value': $this->setValue($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'id': $this->setId($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                default:
                    throw new \Exception('Unknown option: ' . $name);
            }
        }
    }
    
    /**
     * Returns this object as array.
     */
    public function toArray()
    {
        $options = array(
            'type' => $this->getType(),
            'allow_additional_redirect' => $this->getAllowAdditionalRedirect(),
            'async' => $this->getAsync(),
            'css_selector' => $this->getCssSelector(),
            'dependencies' => $this->getDependencies(),
            'destination' => $this->getDestination(),
            'extension_id' => $this->getExtensionId(),
            'preserve_parameters' => $this->getPreserveParameters(),
            'src' => $this->getSrc(),
            'value' => $this->getValue(),
            'id' => $this->getId(),            
        );
        
        // Remove options with empty values
        $cleanedOptions = array();
        foreach ($options as $name=>$value) {
            if ($value!==null)
                $cleanedOptions[$name] = $value;
        }
        
        return $cleanedOptions;
    }
    
    public function getType()
    {
        return $this->type;
    }
    
    public function setType($type)
    {
        $this->type = $type;
    }
    
    public function getAllowAdditionalRedirect()
    {
        return $this->allowAdditionalRedirect;
    }
    
    public function setAllowAdditionalRedirect($allowAdditionalRedirect)
    {
        $this->allowAdditionalRedirect = $allowAdditionalRedirect;
    }
    
    public function getAsync()
    {
        return $this->async;
    }
    
    public function setAsync($async)
    {
        $this->async = $async;
    }
    
    public function getCssSelector()
    {
        return $this->cssSelector;
    }
    
    public function setCssSelector($cssSelector)
    {
        $this->cssSelector = $cssSelector;
    }
    
    public function getDependencies()
    {
        return $this->dependencies;
    }
    
    public function setDependencies($dependencies)
    {
        $this->dependencies = $dependencies;
    }
    
    public function getDestination()
    {
        return $this->destination;
    }
    
    public function setDestination($destination)
    {
        $this->destination = $destination;
    }
    
    public function getExtensionId()
    {
        return $this->extensionId;
    }
    
    public function setExtensionId($extensionId)
    {
        $this->extensionId = $extensionId;
    }
    
    public function getPreserveParameters()
    {
        return $this->preserveParameters;
    }
    
    public function setPreserveParameters($preserveParameters)
    {
        $this->preserveParameters = $preserveParameters;
    }
    
    public function getSrc()
    {
        return $this->src;
    }
    
    public function setSrc($src)
    {
        $this->src = $src;
    }
    
    public function getValue()
    {
        return $this->value;
    }
    
    public function setValue($value)
    {
        $this->value = $value;
    }
    
    public function getId()
    {
        return $this->id;
    }
    
    public function setId($id)
    {
        $this->id = $id;
    }
}







1		<?php
2		/**
3		* @author Oleg Krivtsov <[email protected]>
4		* @date 10 October 2016
5		* @copyright (c) 2016, Web Marketing ROI
6		*/
7		namespace WebMarketingROI\OptimizelyPHP\Resource\v2;
8
9		/**
10		* An Optimizely campaign change.
11		*/
12		class Change
13		{
14		/**
15		* The type of change to apply to the Page. Can be 'custom_code', 'custom_css',
16		* 'attribute', 'mobile_live_variable', 'mobile_code_block', 'mobile_visual_change',
17		* 'widget', 'insert_html', 'insert_image' or 'redirect'.
18		* @var string
19		*/
20		private $type;
21
22		/**
23		* Whether or not to allow additional redirects after redirecting to
24		* destination. Required for changes of type redirect.
25		* @var boolean
26		*/
27		private $allowAdditionalRedirect;
28
29		/**
30		* Indicates whether or not to execute the change asyncronously.
31		* @var boolean
32		*/
33		private $async;
34
35		/**
36		* CSS selector to determine where changes are applied. Required for changes
37		* of type custom_css, insert_html and insert_image.
38		* @var string
39		*/
40		private $cssSelector;
41
42		/**
43		* A list of dependent change IDs that must happen before this change
44		* @var array[string]
45		*/
46		private $dependencies;
47
48		/**
49		* URL to redirect to. Required for changes of type redirect.
50		* @var string
51		*/
52		private $destination;
53
54		/**
55		* ID of the extension to insert. Required for changes of type extension.
56		* @var string
57		*/
58		private $extensionId;
59
60		/**
61		* Whether or not to preserve parameters from original request when
62		* redirecting to new destination URL. Required for changes of type redirect.
63		* @var boolean
64		*/
65		private $preserveParameters;
66
67		/**
68		* The Page ID to apply changes to
69		* @var string
70		*/
71		private $src;
72
73		/**
74		* The value for the change
75		* @var string
76		*/
77		private $value;
78
79		/**
80		* The ID of the change
81		* @var integer
82		*/
83		private $id;
84
85		/**
86		* Constructor.
87		*/
88	14	public function __construct($options = array())
89		{
90	14	foreach ($options as $name=>$value) {
91		switch ($name) {
92	12	case 'type': $this->setType($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
93	12	case 'allow_additional_redirect': $this->setAllowAdditionalRedirect($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
94	12	case 'async': $this->setAsync($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
95	12	case 'css_selector': $this->setCssSelector($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
96	12	case 'dependencies': $this->setDependencies($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
97	12	case 'destination': $this->setDestination($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
98	12	case 'extension_id': $this->setExtensionId($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
99	12	case 'preserve_parameters': $this->setPreserveParameters($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
100	12	case 'src': $this->setSrc($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
101	12	case 'value': $this->setValue($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
102	8	case 'id': $this->setId($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
103		default:
104		throw new \Exception('Unknown option: ' . $name);
105		}
106	14	}
107	14	}
108
109		/**
110		* Returns this object as array.
111		*/
112	6	public function toArray()
113		{
114		$options = array(
115	6	'type' => $this->getType(),
116	6	'allow_additional_redirect' => $this->getAllowAdditionalRedirect(),
117	6	'async' => $this->getAsync(),
118	6	'css_selector' => $this->getCssSelector(),
119	6	'dependencies' => $this->getDependencies(),
120	6	'destination' => $this->getDestination(),
121	6	'extension_id' => $this->getExtensionId(),
122	6	'preserve_parameters' => $this->getPreserveParameters(),
123	6	'src' => $this->getSrc(),
124	6	'value' => $this->getValue(),
125	6	'id' => $this->getId(),
126	6	);
127
128		// Remove options with empty values
129	6	$cleanedOptions = array();
130	6	foreach ($options as $name=>$value) {
131	6	if ($value!==null)
132	6	$cleanedOptions[$name] = $value;
133	6	}
134
135	6	return $cleanedOptions;
136		}
137
138	7	public function getType()
139		{
140	7	return $this->type;
141		}
142
143	14	public function setType($type)
144		{
145	14	$this->type = $type;
146	14	}
147
148	6	public function getAllowAdditionalRedirect()
149		{
150	6	return $this->allowAdditionalRedirect;
151		}
152
153	14	public function setAllowAdditionalRedirect($allowAdditionalRedirect)
154		{
155	14	$this->allowAdditionalRedirect = $allowAdditionalRedirect;
156	14	}
157
158	6	public function getAsync()
159		{
160	6	return $this->async;
161		}
162
163	14	public function setAsync($async)
164		{
165	14	$this->async = $async;
166	14	}
167
168	6	public function getCssSelector()
169		{
170	6	return $this->cssSelector;
171		}
172
173	14	public function setCssSelector($cssSelector)
174		{
175	14	$this->cssSelector = $cssSelector;
176	14	}
177
178	6	public function getDependencies()
179		{
180	6	return $this->dependencies;
181		}
182
183	14	public function setDependencies($dependencies)
184		{
185	14	$this->dependencies = $dependencies;
186	14	}
187
188	6	public function getDestination()
189		{
190	6	return $this->destination;
191		}
192
193	14	public function setDestination($destination)
194		{
195	14	$this->destination = $destination;
196	14	}
197
198	6	public function getExtensionId()
199		{
200	6	return $this->extensionId;
201		}
202
203	12	public function setExtensionId($extensionId)
204		{
205	12	$this->extensionId = $extensionId;
206	12	}
207
208	6	public function getPreserveParameters()
209		{
210	6	return $this->preserveParameters;
211		}
212
213	14	public function setPreserveParameters($preserveParameters)
214		{
215	14	$this->preserveParameters = $preserveParameters;
216	14	}
217
218	7	public function getSrc()
219		{
220	7	return $this->src;
221		}
222
223	14	public function setSrc($src)
224		{
225	14	$this->src = $src;
226	14	}
227
228	7	public function getValue()
229		{
230	7	return $this->value;
231		}
232
233	14	public function setValue($value)
234		{
235	14	$this->value = $value;
236	14	}
237
238	6	public function getId()
239		{
240	6	return $this->id;
241		}
242
243	10	public function setId($id)
244		{
245	10	$this->id = $id;
246	10	}
247		}
248
249
250
251
252
253

webmarketingroi / optimizely-php

Push — master ( 0ca99d...7c70a3 )

Change B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

24 Methods

Duplication Side-by-Side

Filter issues like