webmarketingroi / optimizely-php

tests/OptimizelyPHPTest/ResultTest.php

Indentation +8 added lines, -8 removed lines

@@ -16,14 +16,14 @@
             "platform" => "web",
             "status" => "active",
             "web_snippet" => array(
-              "enable_force_variation" => false,
-              "exclude_disabled_experiments" => false,
-              "exclude_names" => true,
-              "include_jquery" => true,
-              "ip_anonymization" => false,
-              "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
-              "library" => "jquery-1.11.3-trim",
-              "project_javascript" => "alert(\"Active Experiment\")"
+                "enable_force_variation" => false,
+                "exclude_disabled_experiments" => false,
+                "exclude_names" => true,
+                "include_jquery" => true,
+                "ip_anonymization" => false,
+                "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
+                "library" => "jquery-1.11.3-trim",
+                "project_javascript" => "alert(\"Active Experiment\")"
             ));
         
         $result = new Result($data, 200);

lib/WebMarketingROI/OptimizelyPHP/Service/v2/Campaigns.php

Spacing +5 added lines, -5 removed lines

@@ -37,21 +37,21 @@ 
      * @return Result
      * @throws Exception
      */
-    public function listAll($projectId, $page=1, $perPage=25)
+    public function listAll($projectId, $page = 1, $perPage = 25)
     {
         if (!is_int($projectId)) {
             throw new Exception("Integer project ID expected, while got '$projectId'");
         }
         
-        if ($projectId<0) {
+        if ($projectId < 0) {
             throw new Exception("Expected positive integer project ID");
         }
         
-        if ($page<0) {
+        if ($page < 0) {
             throw new Exception('Invalid page number passed');
         }
         
-        if ($perPage<0 || $perPage>100) {
+        if ($perPage < 0 || $perPage > 100) {
             throw new Exception('Invalid page size passed');
         }
         
@@ -107,7 +107,7 @@ 
                     Exception::CODE_INVALID_ARG);
         }
         
-        if ($campaignId<0) {
+        if ($campaignId < 0) {
             throw new Exception("Expected positive integer campaign ID",
                     Exception::CODE_INVALID_ARG);
         }

Doc Comments +1 added lines, -1 removed lines

@@ -95,7 +95,7 @@
     /**
      * Get campaign results
      * @param integer $campaignId The id for the campaign you want results for
-     * @param string $starTime The earliest time to count events in results. Defaults to the time that the campaign was first activated.
+     * @param string $startTime The earliest time to count events in results. Defaults to the time that the campaign was first activated.
      * @param string $endTime The latest time to count events in results. Defaults to the time the campaign was last active or the current time if the campaign is still running.
      * @return Result
      * @throws Exception

lib/WebMarketingROI/OptimizelyPHP/Service/v2/Audiences.php

Spacing +3 added lines, -3 removed lines

@@ -36,13 +36,13 @@
      * @return Result
      * @throws Exception
      */
-    public function listAll($projectId, $page=1, $perPage=25)
+    public function listAll($projectId, $page = 1, $perPage = 25)
     {
-        if ($page<0) {
+        if ($page < 0) {
             throw new Exception('Invalid page number passed');
         }
         
-        if ($perPage<0 || $perPage>100) {
+        if ($perPage < 0 || $perPage > 100) {
             throw new Exception('Invalid page size passed');
         }
         

lib/WebMarketingROI/OptimizelyPHP/Service/v2/Experiments.php

Spacing +6 added lines, -6 removed lines

@@ -39,17 +39,17 @@ 
      * @return Result
      * @throws Exception
      */
-    public function listAll($projectId, $campaignId=null, $includeClassic=false, $page=1, $perPage=25)
+    public function listAll($projectId, $campaignId = null, $includeClassic = false, $page = 1, $perPage = 25)
     {
-        if ($projectId==null && $campaignId==null) {
+        if ($projectId == null && $campaignId == null) {
             throw new Exception('Project ID or Campaign ID must be non-null');
         }
         
-        if ($page<0) {
+        if ($page < 0) {
             throw new Exception('Invalid page number passed');
         }
         
-        if ($perPage<0 || $perPage>100) {
+        if ($perPage < 0 || $perPage > 100) {
             throw new Exception('Invalid page size passed');
         }
         
@@ -85,7 +85,7 @@ 
                     Exception::CODE_INVALID_ARG);
         }
         
-        if ($experimentId<0) {
+        if ($experimentId < 0) {
             throw new Exception("A positive experiment ID expected");
         }
         
@@ -175,7 +175,7 @@ 
             throw new Exception("Expected argument of type Experiment");
         }
         
-        if ($experimentId<0) {
+        if ($experimentId < 0) {
             throw new Exception("Expected positive experiment ID argument");
         }
         

examples/Experiments/GetExperiments.php

Spacing +11 added lines, -11 removed lines

@@ -16,14 +16,14 @@ 
 use WebMarketingROI\OptimizelyPHP\Exception;
 
 // Init class autloading.
-include dirname(__FILE__) . '/../../vendor/autoload.php';
+include dirname(__FILE__).'/../../vendor/autoload.php';
 
 // Include Utils.php - a file containing helper functions
-include dirname(__FILE__) . '/../Utils.php';
+include dirname(__FILE__).'/../Utils.php';
 
 // Read project ID from command line.
-if ($argc!=2) {
-    die('Expected 1 command-line argument, while got ' . $argc-1);
+if ($argc != 2) {
+    die('Expected 1 command-line argument, while got '.$argc - 1);
 }
 $projectId = $argv[1];
 
@@ -47,20 +47,20 @@ 
         $experiments = $result->getPayload();
         
         foreach ($experiments as $experiment) {
-            echo "Name: " . $experiment->getName() . "\n";
-            echo "Description: " . $experiment->getDescription() . "\n";
-            echo "Status: " . $experiment->getStatus() . "\n";
-            echo "Created: " . $experiment->getCreated() . "\n";
+            echo "Name: ".$experiment->getName()."\n";
+            echo "Description: ".$experiment->getDescription()."\n";
+            echo "Status: ".$experiment->getStatus()."\n";
+            echo "Created: ".$experiment->getCreated()."\n";
             
             echo "\n";
         }
     
         // Determine if there are more projects.
-        if ($result->getNextPage()==null)
+        if ($result->getNextPage() == null)
             break;
         
         // Increment page counter.
-        $page ++;
+        $page++;
     }    
     
 } catch (Exception $e) {
@@ -74,6 +74,6 @@ 
 
 // Save access token for later use
 $accessToken = $optimizelyClient->getAccessToken();
-file_put_contents(dirname(__FILE__) . '/../access_token.json', json_encode($accessToken));
+file_put_contents(dirname(__FILE__).'/../access_token.json', json_encode($accessToken));
 
 echo "Done!\n";

Braces +3 added lines, -2 removed lines

@@ -55,8 +55,9 @@
         }
         
         // Determine if there are more projects.
-        if ($result->getNextPage()==null)
-            break;
+        if ($result->getNextPage()==null) {
+                    break;
+        }
         
         // Increment page counter.
         $page ++;

tests/OptimizelyPHPTest/Service/v2/EventsTest.php

Indentation +48 added lines, -48 removed lines

@@ -24,8 +24,8 @@ 
                             "category" => "add_to_cart",
                             "description" => "Item added to cart",
                             "event_filter" => array(
-                              "filter_type" => "target_selector",
-                              "selector" => ".menu-options"
+                                "filter_type" => "target_selector",
+                                "selector" => ".menu-options"
                             ),
                             "event_type" => "custom",
                             "key" => "add_to_cart",
@@ -64,8 +64,8 @@ 
                             "category" => "add_to_cart",
                             "description" => "Item added to cart",
                             "event_filter" => array(
-                              "filter_type" => "target_selector",
-                              "selector" => ".menu-options"
+                                "filter_type" => "target_selector",
+                                "selector" => ".menu-options"
                             ),
                             "event_type" => "custom",
                             "key" => "add_to_cart",
@@ -98,22 +98,22 @@ 
                             ->getMock();
 
         $result = new Result(array(
-                              "event_filter" => array(
+                                "event_filter" => array(
                                 "filter_type" => "target_selector",
                                 "selector" => ".menu-options"
-                              ),
-                              "name" => "Add to Cart",
-                              "archived" => true,
-                              "category" => "add_to_cart",
-                              "description" => "string",
-                              "event_type" => "click",
-                              "key" => "add_to_cart",
-                              "created" => "2016-10-18T05:07:04.153Z",
-                              "id" => 0,
-                              "is_classic" => false,
-                              "is_editable" => true,
-                              "page_id" => 0,
-                              "project_id" => 1000
+                                ),
+                                "name" => "Add to Cart",
+                                "archived" => true,
+                                "category" => "add_to_cart",
+                                "description" => "string",
+                                "event_type" => "click",
+                                "key" => "add_to_cart",
+                                "created" => "2016-10-18T05:07:04.153Z",
+                                "id" => 0,
+                                "is_classic" => false,
+                                "is_editable" => true,
+                                "page_id" => 0,
+                                "project_id" => 1000
                         ), 201);
         
         $optimizelyApiClientMock->method('sendApiRequest')
@@ -122,16 +122,16 @@ 
         $eventsService = new Events($optimizelyApiClientMock);
         
         $event = new ClickEvent(array(
-              "event_filter" => array(
+                "event_filter" => array(
                 "filter_type" => "target_selector",
                 "selector" => ".menu-options"
-              ),
-              "name" => "Add to Cart",
-              "archived" => true,
-              "category" => "add_to_cart",
-              "description" => "string",
-              "event_type" => "click",
-              "key" => "add_to_cart"
+                ),
+                "name" => "Add to Cart",
+                "archived" => true,
+                "category" => "add_to_cart",
+                "description" => "string",
+                "event_type" => "click",
+                "key" => "add_to_cart"
         ));
         
         $result = $eventsService->createClickEvent(0, $event);
@@ -192,22 +192,22 @@ 
                             ->getMock();
 
         $result = new Result(array(
-                              "event_filter" => array(
+                                "event_filter" => array(
                                 "filter_type" => "target_selector",
                                 "selector" => ".menu-options"
-                              ),
-                              "name" => "Add to Cart",
-                              "archived" => true,
-                              "category" => "add_to_cart",
-                              "description" => "string",
-                              "event_type" => "click",
-                              "key" => "add_to_cart",
-                              "created" => "2016-10-18T05:07:04.153Z",
-                              "id" => 0,
-                              "is_classic" => false,
-                              "is_editable" => true,
-                              "page_id" => 0,
-                              "project_id" => 1000
+                                ),
+                                "name" => "Add to Cart",
+                                "archived" => true,
+                                "category" => "add_to_cart",
+                                "description" => "string",
+                                "event_type" => "click",
+                                "key" => "add_to_cart",
+                                "created" => "2016-10-18T05:07:04.153Z",
+                                "id" => 0,
+                                "is_classic" => false,
+                                "is_editable" => true,
+                                "page_id" => 0,
+                                "project_id" => 1000
                         ), 200);
         
         $optimizelyApiClientMock->method('sendApiRequest')
@@ -216,16 +216,16 @@ 
         $eventsService = new Events($optimizelyApiClientMock);
         
         $event = new ClickEvent(array(
-              "event_filter" => array(
+                "event_filter" => array(
                 "filter_type" => "target_selector",
                 "selector" => ".menu-options"
-              ),
-              "name" => "Add to Cart",
-              "archived" => true,
-              "category" => "add_to_cart",
-              "description" => "string",
-              "event_type" => "click",
-              "key" => "add_to_cart"
+                ),
+                "name" => "Add to Cart",
+                "archived" => true,
+                "category" => "add_to_cart",
+                "description" => "string",
+                "event_type" => "click",
+                "key" => "add_to_cart"
         ));
         
         $result = $eventsService->updateClickEvent(0, 0, $event);

Spacing +7 added lines, -7 removed lines

@@ -47,9 +47,9 @@ 
         $result = $eventsService->listAll(1000, true);
         $events = $result->getPayload();
         
-        $this->assertTrue(count($events)==1);
+        $this->assertTrue(count($events) == 1);
         $this->assertTrue($events[0] instanceOf Event);
-        $this->assertTrue($events[0]->getName()=='Add to Cart');        
+        $this->assertTrue($events[0]->getName() == 'Add to Cart');        
     }
     
     public function testGet()
@@ -87,7 +87,7 @@ 
         $event = $result->getPayload();
         
         $this->assertTrue($event instanceOf Event);
-        $this->assertTrue($event->getName()=='Add to Cart');        
+        $this->assertTrue($event->getName() == 'Add to Cart');        
     }
     
     public function testCreateClickEvent()
@@ -138,7 +138,7 @@ 
         $createdEvent = $result->getPayload();
         
         $this->assertTrue($createdEvent instanceOf ClickEvent);
-        $this->assertTrue($createdEvent->getName()=='Add to Cart');                
+        $this->assertTrue($createdEvent->getName() == 'Add to Cart');                
     }
     
     public function testCreateCustomEvent()
@@ -181,7 +181,7 @@ 
         $createdEvent = $result->getPayload();
         
         $this->assertTrue($createdEvent instanceOf CustomEvent);
-        $this->assertTrue($createdEvent->getName()=='Loaded New App');                
+        $this->assertTrue($createdEvent->getName() == 'Loaded New App');                
     }
     
     public function testUpdateClickEvent()
@@ -232,7 +232,7 @@ 
         $updatedEvent = $result->getPayload();
         
         $this->assertTrue($updatedEvent instanceOf ClickEvent);
-        $this->assertTrue($updatedEvent->getName()=='Add to Cart');                
+        $this->assertTrue($updatedEvent->getName() == 'Add to Cart');                
     }
     
     public function testUpdateCustomEvent()
@@ -275,7 +275,7 @@ 
         $updatedEvent = $result->getPayload();
         
         $this->assertTrue($updatedEvent instanceOf CustomEvent);
-        $this->assertTrue($updatedEvent->getName()=='Loaded New App');                
+        $this->assertTrue($updatedEvent->getName() == 'Loaded New App');                
     }
 }
 

lib/WebMarketingROI/OptimizelyPHP/Service/v2/Projects.php

Spacing +6 added lines, -6 removed lines

@@ -35,13 +35,13 @@ 
      * @return Result
      * @throws Exception
      */
-    public function listAll($page=1, $perPage=25)
+    public function listAll($page = 1, $perPage = 25)
     {
-        if ($page<0) {
+        if ($page < 0) {
             throw new Exception('Invalid page number passed');
         }
         
-        if ($perPage<0 || $perPage>100) {
+        if ($perPage < 0 || $perPage > 100) {
             throw new Exception('Invalid page size passed');
         }
         
@@ -69,7 +69,7 @@ 
      */
     public function get($projectId)
     {
-        $projectId = (string)$projectId;
+        $projectId = (string) $projectId;
         
         if (!preg_match('/^\d+$/', $projectId)) {
             throw new Exception("A positive integer project ID expected, while got $projectId");
@@ -114,13 +114,13 @@ 
      */
     public function update($projectId, $project) 
     {
-        $projectId = (string)$projectId;
+        $projectId = (string) $projectId;
         
         if (!preg_match('/\d+/', $projectId)) {
             throw new Exception("A positive integer project ID expected, while got $projectId");
         }
         
-        if ($projectId<0) {
+        if ($projectId < 0) {
             throw new Exception("A positive project ID expected");
         }
         

lib/WebMarketingROI/OptimizelyPHP/Resource/v2/Project.php

Spacing +3 added lines, -3 removed lines

@@ -122,7 +122,7 @@ 
                 case 'last_modified': $this->setLastModified($value); break;
                 case 'socket_token': $this->setSocketToken($value); break;
                 default:
-                    throw new Exception('Unknown option: ' . $name);
+                    throw new Exception('Unknown option: '.$name);
             }
         }
     }
@@ -140,7 +140,7 @@ 
             'platform' => $this->getPlatform(),
             'sdks' => $this->getSdks(),
             'status' => $this->getStatus(),
-            'web_snippet' => $this->getWebSnippet()?$this->getWebSnippet()->toArray():null,
+            'web_snippet' => $this->getWebSnippet() ? $this->getWebSnippet()->toArray() : null,
             'created' => $this->getCreated(),
             'id' => $this->getId(),
             'is_classic' => $this->getIsClassic(),
@@ -151,7 +151,7 @@ 
         // Remove options with empty values
         $cleanedOptions = array();
         foreach ($options as $name=>$value) {
-            if ($value!==null)
+            if ($value !== null)
                 $cleanedOptions[$name] = $value;
         }
         

Braces +3 added lines, -2 removed lines

@@ -91,8 +91,9 @@
         // Remove options with empty values
         $cleanedOptions = array();
         foreach ($options as $name=>$value) {
-            if ($value!==null)
-                $cleanedOptions[$name] = $value;
+            if ($value!==null) {
+                            $cleanedOptions[$name] = $value;
+            }
         }
         
         return $cleanedOptions;

lib/WebMarketingROI/OptimizelyPHP/Resource/v2/Page.php

Spacing +2 added lines, -2 removed lines

@@ -84,7 +84,7 @@ 
                 case 'id': $this->setId($value); break;
                 case 'last_modified': $this->setLastModified($value); break;
                 default:
-                    throw new Exception('Unknown option: ' . $name);
+                    throw new Exception('Unknown option: '.$name);
             }
         }
     }
@@ -109,7 +109,7 @@ 
         // Remove options with empty values
         $cleanedOptions = array();
         foreach ($options as $name=>$value) {
-            if ($value!==null)
+            if ($value !== null)
                 $cleanedOptions[$name] = $value;
         }
         

Braces +3 added lines, -2 removed lines

@@ -91,8 +91,9 @@
         // Remove options with empty values
         $cleanedOptions = array();
         foreach ($options as $name=>$value) {
-            if ($value!==null)
-                $cleanedOptions[$name] = $value;
+            if ($value!==null) {
+                            $cleanedOptions[$name] = $value;
+            }
         }
         
         return $cleanedOptions;