ExperimentResults - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/webmar..." - webmarketingroi/optimizely-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 979a9d...8b1dd2 )

by Oleg

created 2018-05-14 05:46 UTC

ExperimentResults A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	173
Duplicated Lines	4.62 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

29.23%

Importance

Changes

Metric	Value
dl	8
loc	173
ccs	19
cts	65
cp	0.2923
rs	10
c	0
b	0
f	0
wmc	29
lcom	1
cbo	4

16 Methods

Rating	Name	Duplication	Size	Complexity
C	__construct()	8	23	10
B	toArray()	0	25	5
A	getConfidenceThreshold()	0	4	1
A	setConfidenceThreshold()	0	4	1
A	getEndTime()	0	4	1
A	setEndTime()	0	4	1
A	getExperimentId()	0	4	1
A	setExperimentId()	0	4	1
A	getMetrics()	0	4	1
A	setMetrics()	0	4	1
A	getReach()	0	4	1
A	setReach()	0	4	1
A	getStartTime()	0	4	1
A	setStartTime()	0	4	1
A	getStatsConfig()	0	4	1
A	setStatsConfig()	0	4	1

How to fix Duplicated Code

<?php
/**
 * @author Oleg Krivtsov <[email protected]>
 * @date 12 October 2016
 * @copyright (c) 2016, Web Marketing ROI
 */
namespace WebMarketingROI\OptimizelyPHP\Resource\v2;

use WebMarketingROI\OptimizelyPHP\Exception;
use WebMarketingROI\OptimizelyPHP\Resource\v2\ExperimentMetricResults;
use WebMarketingROI\OptimizelyPHP\Resource\v2\ExperimentVariationReach;
use WebMarketingROI\OptimizelyPHP\Resource\v2\StatsConfig;

/**
 * Optimizely experiment results.
 */
class ExperimentResults
{
    /**
     * The significance level at which you would like to declare winning and 
     * losing variations. A lower number minimizes the time needed to declare 
     * a winning or losing variation, but increases the risk that your results 
     * aren't true winners and losers.
     * @var number
     */
    private $confidenceThreshold;
    
    /**
     * The latest time to count events in results
     * @var string
     */
    private $endTime;
    
    /**
     * The unique identifier for the Experiment.
     * @var type 
     */
    private $experimentId;
    
    /**
     * The breakdown of experiment results by metric
     * @var array[ExperimentMetricResult]
     */
    private $metrics;
    
    /**
     * The total number of users exposed to a different experience
     * @var ExperimentVariationReach
     */
    private $reach;
    
    /**
     * The earliest time to count events in results
     * @var string 
     */
    private $startTime;
    
    /**
     *
     * @var StatsConfig 
     */
    private $statsConfig;
    
    /**
     * Constructor.
     */
    public function __construct($options = array())
    {
        foreach ($options as $name=>$value) {
            switch ($name) {                
                case 'confidence_threshold': $this->setConfidenceThreshold($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'end_time': $this->setEndTime($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'experiment_id': $this->setExperimentId($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'metrics': {
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    $metrics = array();
                    foreach ($value as $metricInfo) {
                        $metrics[] = new ExperimentMetricResults($metricInfo);                        
                    }
                    $this->setMetrics($metrics); 
                    break;
                }
                case 'reach': $this->setReach(new ExperimentVariationReach($value)); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'start_time': $this->setStartTime($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'stats_config': $this->setStatsConfig(new StatsConfig($value)); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                default:
                    throw new Exception('Unknown option found in the ExperimentResults entity: ' . $name);
            }
        }
    }
    
    /**
     * Returns this object as array.
     */
    public function toArray()
    {
        $options = array(
            'confidence_threshold' => $this->getConfidenceThreshold(),
            'end_time' => $this->getEndTime(),
            'experiment_id' => $this->getExperimentId(),
            'metrics' => array(),
            'reach' => $this->getReach()?$this->getReach()->toArray():null,
            'start_time' => $this->getStartTime(),
            'stats_config' => $this->getStatsConfig()->toArray(),
        );
        
        foreach ($this->getMetrics() as $metric) {
            $options['metrics'][] = $metric->toArray();
        }
        
        // Remove options with empty values
        $cleanedOptions = array();
        foreach ($options as $name=>$value) {
            if ($value!==null)
                $cleanedOptions[$name] = $value;
        }
        
        return $cleanedOptions;
    }
    
    public function getConfidenceThreshold()
    {
        return $this->confidenceThreshold;
    }
    
    public function setConfidenceThreshold($confidenceThreshold)
    {
        $this->confidenceThreshold = $confidenceThreshold;
    }
    
    public function getEndTime()
    {
        return $this->endTime;
    }
    
    public function setEndTime($endTime)
    {
        $this->endTime = $endTime;
    }
    
    public function getExperimentId()
    {
        return $this->experimentId;
    }
    
    public function setExperimentId($experimentId)
    {
        $this->experimentId = $experimentId;
    }
    
    public function getMetrics()
    {
        return $this->metrics;
    }
    
    public function setMetrics($metrics)
    {
        $this->metrics = $metrics;
    }
    
    public function getReach()
    {
        return $this->reach;
    }
    
    public function setReach($reach)
    {
        $this->reach = $reach;
    }
    
    public function getStartTime()
    {
        return $this->startTime;
    }
    
    public function setStartTime($startTime)
    {
        $this->startTime = $startTime;
    }
    
    public function getStatsConfig()
    {
        return $this->statsConfig;
    }
    
    public function setStatsConfig($statsConfig)
    {
        $this->statsConfig = $statsConfig;
    }
}












1			<?php
2			/**
3			* @author Oleg Krivtsov <[email protected]>
4			* @date 12 October 2016
5			* @copyright (c) 2016, Web Marketing ROI
6			*/
7			namespace WebMarketingROI\OptimizelyPHP\Resource\v2;
8
9			use WebMarketingROI\OptimizelyPHP\Exception;
10			use WebMarketingROI\OptimizelyPHP\Resource\v2\ExperimentMetricResults;
11			use WebMarketingROI\OptimizelyPHP\Resource\v2\ExperimentVariationReach;
12			use WebMarketingROI\OptimizelyPHP\Resource\v2\StatsConfig;
13
14			/**
15			* Optimizely experiment results.
16			*/
17			class ExperimentResults
18			{
19			/**
20			* The significance level at which you would like to declare winning and
21			* losing variations. A lower number minimizes the time needed to declare
22			* a winning or losing variation, but increases the risk that your results
23			* aren't true winners and losers.
24			* @var number
25			*/
26			private $confidenceThreshold;
27
28			/**
29			* The latest time to count events in results
30			* @var string
31			*/
32			private $endTime;
33
34			/**
35			* The unique identifier for the Experiment.
36			* @var type
37			*/
38			private $experimentId;
39
40			/**
41			* The breakdown of experiment results by metric
42			* @var array[ExperimentMetricResult]
43			*/
44			private $metrics;
45
46			/**
47			* The total number of users exposed to a different experience
48			* @var ExperimentVariationReach
49			*/
50			private $reach;
51
52			/**
53			* The earliest time to count events in results
54			* @var string
55			*/
56			private $startTime;
57
58			/**
59			*
60			* @var StatsConfig
61			*/
62			private $statsConfig;
63
64			/**
65			* Constructor.
66			*/
67	3		public function __construct($options = array())
68			{
69	3		foreach ($options as $name=>$value) {
70			switch ($name) {
71	3		case 'confidence_threshold': $this->setConfidenceThreshold($value); break;
			0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
72	3		case 'end_time': $this->setEndTime($value); break;
			0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
73	3		case 'experiment_id': $this->setExperimentId($value); break;
			0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
74	3	View Code Duplication	case 'metrics': {
			0 ignored issues – show Duplication introduced 2018-05-14 05:48 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
75	3		$metrics = array();
76	3		foreach ($value as $metricInfo) {
77	3		$metrics[] = new ExperimentMetricResults($metricInfo);
78			}
79			$this->setMetrics($metrics);
80			break;
81			}
82			case 'reach': $this->setReach(new ExperimentVariationReach($value)); break;
			0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
83			case 'start_time': $this->setStartTime($value); break;
			0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
84			case 'stats_config': $this->setStatsConfig(new StatsConfig($value)); break;
			0 ignored issues – show Coding Style introduced 2018-05-14 05:48 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2018-05-14 05:48 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
85			default:
86	3		throw new Exception('Unknown option found in the ExperimentResults entity: ' . $name);
87			}
88			}
89			}
90
91			/**
92			* Returns this object as array.
93			*/
94			public function toArray()
95			{
96			$options = array(
97			'confidence_threshold' => $this->getConfidenceThreshold(),
98			'end_time' => $this->getEndTime(),
99			'experiment_id' => $this->getExperimentId(),
100			'metrics' => array(),
101			'reach' => $this->getReach()?$this->getReach()->toArray():null,
102			'start_time' => $this->getStartTime(),
103			'stats_config' => $this->getStatsConfig()->toArray(),
104			);
105
106			foreach ($this->getMetrics() as $metric) {
107			$options['metrics'][] = $metric->toArray();
108			}
109
110			// Remove options with empty values
111			$cleanedOptions = array();
112			foreach ($options as $name=>$value) {
113			if ($value!==null)
114			$cleanedOptions[$name] = $value;
115			}
116
117			return $cleanedOptions;
118			}
119
120			public function getConfidenceThreshold()
121			{
122			return $this->confidenceThreshold;
123			}
124
125	3		public function setConfidenceThreshold($confidenceThreshold)
126			{
127	3		$this->confidenceThreshold = $confidenceThreshold;
128	3		}
129
130			public function getEndTime()
131			{
132			return $this->endTime;
133			}
134
135	3		public function setEndTime($endTime)
136			{
137	3		$this->endTime = $endTime;
138	3		}
139
140			public function getExperimentId()
141			{
142			return $this->experimentId;
143			}
144
145	3		public function setExperimentId($experimentId)
146			{
147	3		$this->experimentId = $experimentId;
148	3		}
149
150			public function getMetrics()
151			{
152			return $this->metrics;
153			}
154
155			public function setMetrics($metrics)
156			{
157			$this->metrics = $metrics;
158			}
159
160			public function getReach()
161			{
162			return $this->reach;
163			}
164
165			public function setReach($reach)
166			{
167			$this->reach = $reach;
168			}
169
170			public function getStartTime()
171			{
172			return $this->startTime;
173			}
174
175			public function setStartTime($startTime)
176			{
177			$this->startTime = $startTime;
178			}
179
180			public function getStatsConfig()
181			{
182			return $this->statsConfig;
183			}
184
185			public function setStatsConfig($statsConfig)
186			{
187			$this->statsConfig = $statsConfig;
188			}
189			}
190
191
192
193
194
195
196
197
198
199
200

webmarketingroi / optimizely-php

Push — master ( 979a9d...8b1dd2 )

ExperimentResults A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

16 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like