Inspection of "Fixing: Getting an error when listing experiments..." - webmarketingroi/optimizely-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fe2892...6427ed )

by Oleg

created 2017-05-08 05:38 UTC

Status

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -146,7 +146,9 @@
 block discarded – undo
         }
         
         $queryParams = array();
-        if ($action!=null) $queryParams['action'] = $action;
+        if ($action!=null) {
+            $queryParams['action'] = $action;
+        }
         
         $postData = $experiment->toArray();
         

Please login to merge, or discard this patch.

tests/OptimizelyPHPTest/Service/v2/AudiencesTest.php 1 patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -238,8 +238,9 @@  discard block
 block discarded – undo
     
     public function testIntegration()
     {
-        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) 
-            $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
+                    $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        }
         
         $credentials = $this->loadCredentialsFromFile();
         
@@ -301,13 +302,13 @@  discard block
 block discarded – undo
                     }
                 }
 
-                if ($result->getNextPage()==null)
-                    break;
+                if ($result->getNextPage()==null) {
+                                    break;
+                }
 
                 $page ++;
             }
-        }
-        catch (Exception $e) {
+        } catch (Exception $e) {
             // Handle error.
             $code = $e->getCode();
             $httpCode = $e->getHttpCode();

Please login to merge, or discard this patch.

tests/OptimizelyPHPTest/Service/v2/ExperimentsTest.php 1 patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -748,8 +748,9 @@  discard block
 block discarded – undo
     
     public function testIntegration()
     {
-        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) 
-            $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
+                    $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        }
         
         $credentials = $this->loadCredentialsFromFile();
         
@@ -924,13 +925,13 @@  discard block
 block discarded – undo
                     }
                 }
 
-                if ($result->getNextPage()==null)
-                    break;
+                if ($result->getNextPage()==null) {
+                                    break;
+                }
 
                 $page ++;
             }
-        }
-        catch (Exception $e) {
+        } catch (Exception $e) {
             // Handle error.
             $code = $e->getCode();
             $httpCode = $e->getHttpCode();

Please login to merge, or discard this patch.

tests/OptimizelyPHPTest/Service/v2/EventsTest.php 1 patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -282,8 +282,9 @@  discard block
 block discarded – undo
     
     public function testIntegration()
     {
-        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) 
-            $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
+                    $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        }
         
         $credentials = $this->loadCredentialsFromFile();
         
@@ -378,13 +379,13 @@  discard block
 block discarded – undo
                     }
                 }
 
-                if ($result->getNextPage()==null)
-                    break;
+                if ($result->getNextPage()==null) {
+                                    break;
+                }
 
                 $page ++;
             }
-        }
-        catch (Exception $e) {
+        } catch (Exception $e) {
             // Handle error.
             $code = $e->getCode();
             $httpCode = $e->getHttpCode();

Please login to merge, or discard this patch.

tests/OptimizelyPHPTest/Service/v2/AttributesTest.php 1 patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -188,8 +188,9 @@  discard block
 block discarded – undo
     
     public function testIntegration()
     {
-        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) 
-            $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
+                    $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        }
         
         $credentials = $this->loadCredentialsFromFile();
         
@@ -253,13 +254,13 @@  discard block
 block discarded – undo
                     }
                 }
 
-                if ($result->getNextPage()==null)
-                    break;
+                if ($result->getNextPage()==null) {
+                                    break;
+                }
 
                 $page ++;
             }
-        }
-        catch (Exception $e) {
+        } catch (Exception $e) {
             // Handle error.
             $code = $e->getCode();
             $httpCode = $e->getHttpCode();

Please login to merge, or discard this patch.

tests/OptimizelyPHPTest/Service/v2/PagesTest.php 1 patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -200,8 +200,9 @@  discard block
 block discarded – undo
     
     public function testIntegration()
     {
-        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) 
-            $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
+                    $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        }
         
         $credentials = $this->loadCredentialsFromFile();
         
@@ -270,13 +271,13 @@  discard block
 block discarded – undo
                     }
                 }
 
-                if ($result->getNextPage()==null)
-                    break;
+                if ($result->getNextPage()==null) {
+                                    break;
+                }
 
                 $page ++;
             }
-        }
-        catch (Exception $e) {
+        } catch (Exception $e) {
             // Handle error.
             $code = $e->getCode();
             $httpCode = $e->getHttpCode();

Please login to merge, or discard this patch.

		@@ -146,7 +146,9 @@
		block discarded – undo
146	146	}
147	147
148	148	$queryParams = array();
149		- if ($action!=null) $queryParams['action'] = $action;
	149	+ if ($action!=null) {
	150	+ $queryParams['action'] = $action;
	151	+ }
150	152
151	153	$postData = $experiment->toArray();
152	154

		@@ -238,8 +238,9 @@ discard block
		block discarded – undo
238	238
239	239	public function testIntegration()
240	240	{
241		- if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION'))
242		- $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	241	+ if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
	242	+ $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	243	+ }
243	244
244	245	$credentials = $this->loadCredentialsFromFile();
245	246
		@@ -301,13 +302,13 @@ discard block
		block discarded – undo
301	302	}
302	303	}
303	304
304		- if ($result->getNextPage()==null)
305		- break;
	305	+ if ($result->getNextPage()==null) {
	306	+ break;
	307	+ }
306	308
307	309	$page ++;
308	310	}
309		- }
310		- catch (Exception $e) {
	311	+ } catch (Exception $e) {
311	312	// Handle error.
312	313	$code = $e->getCode();
313	314	$httpCode = $e->getHttpCode();

		@@ -748,8 +748,9 @@ discard block
		block discarded – undo
748	748
749	749	public function testIntegration()
750	750	{
751		- if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION'))
752		- $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	751	+ if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
	752	+ $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	753	+ }
753	754
754	755	$credentials = $this->loadCredentialsFromFile();
755	756
		@@ -924,13 +925,13 @@ discard block
		block discarded – undo
924	925	}
925	926	}
926	927
927		- if ($result->getNextPage()==null)
928		- break;
	928	+ if ($result->getNextPage()==null) {
	929	+ break;
	930	+ }
929	931
930	932	$page ++;
931	933	}
932		- }
933		- catch (Exception $e) {
	934	+ } catch (Exception $e) {
934	935	// Handle error.
935	936	$code = $e->getCode();
936	937	$httpCode = $e->getHttpCode();

		@@ -282,8 +282,9 @@ discard block
		block discarded – undo
282	282
283	283	public function testIntegration()
284	284	{
285		- if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION'))
286		- $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	285	+ if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
	286	+ $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	287	+ }
287	288
288	289	$credentials = $this->loadCredentialsFromFile();
289	290
		@@ -378,13 +379,13 @@ discard block
		block discarded – undo
378	379	}
379	380	}
380	381
381		- if ($result->getNextPage()==null)
382		- break;
	382	+ if ($result->getNextPage()==null) {
	383	+ break;
	384	+ }
383	385
384	386	$page ++;
385	387	}
386		- }
387		- catch (Exception $e) {
	388	+ } catch (Exception $e) {
388	389	// Handle error.
389	390	$code = $e->getCode();
390	391	$httpCode = $e->getHttpCode();

		@@ -188,8 +188,9 @@ discard block
		block discarded – undo
188	188
189	189	public function testIntegration()
190	190	{
191		- if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION'))
192		- $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	191	+ if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
	192	+ $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	193	+ }
193	194
194	195	$credentials = $this->loadCredentialsFromFile();
195	196
		@@ -253,13 +254,13 @@ discard block
		block discarded – undo
253	254	}
254	255	}
255	256
256		- if ($result->getNextPage()==null)
257		- break;
	257	+ if ($result->getNextPage()==null) {
	258	+ break;
	259	+ }
258	260
259	261	$page ++;
260	262	}
261		- }
262		- catch (Exception $e) {
	263	+ } catch (Exception $e) {
263	264	// Handle error.
264	265	$code = $e->getCode();
265	266	$httpCode = $e->getHttpCode();

		@@ -200,8 +200,9 @@ discard block
		block discarded – undo
200	200
201	201	public function testIntegration()
202	202	{
203		- if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION'))
204		- $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	203	+ if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
	204	+ $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
	205	+ }
205	206
206	207	$credentials = $this->loadCredentialsFromFile();
207	208
		@@ -270,13 +271,13 @@ discard block
		block discarded – undo
270	271	}
271	272	}
272	273
273		- if ($result->getNextPage()==null)
274		- break;
	274	+ if ($result->getNextPage()==null) {
	275	+ break;
	276	+ }
275	277
276	278	$page ++;
277	279	}
278		- }
279		- catch (Exception $e) {
	280	+ } catch (Exception $e) {
280	281	// Handle error.
281	282	$code = $e->getCode();
282	283	$httpCode = $e->getHttpCode();

webmarketingroi / optimizely-php

Push — master ( fe2892...6427ed )

Status

Category

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch