ChangeAttribute::__construct() - Code Metrics - Inspection of "Fixing: Getting an error when listing experiments..." - webmarketingroi/optimizely-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fe2892...6427ed )

by Oleg

created 2017-05-08 05:38 UTC

ChangeAttribute::__construct() B

↳ Parent: ChangeAttribute

Complexity

Conditions	10
Paths	10

Size

Total Lines	17
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	10.7998

Importance

Changes

Metric	Value
cc	10
eloc	13
nc	10
nop	1
dl	0
loc	17
ccs	12
cts	15
cp	0.8
crap	10.7998
rs	7.2765
c	0
b	0
f	0

How to fix Complexity

<?php
/**
 * @author Oleg Krivtsov <[email protected]>
 * @date 04 May 2017
 * @copyright (c) 2017, Web Marketing ROI
 */
namespace WebMarketingROI\OptimizelyPHP\Resource\v2;

use WebMarketingROI\OptimizelyPHP\Exception;

/**
 * An Optimizely campaign change attributes.
 */
class ChangeAttribute
{
    /**
     * Name of the class to set the element(s) matched by a selector to
     * @var string
     */
    private $class;
    
    /**
     * Whether or not to hide the element(s) matched by a selector
     * @var boolean
     */
    private $hide;
    
    /**
     * Value of href attribute to add to element(s) matched by a selector
     * @var string
     */
    private $href;
    
    /**
     * Value of HTML attribute to add to element(s) matched by a selector
     * @var string
     */
    private $html;
    
    /**
     * Whether or not to remove the element(s) matched by a selector
     * @var boolean 
     */
    private $remove;
    
    /**
     * Value of src attribute to add to element(s) matched by a selector
     * @var string
     */
    private $src;
    
    /**
     * Value of style attribute to add to element(s) matched by a selector
     * @var string
     */
    private $style;
    
    /**
     * Value of text attribute to add to the element(s) matched by a selector
     * @var string
     */
    private $text;
    
    /**
     * Constructor.
     */
    public function __construct($options = array())
    {
        foreach ($options as $name=>$value) {
            switch ($name) {                
                case 'class': $this->setClass($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'hide': $this->setHide($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'href': $this->setHref($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'html': $this->setHtml($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'remove': $this->setRemove($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'src': $this->setSrc($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'style': $this->setStyle($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                case 'text': $this->setText($value); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                default:
                    throw new Exception('Unknown option found in the ChangeAttribute entity: ' . $name);
            }
        }
    }
    
    /**
     * Returns this object as array.
     */
    public function toArray()
    {
        $options = array(
            'class' => $this->getClass(),
            'hide' => $this->getHide(),
            'href' => $this->getHref(),
            'html' => $this->getHtml(),
            'remove' => $this->getRemove(),
            'src' => $this->getSrc(),
            'style' => $this->getStyle(),
            'text' => $this->getText(),
        );
        
        // Remove options with empty values
        $cleanedOptions = array();
        foreach ($options as $name=>$value) {
            if ($value!==null)
                $cleanedOptions[$name] = $value;
        }
        
        return $cleanedOptions;
    }
    
    public function getClass()
    {
        return $this->class;
    }
    
    public function setClass($class)
    {
        $this->class = $class;
    }
    
    public function getHide()
    {
        return $this->hide;
    }
    
    public function setHide($hide)
    {
        $this->hide = $hide;
    }
    
    public function getHref()
    {
        return $this->href;
    }
    
    public function setHref($href)
    {
        $this->href = $href;
    }
    
    public function getHtml()
    {
        return $this->html;
    }
    
    public function setHtml($html)
    {
        $this->html = $html;
    }
    
    public function getRemove()
    {
        return $this->remove;
    }
    
    public function setRemove($remove)
    {
        $this->remove = $remove;
    }
    
    public function getSrc()
    {
        return $this->src;
    }
    
    public function setSrc($src)
    {
        $this->src = $src;
    }
    
    public function getStyle()
    {
        return $this->style;
    }
    
    public function setStyle($style)
    {
        $this->style = $style;
    }
    
    public function getText()
    {
        return $this->text;
    }
    
    public function setText($text)
    {
        $this->text = $text;
    }
}







1		<?php
2		/**
3		* @author Oleg Krivtsov <[email protected]>
4		* @date 04 May 2017
5		* @copyright (c) 2017, Web Marketing ROI
6		*/
7		namespace WebMarketingROI\OptimizelyPHP\Resource\v2;
8
9		use WebMarketingROI\OptimizelyPHP\Exception;
10
11		/**
12		* An Optimizely campaign change attributes.
13		*/
14		class ChangeAttribute
15		{
16		/**
17		* Name of the class to set the element(s) matched by a selector to
18		* @var string
19		*/
20		private $class;
21
22		/**
23		* Whether or not to hide the element(s) matched by a selector
24		* @var boolean
25		*/
26		private $hide;
27
28		/**
29		* Value of href attribute to add to element(s) matched by a selector
30		* @var string
31		*/
32		private $href;
33
34		/**
35		* Value of HTML attribute to add to element(s) matched by a selector
36		* @var string
37		*/
38		private $html;
39
40		/**
41		* Whether or not to remove the element(s) matched by a selector
42		* @var boolean
43		*/
44		private $remove;
45
46		/**
47		* Value of src attribute to add to element(s) matched by a selector
48		* @var string
49		*/
50		private $src;
51
52		/**
53		* Value of style attribute to add to element(s) matched by a selector
54		* @var string
55		*/
56		private $style;
57
58		/**
59		* Value of text attribute to add to the element(s) matched by a selector
60		* @var string
61		*/
62		private $text;
63
64		/**
65		* Constructor.
66		*/
67	3	public function __construct($options = array())
68		{
69	3	foreach ($options as $name=>$value) {
70		switch ($name) {
71	3	case 'class': $this->setClass($value); break;
		0 ignored issues – show Coding Style introduced 2017-05-08 05:41 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-05-08 05:41 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
72	3	case 'hide': $this->setHide($value); break;
		0 ignored issues – show Coding Style introduced 2017-05-08 05:41 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-05-08 05:41 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
73	3	case 'href': $this->setHref($value); break;
		0 ignored issues – show Coding Style introduced 2017-05-08 05:41 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-05-08 05:41 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
74	3	case 'html': $this->setHtml($value); break;
		0 ignored issues – show Coding Style introduced 2017-05-08 05:41 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-05-08 05:41 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
75	3	case 'remove': $this->setRemove($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
76	3	case 'src': $this->setSrc($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
77	3	case 'style': $this->setStyle($value); break;
		0 ignored issues – show Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-10-19 01:09 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
78	3	case 'text': $this->setText($value); break;
		0 ignored issues – show Coding Style introduced 2017-05-08 05:41 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-05-08 05:41 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
79		default:
80		throw new Exception('Unknown option found in the ChangeAttribute entity: ' . $name);
81		}
82	3	}
83	3	}
84
85		/**
86		* Returns this object as array.
87		*/
88	1	public function toArray()
89		{
90		$options = array(
91	1	'class' => $this->getClass(),
92	1	'hide' => $this->getHide(),
93	1	'href' => $this->getHref(),
94	1	'html' => $this->getHtml(),
95	1	'remove' => $this->getRemove(),
96	1	'src' => $this->getSrc(),
97	1	'style' => $this->getStyle(),
98	1	'text' => $this->getText(),
99	1	);
100
101		// Remove options with empty values
102	1	$cleanedOptions = array();
103	1	foreach ($options as $name=>$value) {
104	1	if ($value!==null)
105	1	$cleanedOptions[$name] = $value;
106	1	}
107
108	1	return $cleanedOptions;
109		}
110
111	2	public function getClass()
112		{
113	2	return $this->class;
114		}
115
116	3	public function setClass($class)
117		{
118	3	$this->class = $class;
119	3	}
120
121	2	public function getHide()
122		{
123	2	return $this->hide;
124		}
125
126	3	public function setHide($hide)
127		{
128	3	$this->hide = $hide;
129	3	}
130
131	1	public function getHref()
132		{
133	1	return $this->href;
134		}
135
136	3	public function setHref($href)
137		{
138	3	$this->href = $href;
139	3	}
140
141	1	public function getHtml()
142		{
143	1	return $this->html;
144		}
145
146	3	public function setHtml($html)
147		{
148	3	$this->html = $html;
149	3	}
150
151	1	public function getRemove()
152		{
153	1	return $this->remove;
154		}
155
156	3	public function setRemove($remove)
157		{
158	3	$this->remove = $remove;
159	3	}
160
161	1	public function getSrc()
162		{
163	1	return $this->src;
164		}
165
166	3	public function setSrc($src)
167		{
168	3	$this->src = $src;
169	3	}
170
171	1	public function getStyle()
172		{
173	1	return $this->style;
174		}
175
176	3	public function setStyle($style)
177		{
178	3	$this->style = $style;
179	3	}
180
181	1	public function getText()
182		{
183	1	return $this->text;
184		}
185
186	3	public function setText($text)
187		{
188	3	$this->text = $text;
189	3	}
190		}
191
192
193
194
195
196

webmarketingroi / optimizely-php

Push — master ( fe2892...6427ed )

ChangeAttribute::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like