AttributesTest - Code Metrics - Inspection of "Fixing: Getting an error when listing experiments..." - webmarketingroi/optimizely-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fe2892...6427ed )

by Oleg

created 2017-05-08 05:38 UTC

AttributesTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	279
Duplicated Lines	54.48 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

Metric	Value
dl	152
loc	279
rs	10
c	0
b	0
f	0
wmc	13
lcom	1
cbo	7

7 Methods

Rating	Name	Duplication	Size	Complexity
B	testListAll()	33	33	1
A	testListAll_InvalidPage()	11	11	1
A	testListAll_InvalidPerPage()	11	11	1
B	testGet()	0	29	1
B	testCreate()	40	40	1
B	testUpdate()	40	40	1
C	testIntegration()	17	100	7

How to fix Duplicated Code

<?php
namespace OptimizelyPHPTest\Service\v2;

use OptimizelyPHPTest\Service\v2\BaseServiceTest;
use WebMarketingROI\OptimizelyPHP\OptimizelyApiClient;
use WebMarketingROI\OptimizelyPHP\Result;
use WebMarketingROI\OptimizelyPHP\Service\v2\Attributes;
use WebMarketingROI\OptimizelyPHP\Resource\v2\Attribute;
use WebMarketingROI\OptimizelyPHP\Resource\v2\Project;

class AttributesTest extends BaseServiceTest
{
    public function testListAll()

    {
        // Mock 'OptimizelyApiClient' object to avoid real API calls
        $optimizelyApiClientMock = $this->getMockBuilder('\WebMarketingROI\OptimizelyPHP\OptimizelyApiClient')
                            ->disableOriginalConstructor()
                            ->getMock();

        $result = new Result(array(
                        array(
                            "key" => "subscriber_status",
                            "project_id" => 0,
                            "archived" => false,
                            "description" => "string",
                            "name" => "Subscriber Status",
                            "condition_type" => "custom_attribute",
                            "id" => 0,
                            "last_modified" => "2017-05-08T03:34:01.035Z"
                        )
                    ), 200);
        
        
        $optimizelyApiClientMock->method('sendApiRequest')
                    ->willReturn($result);
        
        $attributesService = new Attributes($optimizelyApiClientMock);
        
        $result = $attributesService->listAll(0);
        $attributes = $result->getPayload();
        
        $this->assertTrue(count($attributes)==1);
        $this->assertTrue($attributes[0] instanceOf Attribute);
        $this->assertTrue($attributes[0]->getName()=='Subscriber Status');        
    }
    
    /**
     * @expectedException Exception
     */
    public function testListAll_InvalidPage()

    {
        // Mock 'OptimizelyApiClient' object to avoid real API calls
        $optimizelyApiClientMock = $this->getMockBuilder('\WebMarketingROI\OptimizelyPHP\OptimizelyApiClient')
                            ->disableOriginalConstructor()
                            ->getMock();
        
        $attributesService = new Attributes($optimizelyApiClientMock);
        
        $result = $attributesService->listAll(1000, -1, 25);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
    
    /**
     * @expectedException Exception
     */
    public function testListAll_InvalidPerPage()

    {
        // Mock 'OptimizelyApiClient' object to avoid real API calls
        $optimizelyApiClientMock = $this->getMockBuilder('\WebMarketingROI\OptimizelyPHP\OptimizelyApiClient')
                            ->disableOriginalConstructor()
                            ->getMock();
        
        $attributesService = new Attributes($optimizelyApiClientMock);
        
        $result = $attributesService->listAll(1000, 1, 1000);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
    
    public function testGet()
    {
        // Mock 'OptimizelyApiClient' object to avoid real API calls
        $optimizelyApiClientMock = $this->getMockBuilder('\WebMarketingROI\OptimizelyPHP\OptimizelyApiClient')
                            ->disableOriginalConstructor()
                            ->getMock();

        $result = new Result(array(
                            "key" => "subscriber_status",
                            "project_id" => 0,
                            "archived" => false,
                            "description" => "string",
                            "name" => "Subscriber Status",
                            "condition_type" => "custom_attribute",
                            "id" => 0,
                            "last_modified" => "2017-05-08T03:34:01.035Z"
                        ), 200);
        
        $optimizelyApiClientMock->method('sendApiRequest')
                    ->willReturn($result);
        
        $attributesService = new Attributes($optimizelyApiClientMock);
        
        $result = $attributesService->get(0);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $attribute = $result->getPayload();
        
        $this->assertTrue($attribute instanceOf Attribute);
        $this->assertTrue($attribute->getName()=='Subscriber Status');        
    }
    
    public function testCreate()

    {
        // Mock 'OptimizelyApiClient' object to avoid real API calls
        $optimizelyApiClientMock = $this->getMockBuilder('\WebMarketingROI\OptimizelyPHP\OptimizelyApiClient')
                            ->disableOriginalConstructor()
                            ->getMock();

        $result = new Result(array(
                            "key" => "subscriber_status",
                            "project_id" => 0,
                            "archived" => false,
                            "description" => "string",
                            "name" => "Subscriber Status",
                            "condition_type" => "custom_attribute",
                            "id" => 0,
                            "last_modified" => "2017-05-08T03:34:01.035Z"
                        ), 201);
        
        $optimizelyApiClientMock->method('sendApiRequest')
                    ->willReturn($result);
        
        $attributesService = new Attributes($optimizelyApiClientMock);
        
        $attribute = new Attribute(array(
                "key" => "subscriber_status",
                "project_id" => 0,
                "archived" => false,
                "description" => "string",
                "name" => "Subscriber Status",
                "condition_type" => "custom_attribute",
                "id" => 0,
                "last_modified" => "2017-05-08T03:34:01.035Z"
        ));
        
        $result = $attributesService->create($attribute);
        $createdAttribute = $result->getPayload();
        
        $this->assertTrue($createdAttribute instanceOf Attribute);
        $this->assertTrue($createdAttribute->getName()=='Subscriber Status');                
    }
    
    public function testUpdate()

    {
        // Mock 'OptimizelyApiClient' object to avoid real API calls
        $optimizelyApiClientMock = $this->getMockBuilder('\WebMarketingROI\OptimizelyPHP\OptimizelyApiClient')
                            ->disableOriginalConstructor()
                            ->getMock();

        $result = new Result(array(
                            "key" => "subscriber_status",
                            "project_id" => 0,
                            "archived" => false,
                            "description" => "string",
                            "name" => "Subscriber Status",
                            "condition_type" => "custom_attribute",
                            "id" => 0,
                            "last_modified" => "2017-05-08T03:34:01.035Z"
                        ), 200);
        
        $optimizelyApiClientMock->method('sendApiRequest')
                    ->willReturn($result);
        
        $attributesService = new Attributes($optimizelyApiClientMock);
        
        $attribute = new Attribute(array(
                "key" => "subscriber_status",
                "project_id" => 0,
                "archived" => false,
                "description" => "string",
                "name" => "Subscriber Status",
                "condition_type" => "custom_attribute",
                "id" => 0,
                "last_modified" => "2017-05-08T03:34:01.035Z"
        ));
        
        $result = $attributesService->update(0, $attribute);
        $createdAttribute = $result->getPayload();
        
        $this->assertTrue($createdAttribute instanceOf Attribute);
        $this->assertTrue($createdAttribute->getName()=='Subscriber Status');                
    }
    
    public function testIntegration()
    {
        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) 
            $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
        
        $credentials = $this->loadCredentialsFromFile();
        
        $optimizelyClient = new OptimizelyApiClient($credentials, 'v2');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertTrue($optimizelyClient!=null);
        
        // Create new project        
        $curDate = date('Y-m-d H:i:s');
        $newProject = new Project(array(
            "name" => "Test Project $curDate",
            "account_id" => 12345,
            "confidence_threshold" => 0.9,
            "platform" => "web",
            "status" => "active",
            "web_snippet" => array(
              "enable_force_variation" => false,
              "exclude_disabled_experiments" => false,
              "exclude_names" => true,
              "include_jquery" => true,
              "ip_anonymization" => false,
              "ip_filter" => "^206\\.23\\.100\\.([5-9][0-9]|1([0-4][0-9]|50))$",
              "library" => "jquery-1.11.3-trim",
              "project_javascript" => "alert(\"Active Experiment\")"
            )
        ));
        
        $result = $optimizelyClient->projects()->create($newProject);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $createdProject = $result->getPayload();
        
        // Create new attribute in the project
        $attribute = new Attribute(array(
            "key" => "subscriber_status",
            "project_id" => 0,
            "archived" => false,
            "description" => "string",
            "name" => "Subscriber Status",
            "condition_type" => "custom_attribute",
            "id" => 0,
            "last_modified" => "2017-05-08T03:34:01.035Z"
        ));
        
        $result = $optimizelyClient->attributes()->create($attribute);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $createdAttribute = $result->getPayload();
        
        $this->assertTrue($createdAttribute instanceOf Attribute);
        $this->assertTrue($createdAttribute->getName()=='Subscriber Status');  
        
        // List all existing attributes and try to find the created attribute
        $attributeFound = false;        
        try {
            $page = 1;
            for (;;) {                            

                $result = $optimizelyClient->attributes()->listAll($createdAttribute->getId(), $page);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

                $attributes = $result->getPayload();

                foreach ($attributes as $attribute) {
                    if ($audience->getName()=="Subscriber Status") {

                        $attributeFound = true;
                        break;
                    }
                }

                if ($result->getNextPage()==null)
                    break;

                $page ++;
            }
        }
        catch (Exception $e) {

            // Handle error.
            $code = $e->getCode();
            $httpCode = $e->getHttpCode();
            $message = $e->getMessage();
            $uuid = $e->getUuid();
            echo "Exception caught: $message (code=$code http_code=$httpCode uuid=$uuid)\n";
        }
        
        $this->assertTrue($attributeFound);
        
        // Update attribute
        $createdAttribute->setName('Some new attribute name');
        $result = $optimizelyClient->attributes()->update($createdAttribute->getId(), $createdAttribute);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $updatedAttribute = $result->getPayload();                
        
        $this->assertTrue($updatedAttribute instanceOf Attribute);
        $this->assertTrue($updatedAttribute->getName()=='Some new attribute name');  
        
        // Make project archived
        
        $createdProject->setStatus('archived');
        $result = $optimizelyClient->projects()->update($createdProject->getId(), $createdProject);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $updatedProject = $result->getPayload();
        
        $this->assertEquals('archived', $updatedProject->getStatus());
    }
}



1		<?php
2		namespace OptimizelyPHPTest\Service\v2;
3
4		use OptimizelyPHPTest\Service\v2\BaseServiceTest;
5		use WebMarketingROI\OptimizelyPHP\OptimizelyApiClient;
6		use WebMarketingROI\OptimizelyPHP\Result;
7		use WebMarketingROI\OptimizelyPHP\Service\v2\Attributes;
8		use WebMarketingROI\OptimizelyPHP\Resource\v2\Attribute;
9		use WebMarketingROI\OptimizelyPHP\Resource\v2\Project;
10
11		class AttributesTest extends BaseServiceTest
12		{
13	View Code Duplication	public function testListAll()
		0 ignored issues – show Duplication introduced 2017-05-08 05:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
14		{
15		// Mock 'OptimizelyApiClient' object to avoid real API calls
16		$optimizelyApiClientMock = $this->getMockBuilder('\WebMarketingROI\OptimizelyPHP\OptimizelyApiClient')
17		->disableOriginalConstructor()
18		->getMock();
19
20		$result = new Result(array(
21		array(
22		"key" => "subscriber_status",
23		"project_id" => 0,
24		"archived" => false,
25		"description" => "string",
26		"name" => "Subscriber Status",
27		"condition_type" => "custom_attribute",
28		"id" => 0,
29		"last_modified" => "2017-05-08T03:34:01.035Z"
30		)
31		), 200);
32
33
34		$optimizelyApiClientMock->method('sendApiRequest')
35		->willReturn($result);
36
37		$attributesService = new Attributes($optimizelyApiClientMock);
38
39		$result = $attributesService->listAll(0);

webmarketingroi / optimizely-php

Push — master ( fe2892...6427ed )

AttributesTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like