WebinoImageThumb\PhpThumb\Plugin\Sharpen

Complexity

Total Complexity

4

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	5
Bugs	0	Features	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	3
A	execute()	0	6	1

<?php
/**
 * Webino (https://github.com/webino/)
 *
 * @link      https://github.com/webino/WebinoImageThumb/ for the canonical source repository
 * @copyright Copyright (c) 2013-2015 Webino, s. r. o. (http://webino.sk/)
 * @license   BSD-3-Clause
 */

namespace WebinoImageThumb\PhpThumb\Plugin;

use PHPThumb\GD as PHPThumb;
use PHPThumb\PluginInterface;

/**
 * Sharpen plugin
 *
 * @author Miguel Vieira <vieira@miguelvieira.com.pt>
 */
class Sharpen implements PluginInterface
{
    /**
     * @var int
     */
    protected $offset = 0;

    /**
     * @var array
     */
    protected $matrix = [
        [0.0, -1.0, 0.0],
        [-1.0, 5.0, -1.0],
        [0.0, -1.0, 0.0],
    ];

    /**
     * @param int $offset Color offset
     * @param int $matrix A 3x3 matrix: an array of three arrays of three floats
     */
    public function __construct($offset = 0, $matrix = [])
    {
        empty($offset) or $this->offset = $offset;
        empty($matrix) or $this->matrix = $matrix;

It seems like $matrix can also be of type integer. However, the property $matrix is declared as type array. Maybe add an additional type check?

    }

    /**
     * @param PHPThumb $phpthumb
     * @return PHPThumb
     */
    public function execute($phpthumb)
    {
        $divisor = array_sum(array_map('array_sum', $this->matrix));
        imageconvolution($phpthumb->getOldImage(), $this->matrix, $divisor, $this->offset);
        return $phpthumb;
    }
}