Issues in DrawServiceFactory.php - New Issues - Inspection of "Requiring PHP 7.1" - webino/WebinoDraw - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 764203...f4bb31 )

by Peter

created 2017-11-30 03:41 UTC

src/WebinoDraw/Factory/DrawServiceFactory.php (2 issues)

Labels

Documentation 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Webino (http://webino.sk)
 *
 * @link        https://github.com/webino/WebinoDraw for the canonical source repository
 * @copyright   Copyright (c) 2012-2017 Webino, s. r. o. (http://webino.sk)
 * @author      Peter Bačinský <[email protected]>
 * @license     BSD-3-Clause
 */

namespace WebinoDraw\Factory;

use WebinoDraw\Instructions\InstructionsRenderer;
use WebinoDraw\Options\ModuleOptions;
use WebinoDraw\Service\DrawService;
use Zend\ServiceManager\FactoryInterface;
use Zend\ServiceManager\ServiceLocatorInterface;

/**
 * Class DrawServiceFactory
 */
class DrawServiceFactory implements FactoryInterface
{
    /**
     * @param ServiceLocatorInterface $services
     * @return DrawService
     */
    public function createService(ServiceLocatorInterface $services)
    {
        return new DrawService(
            $services->get(ModuleOptions::SERVICE),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $services->get(InstructionsRenderer::class)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
    }
}


1			<?php
2			/**
3			* Webino (http://webino.sk)
4			*
5			* @link https://github.com/webino/WebinoDraw for the canonical source repository
6			* @copyright Copyright (c) 2012-2017 Webino, s. r. o. (http://webino.sk)
7			* @author Peter Bačinský <[email protected]>
8			* @license BSD-3-Clause
9			*/
10
11			namespace WebinoDraw\Factory;
12
13			use WebinoDraw\Instructions\InstructionsRenderer;
14			use WebinoDraw\Options\ModuleOptions;
15			use WebinoDraw\Service\DrawService;
16			use Zend\ServiceManager\FactoryInterface;
17			use Zend\ServiceManager\ServiceLocatorInterface;
18
19			/**
20			* Class DrawServiceFactory
21			*/
22			class DrawServiceFactory implements FactoryInterface
23			{
24			/**
25			* @param ServiceLocatorInterface $services
26			* @return DrawService
27			*/
28			public function createService(ServiceLocatorInterface $services)
29			{
30			return new DrawService(
31			$services->get(ModuleOptions::SERVICE),
			0 ignored issues – show Documentation introduced 2015-12-15 01:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$services->get(\WebinoDr...ModuleOptions::SERVICE)` is of type `object\|array`, but the function expects a `object<WebinoDraw\Options\ModuleOptions>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32			$services->get(InstructionsRenderer::class)
			0 ignored issues – show Documentation introduced 2015-12-15 01:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$services->get(\WebinoDr...uctionsRenderer::class)` is of type `object\|array`, but the function expects a `object<WebinoDraw\Instru...s\InstructionsRenderer>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33			);
34			}
35			}
36

webino / WebinoDraw

Push — develop ( 764203...f4bb31 )

src/WebinoDraw/Factory/DrawServiceFactory.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like