DrawAjaxHtmlStrategy - Code Metrics - webino/WebinoDraw - Measure and Improve Code Quality continuously with Scrutinizer

DrawAjaxHtmlStrategy A
last analyzed 2019-12-25 16:24 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	5
dl	0
loc	39
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	createMarkup()	0	15	3
A	respond()	0	7	1

<?php
/**
 * Webino (http://webino.sk)
 *
 * @link        https://github.com/webino/WebinoDraw for the canonical source repository
 * @copyright   Copyright (c) 2012-2017 Webino, s. r. o. (http://webino.sk)
 * @author      Peter Bačinský <[email protected]>
 * @license     BSD-3-Clause
 */

namespace WebinoDraw\View\Strategy;

use WebinoDraw\Dom\Document;
use WebinoDraw\Event\AjaxEvent;
use WebinoDraw\Exception;

/**
 * Draw matched containers and return the JSON XHTML of matched fragments
 */
class DrawAjaxHtmlStrategy extends AbstractDrawAjaxStrategy
{
    /**
     * Return XHTML parts of nodes matched by XPath
     *
     * @param Document $dom
     * @param string $xpath
     * @return array
     * @throws Exception\RuntimeException
     */
    public function createMarkup(Document $dom, $xpath)
    {
        $markup = '';
        foreach ($dom->getXpath()->query($xpath) as $item) {

            $itemId = $item->getAttribute('id');
            if (empty($itemId)) {
                throw new Exception\RuntimeException('Required ajax fragment element id');
            }

            $markup.= $dom->saveHTML($item);
        }

        return $markup;
    }

    /**
     * @param Document $dom
     * @param string $xpath
     * @return string
     */
    protected function respond(Document $dom, $xpath)
    {
        $ajaxEvent = $this->getEvent();
        $ajaxEvent->setFragmentXpath($xpath);
        $this->getEventManager()->trigger(AjaxEvent::EVENT_AJAX, $ajaxEvent);
        return $this->createMarkup($dom, $ajaxEvent->getFragmentXpath());
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1			<?php
2			/**
3			* Webino (http://webino.sk)
4			*
5			* @link https://github.com/webino/WebinoDraw for the canonical source repository
6			* @copyright Copyright (c) 2012-2017 Webino, s. r. o. (http://webino.sk)
7			* @author Peter Bačinský <[email protected]>
8			* @license BSD-3-Clause
9			*/
10
11			namespace WebinoDraw\View\Strategy;
12
13			use WebinoDraw\Dom\Document;
14			use WebinoDraw\Event\AjaxEvent;
15			use WebinoDraw\Exception;
16
17			/**
18			* Draw matched containers and return the JSON XHTML of matched fragments
19			*/
20			class DrawAjaxHtmlStrategy extends AbstractDrawAjaxStrategy
21			{
22			/**
23			* Return XHTML parts of nodes matched by XPath
24			*
25			* @param Document $dom
26			* @param string $xpath
27			* @return array
28			* @throws Exception\RuntimeException
29			*/
30			public function createMarkup(Document $dom, $xpath)
31			{
32			$markup = '';
33			foreach ($dom->getXpath()->query($xpath) as $item) {
34
35			$itemId = $item->getAttribute('id');
36			if (empty($itemId)) {
37			throw new Exception\RuntimeException('Required ajax fragment element id');
38			}
39
40			$markup.= $dom->saveHTML($item);
41			}
42
43			return $markup;
44			}
45
46			/**
47			* @param Document $dom
48			* @param string $xpath
49			* @return string
50			*/
51			protected function respond(Document $dom, $xpath)
52			{
53			$ajaxEvent = $this->getEvent();
54			$ajaxEvent->setFragmentXpath($xpath);
55			$this->getEventManager()->trigger(AjaxEvent::EVENT_AJAX, $ajaxEvent);
56			return $this->createMarkup($dom, $ajaxEvent->getFragmentXpath());
			0 ignored issues – show Bug Best Practice introduced 2015-12-15 01:22 UTC by Report Bug Copy Issue Report The return type of `return $this->createMark...t->getFragmentXpath());` (`string`) is incompatible with the return type declared by the abstract method `WebinoDraw\View\Strategy...awAjaxStrategy::respond` of type `WebinoDraw\Ajax\Json`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
57			}
58			}
59

webino / WebinoDraw

DrawAjaxHtmlStrategy A last analyzed 2019-12-25 16:24 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

DrawAjaxHtmlStrategy A
last analyzed 2019-12-25 16:24 UTC