DrawServiceFactory   A
last analyzed

Complexity

Total Complexity 1

Size/Duplication

Total Lines 14
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 2

Importance

Changes 0
Metric Value
wmc 1
lcom 0
cbo 2
dl 0
loc 14
rs 10
c 0
b 0
f 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A createService() 0 7 1
1
<?php
2
/**
3
 * Webino (http://webino.sk)
4
 *
5
 * @link        https://github.com/webino/WebinoDraw for the canonical source repository
6
 * @copyright   Copyright (c) 2012-2017 Webino, s. r. o. (http://webino.sk)
7
 * @author      Peter Bačinský <[email protected]>
8
 * @license     BSD-3-Clause
9
 */
10
11
namespace WebinoDraw\Factory;
12
13
use WebinoDraw\Instructions\InstructionsRenderer;
14
use WebinoDraw\Options\ModuleOptions;
15
use WebinoDraw\Service\DrawService;
16
use Zend\ServiceManager\FactoryInterface;
17
use Zend\ServiceManager\ServiceLocatorInterface;
18
19
/**
20
 * Class DrawServiceFactory
21
 */
22
class DrawServiceFactory implements FactoryInterface
23
{
24
    /**
25
     * @param ServiceLocatorInterface $services
26
     * @return DrawService
27
     */
28
    public function createService(ServiceLocatorInterface $services)
29
    {
30
        return new DrawService(
31
            $services->get(ModuleOptions::SERVICE),
0 ignored issues
show
Documentation introduced by
$services->get(\WebinoDr...ModuleOptions::SERVICE) is of type object|array, but the function expects a object<WebinoDraw\Options\ModuleOptions>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
32
            $services->get(InstructionsRenderer::class)
0 ignored issues
show
Documentation introduced by
$services->get(\WebinoDr...uctionsRenderer::class) is of type object|array, but the function expects a object<WebinoDraw\Instru...s\InstructionsRenderer>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
33
        );
34
    }
35
}
36