Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
17 | View Code Duplication | trait ElementsTrait |
|
18 | { |
||
19 | /** |
||
20 | * Returns WebDriver session |
||
21 | * |
||
22 | * @return \PHPWebDriver_WebDriverSession |
||
23 | */ |
||
24 | abstract protected function getSession(); |
||
25 | |||
26 | /** |
||
27 | * Returns page elements by class name |
||
28 | * |
||
29 | * @param string $className |
||
30 | * @return \PHPWebDriver_WebDriverElement[]|WebDriver\ElementInterface[] |
||
31 | */ |
||
32 | protected function elementsByClassName($className) |
||
36 | |||
37 | /** |
||
38 | * Returns page elements by CSS selector |
||
39 | * |
||
40 | * @param string $selector |
||
41 | * @return \PHPWebDriver_WebDriverElement[]|WebDriver\ElementInterface[] |
||
42 | */ |
||
43 | protected function elementsByCssSelector($selector) |
||
47 | |||
48 | /** |
||
49 | * Returns page elements by ID |
||
50 | * |
||
51 | * @param string $id |
||
52 | * @return \PHPWebDriver_WebDriverElement[]|WebDriver\ElementInterface[] |
||
53 | */ |
||
54 | protected function elementsById($id) |
||
58 | |||
59 | /** |
||
60 | * Returns page elements by link text |
||
61 | * |
||
62 | * @param string $text |
||
63 | * @return \PHPWebDriver_WebDriverElement[]|WebDriver\ElementInterface[] |
||
64 | */ |
||
65 | protected function elementsByLinkText($text) |
||
69 | |||
70 | /** |
||
71 | * Returns page elements by its name |
||
72 | * |
||
73 | * @param string $name |
||
74 | * @return \PHPWebDriver_WebDriverElement[]|WebDriver\ElementInterface[] |
||
75 | */ |
||
76 | protected function elementsByName($name) |
||
80 | |||
81 | /** |
||
82 | * Returns page elements by its name |
||
83 | * |
||
84 | * @param string $name |
||
85 | * @return \PHPWebDriver_WebDriverElement[]|WebDriver\ElementInterface[] |
||
86 | */ |
||
87 | protected function elementsByPartialLinkText($name) |
||
91 | |||
92 | /** |
||
93 | * Returns page elements by its tag name |
||
94 | * |
||
95 | * @param string $tag |
||
96 | * @return \PHPWebDriver_WebDriverElement[]|WebDriver\ElementInterface[] |
||
97 | */ |
||
98 | protected function elementsByTagName($tag) |
||
102 | |||
103 | /** |
||
104 | * Returns page elements by XPath |
||
105 | * |
||
106 | * @param string $xpath |
||
107 | * @return \PHPWebDriver_WebDriverElement[]|WebDriver\ElementInterface[] |
||
108 | */ |
||
109 | protected function elementsByXpath($xpath) |
||
113 | } |
||
114 |